From 953cb48dbe17c96e9a4401a016bd2c7b7cf2bf18 Mon Sep 17 00:00:00 2001 From: FredKiefer Date: Mon, 8 Jan 2001 01:04:58 +0000 Subject: [PATCH] [setTarget:] don't retain target to avoid retain cycle in NSScrollView. [initWithCoder:] release target after decoding. git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@8497 72102866-910b-0410-8b05-ffd578937521 --- Source/NSScroller.m | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Source/NSScroller.m b/Source/NSScroller.m index 42e3c5ca8..6a1ea352f 100644 --- a/Source/NSScroller.m +++ b/Source/NSScroller.m @@ -126,7 +126,7 @@ static NSColor *scrollBarColor = nil; - (void) setTarget: (id)target { - ASSIGN(_target, target); + _target = target; } - (id) target @@ -172,6 +172,8 @@ static NSColor *scrollBarColor = nil; [aDecoder decodeValueOfObjCType: @encode(unsigned int) at: &_arrowsPosition]; [aDecoder decodeValueOfObjCType: @encode(BOOL) at: &_isEnabled]; [aDecoder decodeValueOfObjCType: @encode(id) at: &_target]; + // Undo RETAIN by decoder + TEST_RELEASE(_target); [aDecoder decodeValueOfObjCType: @encode(SEL) at: &_action]; [self drawParts];