* Source/NSApplication.m (-targetForAction:to:from:): Warn about

the target not responding to the action.
* Source/NSSavePanel.m (_initWithoutGModel): Don't set the OK
button as the target of the browser. Use helper method instead.
This commit is contained in:
fredkiefer 2018-01-23 20:56:52 +01:00
parent b9b0b3b56f
commit 9451330883
3 changed files with 14 additions and 3 deletions

View file

@ -1,3 +1,10 @@
2018-01-23 Fred Kiefer <FredKiefer@gmx.de>
* Source/NSApplication.m (-targetForAction:to:from:): Warn about
the target not responding to the action.
* Source/NSSavePanel.m (_initWithoutGModel): Don't set the OK
button as the target of the browser. Use helper method instead.
2018-01-22 Gregory John Casamento <greg.casamento@gmail.com>
* Tools/speech/GSSpeechSynthesizer.m: Correct compilation

View file

@ -2273,6 +2273,7 @@ IF_NO_GC(NSAssert([event retainCount] > 0, NSInternalInconsistencyException));
}
else
{
NSLog(@"Target %@ does not respont to action %@", theTarget, NSStringFromSelector(theAction));
return nil;
}
}

View file

@ -233,6 +233,7 @@ setPath(NSBrowser *browser, NSString *path)
[_browser setAutoresizingMask: NSViewWidthSizable|NSViewHeightSizable];
[_browser setTag: NSFileHandlingPanelBrowser];
[_browser setAction: @selector(_selectText:)];
[_browser setDoubleAction: @selector(_doubleClick:)];
[_browser setTarget: self];
[_browser setMinColumnWidth: 140];
[_topView addSubview: _browser];
@ -346,9 +347,6 @@ setPath(NSBrowser *browser, NSString *path)
[self setDefaultButtonCell: [_okButton cell]];
[_okButton release];
[_browser setDoubleAction: @selector(performClick:)];
[_browser setTarget: _okButton];
r = NSMakeRect (8, 261, 48, 48);
image = [[NSApplication sharedApplication] applicationIconImage];
imageView = [[NSImageView alloc] initWithFrame: r];
@ -508,6 +506,11 @@ setPath(NSBrowser *browser, NSString *path)
}
}
- (void) _doubleClick: (id)sender
{
[_okButton performClick: sender];
}
- (void) _selectText: (id)sender
{
[self _selectTextInColumn:[_browser selectedColumn]];