Corrected dismissing of popup button cell menu.

git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@21270 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Fred Kiefer 2005-05-30 19:19:42 +00:00
parent 162d86266e
commit 8293b1e6a3
2 changed files with 12 additions and 2 deletions

View file

@ -1,3 +1,10 @@
2005-05-30 Fred Kiefer <FredKiefer@gmx.de>
* Source/NSPopupButtonCell.m (-dealloc) Corrected previous fix to only
dismiss the popup, when it is actualy visible. This caused a
problem with the window deallocation mechanism, when the window
containing the popup button was closed.
2005-05-30 Fred Kiefer <FredKiefer@gmx.de>
* Source/NSTableView.m (-mouseDown): No longer copy the cell, as
@ -16,7 +23,7 @@
2005-05-27 Fred Kiefer <FredKiefer@gmx.de>
* Source/NSPopupButton.m (-dealloc) Dismiss the popup. This is to
* Source/NSPopupButtonCell.m (-dealloc) Dismiss the popup. This is to
make sure the removed popup no longer gets notifications. may
happen when the cell gets deallocated without closing the popup.

View file

@ -90,7 +90,10 @@ static NSImage *_pbc_image[2];
* while the popup is still displayed. In that case the notification
* center would still send notifications to the deallocated cell.
*/
[self dismissPopUp];
if ([[_menu window] isVisible])
{
[self dismissPopUp];
}
/*
* We don't use methods here to clean up the selected item, the menu
* item and the menu as these methods internally update the menu,