From 81abfa70c7752cefe8db7f149deb07a3cd225e2f Mon Sep 17 00:00:00 2001 From: Fred Kiefer Date: Mon, 7 Feb 2005 21:27:06 +0000 Subject: [PATCH] Corrected bug #11885 on NSOutlineView, this could be optimised further. git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@20668 72102866-910b-0410-8b05-ffd578937521 --- ChangeLog | 9 ++++++++- Source/NSOutlineView.m | 10 +++++++--- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index d9ff1ad52..1a91758d4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2005-02-07 Fred Kiefer + + * Source/NSTableView.m (-expandItem:expandChildren:, + collapseItem:collapseChildren:): Added a call to setNeedsDisplay:, + so the new status will be shown correctly. + (_openItem:): Removed setNeedsDisplay: call as all callers do it already. + 2005-02-05 15:42 Gregory John Casamento * Headers/AppKit/NSDataLinkManager.h: Moved NSDataLinkManager delegate @@ -158,7 +165,7 @@ 2005-01-20 Fred Kiefer - * Source/NSTableView.m (-rowAtPoint:): If the heigh of the table + * Source/NSTableView.m (-rowAtPoint:): If the heigh of the table is incorrect and because of this the row would be greater than the number of rows, return a usable number. diff --git a/Source/NSOutlineView.m b/Source/NSOutlineView.m index f36d072d4..a60c1ff24 100644 --- a/Source/NSOutlineView.m +++ b/Source/NSOutlineView.m @@ -279,6 +279,8 @@ static NSImage *unexpandable = nil; } } [self noteNumberOfRowsChanged]; + // Should only mark the rect below the closed item for redraw + [self setNeedsDisplay: YES]; } } @@ -366,9 +368,12 @@ static NSImage *unexpandable = nil; [self expandItem: child expandChildren: expandChildren]; } } - } + } + + [self noteNumberOfRowsChanged]; + // Should only mark the rect below the expanded item for redraw + [self setNeedsDisplay: YES]; } - [self noteNumberOfRowsChanged]; } /** @@ -1802,7 +1807,6 @@ static NSImage *unexpandable = nil; insertionPoint++; } - [self setNeedsDisplay: YES]; for(i=numchildren-1; i >= 0; i--) { id obj = NSMapGet(_itemDict, sitem);