diff --git a/ChangeLog b/ChangeLog index c36e41caa..c692324cf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2011-03-14 Eric Wasylishen + + * Source/NSMenuItemCell.m: Add missing -retain for key + equivalent modifier strings + 2011-03-14 Eric Wasylishen * Headers/AppKit/NSSavePanel.h: Add OS 10.6 #ifdef around diff --git a/Source/NSMenuItemCell.m b/Source/NSMenuItemCell.m index bd258c2d4..963224a74 100644 --- a/Source/NSMenuItemCell.m +++ b/Source/NSMenuItemCell.m @@ -67,22 +67,22 @@ static NSString *commandKeyString = @"#"; keyString = [userDefaults objectForKey: @"GSControlKeyString"]; if (nil != keyString) { - controlKeyString = keyString; + controlKeyString = [keyString retain]; } keyString = [userDefaults objectForKey: @"GSAlternateKeyString"]; if (nil != keyString) { - alternateKeyString = keyString; + alternateKeyString = [keyString retain]; } keyString = [userDefaults objectForKey: @"GSShiftKeyString"]; if (nil != keyString) { - shiftKeyString = keyString; + shiftKeyString = [keyString retain]; } keyString = [userDefaults objectForKey: @"GSCommandKeyString"]; if (nil != keyString) { - commandKeyString = keyString; + commandKeyString = [keyString retain]; } } }