From 5d9e49a2ff8a9bf6291926a74b6208332eaebabd Mon Sep 17 00:00:00 2001 From: Gregory John Casamento Date: Thu, 8 Aug 2024 18:20:00 -0400 Subject: [PATCH] Remove both instances where we get properties from the binding where it is not needed during the loading process, per discussion with @fredkiefer --- Source/NSTableView.m | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/Source/NSTableView.m b/Source/NSTableView.m index 33a9d8643..86b978520 100644 --- a/Source/NSTableView.m +++ b/Source/NSTableView.m @@ -3326,16 +3326,11 @@ byExtendingSelection: (BOOL)flag errorDescription: &error] == YES) { NSTableColumn *tb; - GSKeyValueBinding *theBinding = nil; [_editedCell setObjectValue: newObjectValue]; tb = [_tableColumns objectAtIndex: _editedColumn]; - theBinding = [GSKeyValueBinding getBinding: NSValueBinding - forObject: tb]; - - if (_dataSource_editable - || theBinding != nil) + if (_dataSource_editable) { [self _setObjectValue: newObjectValue forTableColumn: tb @@ -3366,18 +3361,13 @@ byExtendingSelection: (BOOL)flag if (validatedOK) { NSTableColumn *tb; - GSKeyValueBinding *theBinding = nil; [_editedCell setStringValue: string]; tb = [_tableColumns objectAtIndex: _editedColumn]; - theBinding = [GSKeyValueBinding getBinding: NSValueBinding - forObject: tb]; - - if (_dataSource_editable - || theBinding != nil) + if (_dataSource_editable) { - [self _setObjectValue: string // newObjectValue + [self _setObjectValue: string forTableColumn: tb row: _editedRow]; }