Prevent potential crashes due to invalid pointers left in text

containers and layout managers when their respective layout manager
and text storage are deallocated.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35178 72102866-910b-0410-8b05-ffd578937521

ChangeLog

@@ -1,3 +1,13 @@
+2012-06-05  Wolfgang Lux  <wolfgang.lux@gmail.com>
+
+	* Source/GSLayoutManager.m (-dealloc): Set layout manager of every
+	text container to nil to avoid dangling pointer in case the text
+	container is retained elsewhere.
+
+	* Source/NSTextStorage.m (-dealloc): Set text storage of every
+	layout manager to nil to avoid dangling pointer in case the layout
+	manager is retained elsewhere.
+
 2012-06-03  Wolfgang Lux  <wolfgang.lux@gmail.com>
 
 	* Source/NSTextView.m (-performUndo): Update text storage directly

Source/GSLayoutManager.m

@@ -2918,6 +2918,7 @@ forStartOfGlyphRange: (NSRange)glyphRange
   [self _freeLayout];
   for (i = 0, tc = textcontainers; i < num_textcontainers; i++, tc++)
     {
+      [tc->textContainer setLayoutManager: nil];
       [tc->textContainer release];
     }
   free(textcontainers);

Source/NSTextStorage.m

@@ -61,6 +61,8 @@ static NSNotificationCenter *nc = nil;
 - (void) dealloc
 {
   [self setDelegate: nil];
+  [_layoutManagers makeObjectsPerformSelector: @selector(setTextStorage:)
+				   withObject: nil];
   RELEASE (_layoutManagers);
   [super dealloc];
 }