gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-04-23 07:00:46 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fixed sending out the controlTextDidBeginEditingNotification

Browse source 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@14626 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Nicola Pero 2002-10-02 10:36:37 +00:00
parent 3fa5c40601
commit 4c709da872
2 changed files with 35 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ChangeLog
View file

@ -1,3 +1,11 @@
Wed Oct 2 11:26:21 2002 Nicola Pero <n.pero@mi.flashnet.it>
* Source/NSTextView.m
([-shouldChangeTextInRange:replacementString:]): Immediately
return NO if not editable; do not send out textShouldBeginEditing:
and textDidBeginEditingNotification unless the textview is already
first responder (Patch by David Ayers <d.ayers@inode.at>).
2002-10-01 Richard Frith-Macdonald <rfm@gnu.org>
* Source/NSWorkspace.m: ([-gtInfoForFile:application:type:])

28
Source/NSTextView.m
View file

@ -2242,10 +2242,36 @@ replacing the selection.
[self unregisterDraggedTypes];
}
/*
* If the receiver is first responder, this method is responsible for
* checking with the delegate, whether textShouldBeginEditing: and to
* post the NSTextDidBeginEditingNotification, if it should. This
* method returns NO immediately, if the corresponding text field is
* not editable. This insures that no user action can accidentally
* edit the contents.
*/
- (BOOL) shouldChangeTextInRange: (NSRange)affectedCharRange
replacementString: (NSString*)replacementString
{
if (BEGAN_EDITING == NO)
if (_tf.is_editable == NO)
return NO;
/* We need to send the textShouldBeginEditing: /
textDidBeginEditingNotification only once; and we need to send it
when the textview is firstResponder. This is particular
important for text field editors, which are set up and whose
text, colors, background, etc are configured (potentially causing
calls to this method) before their delegate is set up and they
are made first responder - we want no textDidBeginEditing
notification to be sent out at that stage, because it would be
lost (the control is not yet the delegate). Instead, once the
field editor has a delegate (the control) and is made first
responder, we want to send out the textDidBeginEditing
notification (which will cause the control to send out the
NSControlTextDidBeginEditingNotification) at the first user
input.
*/
if (BEGAN_EDITING == NO && [_window firstResponder] == self)
{
if (([_delegate respondsToSelector: @selector(textShouldBeginEditing:)])
&& ([_delegate textShouldBeginEditing: _notifObject] == NO))