Fix issues pointed out by @fredkiefer

This commit is contained in:
Gregory John Casamento 2024-08-04 18:44:01 -04:00
parent 329553c196
commit 21d0bc906e
6 changed files with 5 additions and 7 deletions

View file

@ -7,7 +7,7 @@
* Source/GSControllerTreeProxy.[hm]: Proxy class
for NSTreeController, a subclass of NSTreeNode.
* Source/GSThemeDrawing.m: Optimize code a bit and
add changes for binfings.
add changes for bindings.
* Source/GSXib5KeyedUnarchiver.m: Add support for new keys
on NSTreeController.
* Source/NSKeyValueBinding.m: Add new methods to

View file

@ -81,7 +81,7 @@
return [self children];
}
- (NSArray *) mutableChildNodes
- (NSMutableArray *) mutableChildNodes
{
return [self children];
}

View file

@ -122,6 +122,7 @@ static NSNotificationCenter *nc;
- (void) dealloc
{
[GSKeyValueBinding unbindAllForObject: self];
RELEASE(_cell);
[super dealloc];
}

View file

@ -192,11 +192,11 @@ void GSBindingInvokeAction(NSString *targetKey, NSString *argumentKey,
if (!objectTable)
return nil;
NSDebugLog(@"+++ called with %@, %@", binding, anObject);
NSDebugLLog(@"NSBinding", @"+++ called with %@, %@", binding, anObject);
[bindingLock lock];
bindings = (NSMutableDictionary *)NSMapGet(objectTable, (void *)anObject);
NSDebugLog(@"+++ Bindings found for %@ => %@", anObject, bindings);
NSDebugLLog(@"NSBinding", @"+++ Bindings found for %@ => %@", anObject, bindings);
if (bindings != nil)
{
theBinding = (GSKeyValueBinding*)[bindings objectForKey: binding];

View file

@ -2084,8 +2084,6 @@ static void computeNewSelection
{
[self abortEditing];
[GSKeyValueBinding unbindAllForObject: self];
RELEASE (_gridColor);
RELEASE (_backgroundColor);
RELEASE (_tableColumns);

View file

@ -47,7 +47,6 @@
- (void) _setParentNode: (NSTreeNode*)parentNode
{
NSLog(@"parentNode = %@", parentNode);
_parentNode = parentNode;
}