gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-04-22 19:01:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #341 from gnustep/improve_helpviewer_check

Browse source 
Use NSWorkspace inforForExcetsion to check if current registred HelpViewer is capable of showing the Help File, otherwise fall-back to NSWorkspace open as if no HelpViewer is set
This commit is contained in:
Riccardo 2025-04-01 16:17:15 +02:00 committed by GitHub
commit 0421737ed5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
Source/NSHelpManager.m
View file

@ -215,27 +215,16 @@
{
if (viewer && [viewer length] > 0)
{
NSBundle *appBundle = [ws bundleForApp: viewer];
NSArray *types;
NSMutableArray *extensions = [NSMutableArray array];
NSDictionary *apps = [ws infoForExtension: ext];
NSDictionary *appInfo;
types = [appBundle objectForInfoDictionaryKey:@"NSTypes"];
if (types)
{
NSUInteger i;
// Let's try to be lenient if Viewer was set instead of Viewer.app
if ([[viewer pathExtension] length] == 0)
viewer = [viewer stringByAppendingPathExtension: @"app"];
appInfo = [apps objectForKey: viewer];
for (i = 0; i < [types count]; i++)
{
NSArray *unixExtensions;
NSUInteger j;
unixExtensions = [[types objectAtIndex: i] objectForKey:@"NSUnixExtensions"];
for (j = 0; j < [unixExtensions count]; j++)
[extensions addObject: [[unixExtensions objectAtIndex:j] lowercaseString]];
}
}
if (![extensions containsObject:[ext lowercaseString]])
// We ingore the role, supposing both Editor and Viewer are fine
if (nil == appInfo)
{
NSWarnLog(@"Designated viewer %@ is not registered for %@", viewer, ext);
viewer = nil;