libs-gui/ChangeLog

2006-05-10  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSBundleAdditions.m: ([loadNibNamed:owner:]) if the NIB can't
	be found in the owners bundle, try the main bundle of the application.
	Fixes loading where the files owner is in a library, framework or
	bundle, but the Gorm/NIB file is in the application resources.
	I'm not sure this is the correct order, perhaps we should try the
	main bundle first and the library/framework only if the rersource
	is not in the main bundle.

2006-05-06  Fred Kiefer <FredKiefer@gmx.de>

	* Resources/Esperanto.lproj/Localizable.string,
	* Resources/German.lproj/Localizable.string: New string
	translations. Patch by Ingolf Jandt <i.jandt@web.de>.	
	* Resources/GNUmakefile: Added new languages.

2006-05-06  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSTableView.m (-_editNextEditableCellAfterRow:column:,
	_editPreviousEditableCellBeforeRow:column:) Select the new row
	before editing a cell. 
	* Source/NSComboBoxCell.m (GSComboWindow -validateSelection):
	Removed the didChangeText call on the textObject.      
	Patches by Andreas Höschler <ahoesch@smartsoft.de>.
	
2006-05-05  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSWindow.m: ([-makeFirstResponder:]) fixed for nil argument.
	* Headers/AppKit/NSWindow.h: documented method.

2006-05-03  Fred Kiefer <FredKiefer@gmx.de>

	* Headers/Additions/GNUstepGUI/GSDisplayServer.h (-nativeWindow:::::):
	Added new method.
	* Source/GSDisplayServer.m (-nativeWindow:::::):
	Implemented this method as subclassResponsibility.
	* Source/NSWindow.m (-initWithWindowRef:], -windowRef):
	Implemented these methods to wrap native window into GNUstep windows.

2006-05-01  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSMatrix..m: ([performKeyEquivalent:]) Check modifier flags
	of cells when determining whether to perform their key equivalents.
	* Source/NSMenu.m: ([performKeyEquivalent:]) Use key equivalent
	modifier mask as suggested by Fred, rather than original hard-coded
	command modifier.

2006-04-30  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSMenu.m: ([performKeyEquivalent:]) Ignore key eqivalents other
	than carriage return if the command key is not pressed.

2006-04-30  David Ayers  <d.ayers@inode.at>

	* ColorPickers/GSNamedColorPicker.m ([-browser:selectRow:inColumn:]):
	Return NO as default value.
	
2006-04-29  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSWindow.m: ([-performKeyEquivalent:]) revert last change as
	it broke things because I accidentally faileds to commit corresponding
	NSMenu fix, and because I'm not sure it should be doing it anyway.

2006-04-28  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSApplication.m: ([-sendEvent:]) try key equivalents for
	every key down, not just command modifiers ... consistent with
	MacOS-X and allows carriage return as a button/menu key.
	* Source/NSWindow.m: ([-performKeyEquivalent:]) only pass on to
	our views if this is the key window (NSMenu overrides this).

2006-04-27  Sergii Stoian <stoyan255@yahoo.com>

	* Source/NSMenuView.m (-rectOfItemAtIndex:): Delete origin.x fiddling 
	code because it's not correct. The code wich draws heavy line have to
	update _leftBorderOffset instead.
	(-drawRect:): Always draw dark gray upper and left border.
	
2006-04-24  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSDocumentController.m (-makeUntitledDocumentOfType:):
	Set the type of the new document. Patch by Saso Kiselkov
	<diablos@manga.sk>. 

2006-04-19  Adam Fedor  <fedor@gnu.org>

	* configure: Add arg to disable aspell (for use on Mac OS X).
	
	* Source/NSBitmapImageRep+JPEG.m: Add workaround so that INT32
	is not redefined on MingW by jmorecfg.h (Suggestion from Issac
	Trotts).

2006-04-09 12:28 Gregory John Casamento <greg_casamento@yahoo.com>

	* Tools/gopen.m: Streamline gopen code.

2006-04-06  Adam Fedor  <fedor@gnu.org>

	* Tools/gcloseall.m: Include NSProcessInfo.h. Fixes bug #16212.

2006-03-31  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSMenuView.m: ([-rectOfItemAtIndex:]) fixup origin of
	rectangle to avoid overwriting dark line at left of menu.
	* Source/NSMenu.m: make transient main menu shitf on screen.
	fix bug #15935

2006-03-30  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/GSMemoryPanel.m: Extend to allow snapshots of the memory
	to be taken so we can compare memory at different points in time.
	Simplify code and fix bug where re-ordering sort in table would
	also change table contents.

2006-03-26  Maurizio Boriani  <baux@gnu.org>

	* Resources/Italian.lproj/Localizable.string: Add missing translations.
	* Resources/Lojban.lproj/Localizable.string: New, lojban strings
	translation.

2006-03-28 20:21 Gregory John Casamento <greg_casamento@yahoo.com>

	* Tools/gopen.m: Added back code in to launch the application properly
	with the -a option.

2006-03-26 12:52 Gregory John Casamento <greg_casamento@yahoo.com>

	* Headers/AppKit/NSPopUpButtonCell.h: Refactored header, 
	added documentation
	* Source/NSNib.m: Added documentation.
	* Source/NSPopUpButtonCell.m: Improved documentation.

2006-03-26  Fred Kiefer <FredKiefer@gmx.de>

	* Headers/AppKit/NSSearchFieldCell.h:
	* Headers/AppKit/NSSearchField.h:
	* Source/NSSearchField.m:
	* Source/NSSearchFieldCell.m: Added headers and basic
	implementation for these classes based on code by 
	Nikolaus Schaller <hns@computer.org>.
	* Source/GNUmakefile: Handle these new classes.

2006-03-24  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSStepperCell.m: Rewrote all button drawing functions to
	use new helper function DrawLightButton to honour colour settings.
	Based on patch idea by Ingolf Jandt <i.jandt@web.de>.
	* Source/NSStepperCell.m (-highlight:upButton:withFrame:inView:):
	Simplified to use [drawWithFrame:inView:].
	* Source/NSColorPanel.m (-_initWithoutGModel): Enable colour wells
	in bottom list.

2006-03-20  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSMenuView.m: ([-rectOfItemAtIndex:]) remove unused code and
	tidy a bit (problem pointed out by Matt Rice).

2006-03-19  Nicolas Roard <nicolas@roard.com>

	* Source/NSSliderCell.m:
	* Source/NSTabView.m:
	* Images/common_SliderHoriz.tiff:
	* Images/common_SliderVert.tiff:
	* Images/common_SwitchOff.tiff:
	* Images/common_SwitchOn.tiff:
	* Images/common_TabDownSelectedLeft.tiff:
	* Images/common_TabDownSelectedRight.tiff:
	* Images/common_TabDownSelectedToUnSelectedJunction.tiff:
	* Images/common_TabDownUnSelectedJunction.tiff:
	* Images/common_TabDownUnSelectedLeft.tiff:
	* Images/common_TabDownUnSelectedRight.tiff:
	* Images/common_TabDownUnSelectedToSelectedJunction.tiff:
	* Images/common_TabSelectedLeft.tiff:
	* Images/common_TabSelectedRight.tiff:
	* Images/common_TabSelectedToUnSelectedJunction.tiff:
	* Images/common_TabUnSelectedJunction.tiff:
	* Images/common_TabUnSelectedLeft.tiff:
	* Images/common_TabUnSelectedRight.tiff:
	* Images/common_TabUnSelectToSelectedJunction.tiff:
	Updated images for the sliders, tabviews and switch buttons. They are
	now transparent; the background is thus filled in the code using [NSColor controlBackgroundColor]. 
	That way the current color scheme is followed. 
	Thanks to Ingolf Jandt <i.jandt@web.de> for the images.

2006-03-13  Adam Fedor  <fedor@gnu.org>

	* Version 0.10.3

2006-03-12  Fred Kiefer <FredKiefer@gmx.de>

	* Source/GNUmakefile:
	* Source/GNUmakefile.preamble:
	* Source/GNUmakefile.postamble: 
	Install header file Cocoa.h.
	
2006-03-08  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/GSServicesManager.m: avoid use of deprecated method.

2006-03-05  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSScreen.m: ([-visibleFrame]) fix to work when using
	mac style horizontal menu.

2006-03-01  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSMenuView.m: ([-rectOfItemAtIndex:]) Fix bug #15934 by
	removing some bogus code left over from incorporating horizontal
	menu.

2006-02-24  Quentin Mathe <qmathe@club-internet.fr>

	* Source/GSToolbar.m: Fixed mismatched method return type between
	header and implementation.
	* Source/GSToolbarView.m: Updated code to reference some external
	classes lazily with NSClassFromString.
	These fixes avoids some compiler warnings.

2006-02-22 23:03 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/NSScreen.m: Correction for visibleFrame, spelling of
	NSInterfaceStyle was incorrect.

2006-02-22  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/GSPrintOperation.m: trap exceptions launching previwer
	* Documentation/GuiUser/DefaultsSuppary.gsdoc: mention GSLPRPrinters
	* Printing/GSLPR/GSLPRPrinter.m: If we set up default printer
	config because there was nothing in the user defaults system, save the
	new config so we don't have to do it again next time.

2006-02-06  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSMatrix.m (-deselectAllCells): Allow empty selection,
	when there are no cells. Patch by Georg Fleischmann <georg@vhf.de>.
	* Source/NSPopupButtonCell.m (-synchronizeTitleAndSelectedItem):
	Don't set selection index to 0, if apopup button doesn't have a
	selection. Patch by Andreas Höschler <ahoesch@smartsoft.de>.

2006-02-05  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSMenuView.m: ([-sizeToFit]) Fix bug #15631
	([-locationForSubmenu:]) for horizontal root menus, make successive
	submenus be positioned with top left corner next to item in parent.
	* Source/NSApplication.m: Pass info in hide/unhide notifications.

2006-02-04  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSMenu.m:
	* Source/NSApplication.m:
	* Source/NSMenuItemCell.m:
	* Headers/AppKit/NSMenuItemCell.h:
	Tidyups suggested by Fred. More ideas welcome.
	* Source/NSMenuView.m: When tracking mouse for horizontal MacOS-X
	style menu, ignore an immediate mouse up and continue tracking until
	something is clicked on.  This is the behavior of MacOS-X and windows.

2006-02-04  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSMenu.m:
	* Source/NSApplication.m:
	* Source/NSMenuItemCell.m:
	* Source/NSMenuView.m:
	* Headers/AppKit/NSMenuView.h:
	* Headers/AppKit/NSMenu.h:
	* Headers/AppKit/NSMenuItemCell.h:
	Add support for horizontal main menu (as in MacOS-X) very heavily
	based on the WildMenus bundle by Michael Hanni, but any errors in
	the integration are entirely mine.
	Horizontal menus are activated by setting the 'NSMenuInterfaceStyle'
	user default to 'NSMacintoshInterfaceStyle'.

2006-02-03  Quentin Mathe <qmathe@club-internet.fr>

    * Source/NSToolbarItem.m (-[GSToolbarButtonCell setImagePosition:]): 
    New method to override NSButtonCell behavior. It should be the last commit
    needed to correct bug #15112 (reported by Wolfgang Sourdeau). Precisely it
    eliminates the default title set with separator or space toolbar
    items and the image release with toolbar items which include one (both
    issues occurs when NSToolbarDisplayModeLabelnOnly is set).

2006-02-03  Quentin Mathe <qmathe@club-internet.fr>

    * Source/NSButtonCell.m (-setImagePosition:): Fixed the title lost (reset to
    the default one) which was wrongly occuring when the image position is
    switched to 'NSNoImage' (partial fix for bug #15112, based on an NSCell
    patch by Wolfgang Sourdeau).

2006-02-03  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSWorkspace.m: In GSLaunched() be more defensive and don't
	assume that the values which should be present in the notification
	userinfo dictionry really are there.
	* Source/NSApplication.m: Code more defensively setting up
	notification info.
	Honor the NSWindow -canHide method when hiding the application.
	* Source/GSServicesManager.m: Improve handling of incoming messages,
	prohibit remote processes from calling private methods.
	* Source/NSWindow.m:
	* Source/NSWindowController.m:
	* Source/NSDataLinkManager.m:
	* Source/NSTextView.m:
	* Source/NSDocumentController.m:
	* Source/NSDataLink.m:
	* Source/NSView.m:
	* Source/NSDocument.m:
	Revert harmless but stupid changes made last night when I was too
	tired.

2006-02-02  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSWorkspace.m: remove an app from list of launched apps if
	we can't contact it.
	* Source/NSApplication.m: ([hideOtherApplications:]) implemented.
	([unhideAllApplications:]) implemented.
	Send did hide and did unhide notifications to the workspace center
	so the workspace manager knows about them.
	Honor the NSWindow-canHide method when deactivating apps.
	* Source/NSWindow.m: Fix accessor methods which return a BOOL to
	do the right thing when they are accessing a bit in a bitfield.
	* Source/NSWindowController.m: ditto
	* Source/NSDataLinkManager.m: ditto
	* Source/NSTextView.m: ditto
	* Source/NSDocumentController.m: ditto
	* Source/NSDataLink.m: ditto
	* Source/NSView.m: ditto
	* Source/NSDocument.m: ditto
	Are these changes nneded?  The compiler seemed to be casting bitfield
	values to char as  things other than 1 or 0 ... but I was tired when
	looking at this and it seems unlikely.

2006-02-01  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSApplication.m: Send activation/deactivation notifications
	to workspace center too ... so workspace manager will know about it.
	* Source/NSWorkspace.m: Change internal method to launch applications
	so that it never asks the workspace manager to do it ... that should
	be handled by the public methods instead.  Simplify a little to take
	advantage of change to NSApplication.

2006-01-27  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSApplication.m: pass more informative user info in
	notifications.
	* Source/NSWorkspace.m: Implement filesystem based fallback mechanisms
	for tracking launched and active appplications when there is no
	workspace manager process to do it.
	Try to be consistent about asking workspace manager application to
	perform tasks for us if it exists.
	* Tools/gscloseall.m: Test tool to iterate through launched apps and
	terminate them all.
	* Tools/GNUmakefile:
	* Tools/GNUmakefile.preamble:
	Build new utility.

2006-01-22  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSPopupButtonCell.m (-synchronizeTitleAndSelectedItem):
	Only select an item if one is highlighted.
	* Source/Functions.m: NSFrameRectWithWidthUsingOperation() new
	function from Cocoa. NSFrameRectWithWidth() different
	implementation, no longer using stroke.

2006-01-20  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSTableHeaderCell.m: Simplified code by letting
	the super classes do their job.

2006-01-14  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSWindow.m: minor fixups for 64bit cpu support.

2006-01-09 06:25 Gregory John Casamento <greg_casamento@yahoo.com>
	
	* Source/NSNib.m: Correction for bug#15348.  Removed uneeded
	append in initWithNibNamed:

2006-01-08  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSTableView.m (-initWithFrame:) Use different intercell
	spacing. Patch by Andreas Höschler <ahoesch@smartsoft.de>.

2006-01-04  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSSliderCell.m (-knobRectFlipped,-knobThickness
	-drawInteriorWithFrame:inView:, -setKnobThickness:): Protect against knob
	image being nil. Fixes Solaris problem reported by <ubossx@gmail.com>.

2005-12-31  Matt Rice  <ratmice@yahoo.com>

	* Source/NSTableView.m (-mouseDown:): Copy the selected cell before
	tracking mouse, add comment. (patch previously reverted 2005-05-30)
	(-mouseDown:): Check for pointer equality in addition to isEqual:
	which doesn't work with nil. (fix for bug #15316)
	
2005-12-22  Adam Fedor  <fedor@gnu.org>

	* Version 0.10.2

2005-12-15  Quentin Mathe <qmathe@club-internet.fr>

    * Source/NSToolbarItem.m: 
    (-[GSToolbarButton layout]): Don't set button based items width to their
    label width when NSToolbarDisplayModeIconOnly is active (based on patch
    by Wolfgang Sourdeau, partial fix for bug #15112). Removed superfuous code
    which substracted label height to button width in
    NSToolbarDisplayModeIconOnly case.
    (-initWithItemIdentifier:): Removed logical operator 'not' wrongly used
    with GSToolbarSeparatorItemIdentifier class identity test, it
    prevented any separator items to be inited therefore used (patch by
    Wolfgang Sourdeau, partial fix for bug #15112).

2005-12-05  fabien  <fabien@sonappart.net>

	* Source/NSCursor.m: Improved documentation
	* Source/NSFontManager.m: Improved documentation
	* Source/NSFontPanel.m: Improved documentation
	* Source/NSMatrix.m: Improved documentation
	* Source/NSPanel.m: Improved documentation

2005-12-04  Fabien VALLON  <fabien@sonappart.net>

	* Source/NSColorPanel.m: Improved documentation, various cleanups
	* Source/NSColor.m: Improved documentation
	* Source/NSClipView.m: Improved documentation
	* Source/NSColorWell.m: Improved documentation
	* Source/NSControl.m: Improved documentation

2005-12-04  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/GSServicesManager.m: Implement use of NSUseRunningCopy

2005-11-29  Fabien VALLON  <fabien@sonappart.net>

	* Source/NSCachedImageRep.m : Improved documentation
	* Source/NSCell.m : Improved documentation

2005-11-29  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSTabView.m (-minimumSize): Filled in some code.
	* Source/NSTextField.m (-validateEditing, -textDidChange:): Check
	is delegate responds to selector before calling it.
	Patch by Andreas Höschler <ahoesch@smartsoft.de>

2005-11-25  fabien  <fabien@sonappart.net>

	* Source/NSBox.m: Improved documentation
	* Source/NSCell.m: Documentation : closed the ref tag for -setType:
	* Source/NSBrowser.m: Improved documentation, various cleanups.
	* Source/NSBrowserCell.m: Improved documentation.
	* Source/NSButton.m: Improved documentation.
	* Source/NSButtonCell.m: Improved documentation.
	
2005-11-24 12:33 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/NSCell.m: Added documentation for setType:.

2005-11-24  fabien  <fabien@sonappart.net>

	* Source/NSMatrix.m: Improved documentation, various cleanups
	* Source/NSOpenPanel.m: Improved documentation
	* Source/NSPageLayout.m: Improved documentation
	* Source/NSPopUpButton.m: Improved documentation
	* Source/NSSavePanel.m: Improved documentation
	* Source/NSScrollView.m: Improved documentation
	* Source/NSTexField.m: Improved documentation	
	* Source/NSFont.m: Improved documentation, various cleanups
	* Source/NSImage.m: Improved documentation, various cleanups
	* Source/NSScroller.m: Improved documentation, various cleanups

2005-11-22  Richard Frith-Macdonald <rfm@gnu.org>

	* Headers/Additions/GNUstepGUI/GSDrawFunctions.h:
	* Source/GSDrawFunctions.h:
	Make drawing methods go via theme engine.

2005-11-22  fabien  <fabien@sonappart.net>

	* Source/NSCell.m : Improved documentation
	* Source/NSControl.m : Improved documentation
	* Source/NSCustomImageRep.m : Improved documentation
	* Source/NSFontPanel.m : Improved documentation
	* Source/NSForm.m : Improved documentation
	* Source/NSFormCell.m : Improved documentation
	* Source/NSImage.m : Improved documentation
	* Source/NSMatrix.m : Improved documentation

2005-11-21  fabien  <fabien@sonappart.net>

	* Source/NSButton.m : Improved documentation
	* Source/NSButtonCell.m : Improved documentation
	* Source/NSCachedImageRep.m : Improved documentation
	* Source/NSCell.m : Improved documentation
	* Source/NSClipView.m : Improved documentation
	* Source/NSColor.m : Improved documentation
	* Source/NSColorPanel.m : Improved documentation
	* Source/NSColorWell.m : Improved documentation

2005-11-21  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSSliderCell.m (-drawInteriorWithFrame:inView:): Allow
	the knob image to resize. Patch by Georg Fleischmann <georg@vhf.de>
	* Source/NSTextField: (textView:doCommandBySelector:) new method
	to pass on the request to the delegate, if possible.

2005-11-21  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSPasteboard.m: Turn off warning message about launching
	gpbs ... now that we use host-local connections and expect the
	pastebaord server to be private to the user, there is no real reason
	why it shouldn't be routinely launched on demand.

2005-11-20  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/GSServicesManager.m: GSContactApplication()
	Fix bug launching application ... if it's not available in the
	services bundle, locate application by name (from the port).

2005-11-18  fabien  <fabien@sonappart.net>

	* Source/NSSliderCell.m: Improved documentation
	* Source/NSTextField.m: Improved documentation
	* Source/NSTextFieldCell.m: Improved documentation
	* Source/NSSavePanel.m: Improved documentation
	* Source/NSOpenPanel.m: Improved documentation
	* Source/NSApplication.m: Improved documentation
	* Source/NSBitmapImageRep.m: Improved documentation
	* Source/NSBox.m: Improved documentation
	* Source/NSBrowserCell.m: Improved documentation
	

2005-11-17  fabien  <fabien@sonappart.net>

	* Source/NSControl.m : Improved documentation 
	* Source/NSCustomImageRep.m : Improved documentation 
	* Source/NSFontPanel.m : Improved documentation
	* Source/NSForm.m : Improved documentation
	* Source/NSFormCell.m : Improved documentation
	* Source/NSSlider.m : Improved documentation

2005-11-16  fabien  <fabien@sonappart.net>

	* Source/NSColorPanel.m : Improved documentation
	* Source/NSColorWell.m : Improved documentation

2005-11-16  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/GSEPSPrintOperation.m:
	* Source/GSHelpManagerPanel.m:
	* Source/GSHorizontalTypesetter.m:
	* Source/GSLayoutManager.m:
	* Source/GSNibCompatibility.m:
	* Source/GSNibTemplates.m:
	* Source/GSPDFPrintOperation.m:
	* Source/GSPrintOperation.m:
	* Source/GSPrinting.m:
	* Source/GSSlideView.m:
	* Source/GSTable.m:
	* Source/GSToolbar.m:
	* Source/NSAlert.m:
	* Source/NSApplication.m:
	* Source/NSBezierPath.m:
	* Source/NSBitmapImageRep+PNM.m:
	* Source/NSBox.m:
	* Source/NSBrowser.m:
	* Source/NSBrowserCell.m:
	* Source/NSBundleAdditions.m:
	* Source/NSCell.m:
	* Source/NSColor.m:
	* Source/NSColorList.m:
	* Source/NSColorWell.m:
	* Source/NSCustomImageRep.m:
	* Source/NSDataLink.m:
	* Source/NSDataLinkManager.m:
	* Source/NSDataLinkPanel.m:
	* Source/NSDocument.m:
	* Source/NSForm.m:
	* Source/NSGraphicsContext.m:
	* Source/NSHelpManager.m:
	* Source/NSImage.m:
	* Source/NSLayoutManager.m:
	* Source/NSMatrix.m:
	* Source/NSNib.m:
	* Source/NSOpenGLPixelFormat.m:
	* Source/NSOpenGLView.m:
	* Source/NSOutlineView.m:
	* Source/NSPageLayout.m:
	* Source/NSPrintInfo.m:
	* Source/NSPrintOperation.m:
	* Source/NSPrintPanel.m:
	* Source/NSPrinter.m:
	* Source/NSResponder.m:
	* Source/NSRulerView.m:
	* Source/NSSelection.m:
	* Source/NSSpellChecker.m:
	* Source/NSSpellServer.m:
	* Source/NSSplitView.m:
	* Source/NSStepper.m:
	* Source/NSTabView.m:
	* Source/NSTableView.m:
	* Source/NSTextView.m:
	* Source/NSTextView_actions.m:
	* Source/NSToolbarItem.m:
	* Source/NSView.m:
	* Source/NSWindow.m:
	* Source/NSWorkspace.m:
	Fix some common coding style violations ... should have no effect
	other than improving readability.

2005-11-15  fabien  <fabien@sonappart.net>

	* Source/NSColor.m : Improved documentation, various cleanups.

2005-11-09  fabien  <fabien@sonappart.net>

	* Source/NSCell.m : Improved documentation

2005-11-08  fabien  <fabien@sonappart.net>

	* Source/NSBox.m : Improved documentation
	* Source/NSBrowser.m :  Ditto
	* Source/NSBrowserCell.m : Ditto
	* Source/NSButton.m : Ditto

2005-11-06  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSImage.m (-bestRepresentationForDevice:): Get the device
	description from the current context, not via NSScreen, as we
	cannot be sure about the screen order.
	* Source/NSApplication.m (-_init): Make sure the default context
	has properly set attributes.

2005-11-03  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSBrowser.m (-setPath:): Corrected memory management bug 14901.

2005-11-02  Nicolas Roard  <nicolas.roard@gmail.com>

	* Headers/Additions/GNUstepGUI/GSDrawFunctions.h,
	* Source/GSDrawFunctions.m (+[theme],+[setTheme:]): New accessor 
	methods.
	
2005-10-30  Adam Fedor  <fedor@gnu.org>

	* Documentation/General/OpenStepCompliance.gsdoc: Updates.

2005-10-25  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSColorList.m: ([writeTofile:]) return NO if there is no
	known directory to write to.

2005-10-23  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSWindow.m: ([setExcludedFromWindowsMenu:]) when a window
	is excluded, remove it from the windows menu.  Fixes bug #14008

2005-10-22  Richard Frith-Macdonald <rfm@gnu.org>

	* Tools/make_services.m: Update to use
	NSSearchPathForDirectoriesInDomains() more extensively so that we
	get all the directories we should using the new configuration
	information, rather than the default set.

2005-10-20  Fred Kiefer <FredKiefer@gmx.de>

	* Source/GSTitleView.m: Corrected last change the signature of
	[rightMouseDown:] had been changed instead of [menuForEvent:].

2005-10-20  Fred Kiefer <FredKiefer@gmx.de>

	* Header/NSInputManager.h
	* Source/GSTitleView.m
	* Source/NSColor.m
	* Source/NSImageCell.m
	* Source/NSResponder.m
	* Source/NSSavePanel.m
	* Source/NSTabView.m
	* Source/NSTableHeaderView.m
	* Source/NSMenuView.m
	Removed compiler warnings from gcc 4.0.2.
	
2005-10-18  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSApplication.m (-terminate:): Call NSDocumentControllers
	review unsaved code only when this is a document based application.

2005-10-17  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSSavePanel.m (-performDragOperation:): Set file name and
	directory to allow dragging of files, not just directories.

2005-10-14  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSRulerView.m (-drawHashMarksAndLabelsInRect:): For
	vertical rulers use ruler thickness to position labels. Patch by Saso
	Kiselkov <diablos@manga.sk>.

2005-10-09  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/GSServicesManager.m: Improve handling of port registration
	to ensure each application listens on a well known port and the port
	name is readable.  If multiple copies of an app are running, name
	the extra copies AppCopy1 AppCoppy2 etc.
	* Source/NSWorkspace.m: Use advertised port name for the app name so
	that other apps can contact it.
	Implement ([-extendPowerOffBy:]) to ask workspace application.
	* Tools/gclose.m: Triavial utility ... counterpart for gopen ...
	close doen an application.Saso
	Kiselkov <diablos@manga.sk>
	* Tools/GNUmakefile: build gclose

2005-10-08  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSWorkspace.m: Provide private method to post a notification
	to the local workspace center, using the shared workspace app as the
	notification object.  Fix handling of incoming notifications so that
	they use the new method and are therefore posted locally with the
	correct notification object.
	* Source/GSServicesManager.m: Make applications respond to the
	terminate: method sent from another app, but send a power off
	notification first, on the assumption that a terminate sent by
	a remote process is a power off or session manager shutdown or
	some similar event indicating that the process is likely to be
	forcably killed if it doesn't close down gracefully.

2005-10-05  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSCell.m (-setObjectValue:, -setStringValue:): When no
	formatter is present, the object value is always valid. Also allow
	attributed strings to be passed through. Based on patches by Saso
	Kiselkov <diablos@manga.sk> and Andreas Hoeschler <ahoesch@smartsoft.de>.

2005-09-19  Adam Fedor  <fedor@gnu.org>

	* Version 0.10.1

2005-09-10 17:02 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/externs.m: Added constants for data link.
	* Source/NSDataLink.m: Removed NSDataLinkFilenameExtension constant.
	* Source/NSDataLinkManager.m: Added implementation for 
	addLinkAsMarker:at:, addLinkPreviouslyAt:fromPasteboard:at:.

2005-09-10  Adam Fedor  <fedor@gnu.org>

	* configure.ac: Check for libgib if libungif is not found.
	Fixes Bug #14454.

2005-08-25  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSView.m: ([_viewDidMoveToWindow]) Implemented and used to
	send notification to subviews as we should.

2005-08-22 14:36 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/NSInterfaceStyle.m: -[GSInterfaceStyle
	defaultsDidChange:] correction for val variable.  Previously
	this was the enumerated type NSInterfaceStyle.  This caused
	some alighnment issues on 64bit platforms.  I have also tested
	this change on i386/Linux.

2005-08-17  Adam Fedor  <fedor@gnu.org>

	* configure.ac: Check for v19 of portaudio.

2005-08-17  Enrico Sersale  <enrico@dtedu.net>

	* Tools/gsnd/gsnd.m: updated to use libportaudio v19.

	* Tools/gsnd/gsnd.m: in main(): uses NSTask to create a daemon.
	
2005-08-17  Serg Stoyan  <stoyan255@ukr.net>

	* Source/NSBrowser.m: (tile): Fix calculating columns width for
	unseparated columns.
	
	* Source/NSSplitView.m: (mouseDown:): Don't try to resize subviews
	if divider positon wasn't changed.
	
	* Source/NSPopUpButtonCell.m: (trackMouse:inRect:ofView:untilMouseUp:):
	Dismiss the popup after mouse tracking done. This is for the cases when 
	mouse up event occurs outside of popup.
	
2005-07-27  Adam Fedor  <fedor@gnu.org>

	* Source/GNUmakefile.postamble (Info-gnustep.plist): Depend on 
	../Version.

	* Source/NSOutlineView.m ([NSOutlineView -rowForItem:]): Declare var
	at beginning of block for gcc2 (Fixes Bug #13936).

2005-07-25 22:28 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/NSOutlineView.m: Make [NSOutlineView rowForItem:] return
	-1 as per specs, instead of NSNotFound.

2005-07-22  Adam Fedor  <fedor@gnu.org>

	* Version 0.10.0

2005-07-21 08:33 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/GSNibTemplates.m: in GSWindowTemplate initWithCoder:, 
	temporarily retain, then release (after setting back into the window)
	the content view to prevent it from being inadvertantly deallocated.

2005-07-17  Adam Fedor  <fedor@gnu.org>

	* Source/NSApplication.m (gnustep_backend_path,
	gnustep_backend_framework, gnustep_backend_bundle): New functions.
	(initialize_gnustep_backend): Support versioning of backend bundle.

2005-07-17  Adam Fedor  <fedor@gnu.org>

	* Documentation/Gui.gsdoc, Documentation/GuiAdditions.gsdoc
	Documentation/ReleaseNotes.gsdoc, Documentation/readme.texi
	Documentation/GuiUser/DefaultsSummary.gsdoc
	Documentation/GuiUser/KeyboardSetup.gsdoc
	Documentation/GuiUser/LanguageSetup.gsdoc, Source/NSView.m:
	Fix some documentation errors.

2005-07-12  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSApplication.m: (_NSAppKitUncaughtExceptionHandler)
	As there was no other feedback to the recent email thread on this,
	I've removed the option to try to 'ignore' the exception ... since
	it would most likely result in a random crash (possibly with loss
	of data etc) at a later point.

2005-07-09 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Source/NSSavePanel.m (-ok:): Set _fullFileName before invoking
	delegate -panel:userEnteredFilename:confirmed: so it is given the
	current filename to process.

2005-07-09  Fred Kiefer <FredKiefer@gmx.de>

	* Headers/AppKit/NSGraphicsContext.h,
	* Source/NSGraphicsContext.m: Added new methods
	[-GScomposite:toPoint:fromRect:operation:fraction:] and
	[-GSSetPatterColor:].  
	* Source/NSImage.m (-compositeToPoint:...fraction:): Implemented.
	* Source/NSColor.m (GSPatternColor -set): Implemented.

2005-07-04  Adam Fedor  <fedor@gnu.org>

	* Documentation/ReleaseNotes.gsdoc: Update.

2005-07-01  Adam Fedor  <fedor@gnu.org>

	* Documentation/Gui.gsdoc, 
	Documentation/GuiAdditions.gsdoc, 
	Documentation/ReleaseNotes.gsdoc, 
	Documentation/gopen.1, Documentation/make_services.1, 
	Documentation/General/OpenStepCompliance.gsdoc, 
	Documentation/GuiUser/DefaultsSummary.gsdoc, 
	Documentation/GuiUser/KeyboardSetup.gsdoc, 
	Documentation/GuiUser/LanguageSetup.gsdoc, 
	Model/Controller.h, Model/Controller.m, Model/test.m, 
	PrinterTypes/GSProlog.ps,
	Printing/GSCUPS/GNUmakefile.postamble, 
	Printing/GSCUPS/GNUmakefile.preamble, 
	Printing/GSLPR/GNUmakefile.postamble, 
	Printing/GSLPR/GNUmakefile.preamble, 
	Tools/GNUmakefile.postamble, 
	Tools/GNUmakefile.preamble, Tools/wgetopt.h, 
	Tools/gsnd/GNUmakefile.postamble, 
	Tools/gsnd/GNUmakefile.preamble: Add/fix copyright/licenses.

2005-07-01  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSApplication.m: (_NSAppKitUncaughtExceptionHandler)
	Call [NSApp run] to re-enter runloop if we are told to ignore
	the exception.  Not sure this is right though ... probably
	the option to ign ore should be removed.

2005-06-28  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSScrollView.m: ([-initWithFrame:) create a hidden horizontal
	ruler for MacOS-X and OPENSTEP compatibility.  Fix bug #13310
	* Source/NSRulerView.m: ([-dealloc]) Don't release _clientView as we
	don't own it.  Fixes bug #13382

2005-06-22  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSMenu.m (-setGeometry): Use [NSWindow
	setFrameFromString:] when possible to position the menu windows
	relative to the screen size.
	(-isPartlyOffScreen_OFFSCREEN, -setGeometry, -shiftOnScreen) Use
	current screen and visibleFrame of screen instead of frame. 

2005-06-18  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSColor.m (+colorFromString:): Make sure the scanner is
	always released. Fixes bug reported by Benhur Stein
	<benhur.stein@gmail.com>.

2005-06-17  Adam Fedor  <fedor@gnu.org>

	* Source/NSPopUpButtonCell.m (-setObjectValue:): Use
	respondsToSelector.

2005-06-16  Fabien Vallon  <fabien@sonappart.net>

	* Source/NSProgressIndicator.m: setAnimationDelay: fix typo
	* Headers/AppKit/NSProgressIndicator: ditto

2005-06-06  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSWorkspace.m: ([-mountedLocalVovumePaths]) implemented
	for mingw as a listing of all device names.
	Implement for unix using getmntent.
	* configure.ac: add checks for getmntent variations.
	Tested on debian, may need tweaks for others.

2005-06-06 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Headers/AppKit/NSApplication.h
	* Headers/AppKit/NSEvent.h
	* Source/GSServicesManager.m
	* Source/NSApplication.m
	* Source/NSFont.m: Filled in various GSdoc.

2005-06-04 08:11 Gregory John Casamento <greg_casamento@yahoo.com>

	* Headers/Additions/GNUstepGUI/GSNibTemplates.h: Minor update to
	constant name.
	* Source/GSNibTemplates.m: Use new constant name, and move call
	to autoPositionWindow: outside of class name check.

2005-06-04 07:36 Gregory John Casamento <greg_casamento@yahoo.com>

	* Headers/Additions/GNUstepGUI/GSNibTemplates.h: Constants for new
	autoposition scheme, declaration for setAutoPositionMask:,
	autoPositionMask and autoPositionWindow: methods.
	* Source/GSNibTemplates.m: Code in [GSWindowTemplate initWithCoder:]
	to handle new version.  Also new method autoPositionWindow: to 
	handle window placement.

2005-05-30  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSPopupButtonCell.m (-dealloc) Corrected previous fix to only
	dismiss the popup, when it is actualy visible. This caused a
	problem with the window deallocation mechanism, when the window
	containing the popup button was closed.

2005-05-30  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSTableView.m (-mouseDown): No longer copy the cell, as
	this was causing trouble in GNUmail and Gworkspace.
	* Source/NSComboBox.m (-trackMouse:inRect:ofView:untilMouseUp:): 
	Only mark the cellframe as needing redraw.
	Patch by Matt Rice <ratmice@yahoo.com>.

2005-05-27  Adam Fedor  <fedor@gnu.org>

	* Source/NSAffineTransform.m (matrix_multiply): New function.
	(appendTransform:, prependTransform:, rotateByRadians:, 
	scaleBy:, scaleXBy:yBy:, translateXBy:yBy:, 
	concatenateWithMatrix:): Use it.
	(rotateByDegrees:) Use rotateByRadians:.  Fixes bug #13181.

2005-05-27  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSPopupButtonCell.m (-dealloc) Dismiss the popup. This is to
	make sure the removed popup no longer gets notifications. may
	happen when the cell gets deallocated without closing the popup.

2005-05-26  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSTableView.m (-mouseDown): Replaced use of
	_sendsActionOn: with a check if the value did change
	after the cell did track the mouse. Also use a copy of the cell,
	that way other cells are not affected by changes in the tracked
	cell. Patch based on code by Matt Rice <ratmice@yahoo.com>.

2005-05-25  Adam Fedor  <fedor@gnu.org>

	* Update FSF Address.

2005-05-23  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSAlert.m (-_setupPanel): New method. 
	(-runModal, -beginSheetModalForWindow:...contextInfo:) Use this
	new method.

2005-05-22  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSView.m (-display) 
	* Source/NSCell.m (-drawWithFrame:inView:) 
	* Source/NSBrowserCell.m (-drawWithFrame:inView:) 
	* Source/NSImageCell.m (-drawWithFrame:inView:) 
	* Source/NSMenuItemCell.m (-drawWithFrame:inView:) 
	* Source/NSTableHeaderCell.m (-drawWithFrame:inView:):
	Removed check for window existence. This should already have been
	checked by a surrounding canDraw call. Fixes bug #13140.

2005-05-22  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSComboBox.m (-cellSize) Added simple implementation of
	this method to get sizeToFit working.
	(GSComboWindow -layoutWithComboBoxCell:) Don't subtract the width
	of the scroller from the popup item size, increase the popup width instead.

2005-05-20  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSWindow.m (-center, -constrainFrameRect:toScreen:) Use
	screen visibleFrame instead of frame.
	* Source/NSWindow.m (-animationResizeTime:,
	-setFrame:display:animate:) Implemented this methods.

2005-05-20  Fred Kiefer <FredKiefer@gmx.de>

	* Headers/AppKit/NSResponder.h: Added new MacOSX methods.
	* Source/NSResponder.m (-encodeWithCoder:, initWithCoder:) Handle
	NSNextResponder for keyed encoding.
	* Source/NSResponder.m
	* Source/NSApplication.m
	* Source/NSWindow.m
	* Source/NSView.m
	* Source/NSControl.m:
	Implemented shouldBeTreatedAsInkEvent:.
	
2005-05-19  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSImageCell.m (-setObjectValue:) Nil parameter now unsets
	image. This resolves bug #13046.

2005-05-02 23:45 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/GSNibTemplates.m: added condition to all of the templates
	so that the designated init is not called when the className and
	the superClass are equivalent.
	
2005-05-01 17:09 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Source/GSNibTemplates.m: [GSWindowTemplate initWithCoder:]
	changed so designated initializer is called with content frame.
	
2005-04-30 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Headers/AppKit/NSFont.h: Add 'cachedFlippedFont' ivar.
	* Source/NSFont.m: Cache font for drawing in flipped views in
	manner analogous to font for screen drawing.

2005-04-28  Adam Fedor  <fedor@gnu.org>

	* configure.ac: More complete check for portaudio
	* Tools/gsnd/gsnd.m: Fix portaudio include

2005-04-27 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Headers/AppKit/NSApplication.h: Add app_is_launched ivar.
	* Source/NSApplication.m (-run): Only go through launch process
	and call -finishLaunching on first call.
	(-replyToApplicationShouldTerminate:) Unhide mouse on app exit.

2005-04-25  Adam Fedor  <fedor@gnu.org>

	* configure.ac: Check for lib portaudio
	* Tools/gsnd/GNUmakefile: Use lib portaudo.
	* Tools/gsnd/portaudio: Remove portaudio files.
	* Documentation/install.texi: Updates.

2005-04-25 00:02 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/GSNibTemplates.m: [GSClassSwapper initWithObject:
	className:superClassName:] removed assertion which prevents
	using the same class name for both arguments.  Also cleaned
	up some commented out code.

2005-04-17  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSPopupButton.m (-keyDown:) Removed unneeded code.
	(-_handleNotification:): Moved method from here ...
	* Source/NSPopupButtonCell.m: ... to here.
	(-dismissPopUp, -attachPopUpWithFrame:inView:): Dis-/Connect self,
	not the control view, with notification centre. Fixes bug #12680.
	(-synchronizeTitleAndSelectedItem): Update the control view.
	(-trackMouse:inRect:ofView:untilMouseUp:): Removed unneeded code.
	(-attachPopUpWithFrame:inView:): Set the selected item to highlighted.
	
2005-04-17  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSColor.m: Implemented the missing keyed encoding methods.

2005-04-11 10:24 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/GSNibTemplates.m: Correction for minor leak in 
	GSClassSwapper dealloc method.

2005-04-09  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSColor.m: Implemented most keyed encoding methods.
	* Source/NSFont.m: Implemented simple keyed encoding.

2005-04-08  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSView.m (-addSubview:positioned:relativeTo:): Don't
	increase index for subview added at the end. Based on patch by
	Matthias Hengartner <hengartner@ivt.baug.ethz.ch>.

2005-04-03 14:53 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/NSCustomImageRep.m: Allow drawing if the delegate is
	set since the size may not have been set as of yet.  This behavior
	is consistent with that observed on OPENSTEP4.2/Mach.  This fix
	corrects bug #12412.

2005-04-03  Richard Frith-Macdonald <rfm@gnu.org>

	* Headers/AppKit/NSTextView.h: Keep track of whether we are acting
	as a target for a DnD operation, and what the selected range was
	before the operation began.
	* Source/NSTextView.m: Display insertion point during DnD operation
	Fixes bug #9788

2005-04-02  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSTableView.m: ([-mouseDown:]) tweak vertical image
	offset because view is flipped.  Still not sure this code is
	correct  ... which coordinate system is the image offset supplied
	by ([-dragImageForRows:event:dragImageOffset:]) supposed to be in?

2005-04-01  Adam Fedor  <fedor@gnu.org>

	* Headers/AppKit/NSDataLinkManager.h, Source/NSDataLinkManager.m:
	Re-add the changes from 2005-03-05.

2005-04-01  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/GSDragView.m: when dragging, use the mouse offset to adjust
	the initial position of the dragged image.
	Modified internally to pass the original position of the image so
	that slideback can slide to that position rather than the position
	the mouse started from.  This makes no difference if the initial
	mouse offset was zero, but does have an effect if the drag was
	initiated by a mouse move at a location offset from the original
	mouse down.
	Exposed a couple of methods for subclasses.
	* Source/NSColorPanel.m: Set image position for DnD so that color
	swatch is centered on the mouse position.
	* Source/NSImageView.m: ditto
	* Source/NSTableView.m: ([-mouseDown:]) after calling the
	([-dragImageForRows:event:dragImageOffset:]) method, use the
	returned offset to position the center of the image relative
	to the mouse pointer .. I *think* that's what the apple documentation
	of the method means.

2005-03-30  Adam Fedor  <fedor@gnu.org>

	* Version 0.9.5

	* Headers/AppKit/NSDataLinkManager.h, Source/NSDataLinkManager.m: 
	Partially revert 2005-03-05 patch for this release.

2005-03-29 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Source/NSWorkspace.m (-_extIconForApp:info:): Check filename is
	not empty string before passing to [NSBunder -pathForImageResource:].

2005-03-29 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Source/NSGraphicsContext.m: Undeprecate DPSxshow, DPSyshow,
	DPSxyshow, DPSashow, DPSwidthshow, and DPSawidthshow.

2005-03-29  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/GSDragView.m:
	* Headers/Additions/GNUstepGUI/GSDragView.h: Minor tweaks to ease
	subclassing.

2005-03-28  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/GSDragView.m: Fix a few bugs exposed by windows port and
	tidy/add comments to clarify operation.  When initiating DnD session,
	take offset argument into account rather than ignoring it.
	* Headers/Additions/GNUstepGUI/GSDragView.h: Improve comments and
	change offset to be NSSize rather thgan NSPoint.

2005-03-21  Adam Fedor  <fedor@gnu.org>

	* Tools/gsnd/portaudio/pa_unix_oss/pa_unix_oss.c: Fix for FreeBSD
	FTBFS (Fixes Bug #12316). Strip DOS CRs.

2005-03-21  Adam Fedor  <fedor@gnu.org>

	* configure.ac: Check for libgif
	* Source/NSBitmapImageRep+GIF.m: Support libgif
	* Source/NSBitmapImageRem.m: Idem. (Fixes Bug #12362).

2005-03-19  Adam Fedor  <fedor@gnu.org>

	* Headers/AppKit/DPSOperators.h, Headers/AppKit/NSGraphics.h:
	Modify selectors to play nice with C++ compiler.	
	* Headers/AppKit/NSAffineTransform.h, Headers/AppKit/NSFontManager.h,
	Headers/AppKit/NSPageLayout.h: Modify arg name for same purpose.
	* Source/NSAffineTransform.m, Source/NSFontManager.m,
	Source/NSPageLayout.m: Modify to match header. (Patch from 
	Francis Franklin, with some modifications).

2005-03-14  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSMatrix.m:
	([_renewRows:columns:rowSpace:colSpace:]) Corrected last patch so
	that the open panel works again. Initialize all new cells, not
	just the requested ones.

2005-03-14  Richard Frith-Macdonald <rfm@gnu.org>

	* Source/NSMatrix.m:
	([removeRow:]) set column counts to zero if all rows are removed
	([removeColumn:]) set row counts to zero if all columns are removed
	([_renewRows:columns:rowSpace:colSpace:]) initialise all columns of
	any newly created rows (up to _maxCols) rather than just the number
	specified by the method argument.  Otherwise we get uninitialised
	columns in the matrix which will cause a crash when they are used.
	Fixes bug #12299

2005-03-13  Richard Frith-Macdonald <rfm@gnu.org>

	* Headers/AppKit/NSGraphics.h: Fix prototype for stricter compiler.
	* Source/Functions.m: ditto
	Deal with bug #12296

2005-03-10  Nicola Pero <n.pero@mi.flashnet.it>

	* Headers/AppKit/AppKitDefines.h (GS_EXPORT): Use extern, not
	__declspec(dllexport), on mingw
	
2005-03-10  Nicola Pero <n.pero@mi.flashnet.it>

	* configure.ac: Fixed setting variable when libjpeg can't be found.
	* configure: Regenereated.

2005-03-07  Fred Kiefer <FredKiefer@gmx.de>

	* Header/AppKit/NSCell.h: Moved NSControlSize definition to ...
	* Header/AppKit/NSColor.h: ... here and added
	NSMiniControlSize. For NSControlTint added NSBlueControlTint and
	NSGraphiteControlTint.
	* Header/AppKit/NSFont.h (+menuBarFontOfSize:,
	+systemFontSizeForControlSize:, -numberOfGlyphs,
	-coveredCharacterSet, -fontDescriptor): New MacOSX 10.3 methods.
	* Source/NSFont.m: Added dummy implementations for the new methods. 

2005-03-05 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Source/NSApplication.m (-_windowDidResignKey:) Unhide mouse.

2005-03-05 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Source/NSScroller.m (-checkSpaceForParts, -rectForPart:) Calculate
	buttonsWidth variable dynamically based on +scrollerWidth (supports
	width override by subclass).

2005-03-05 10:53 Gregory John Casamento <greg_casamento@yahoo.com>

	* Headers/AppKit/NSDataLink.h
	* Headers/AppKit/NSDataLinkManager.h: Added some ivars
	* Source/Functions.m: Changed the NSLinkFrameThickness() function to
	return 1 instead of 1.5.
	* Source/NSDataLink.m: Implemented several methods.
	* Source/NSDataLinkManager.m: Implemented several methods.
	* Source/NSDataLinkPanel.m: Change version from 1 to 0.
	* Source/NSSelection.m: Change version from 1 to 0, corrected 
	but in initWithCoder:.

2005-03-03  Adam Fedor  <fedor@gnu.org>

	* configure.ac: Disable gsnd on darwin
	
	* Tools/GNUmakefile.preamble (GSspell_TOOL_LIBS): Add lib depends.

2005-02-27 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Source/NSApplication.m (-runModalForWindow:) Clarify gsdoc
	explaining why we don't follow Apple docs here.  (Corrects gsdoc
	from change on 2005-01-26, which itself documented a code change on
	2005-01-18.)

2005-02-26 18:04  Alexander Malmberg  <alexander@malmberg.org>

	* Headers/Additions/GNUstepGUI/GSServicesManager.h: Include the
	NSMenuItem.h header instead of forward declaring the NSMenuItem
	protocol.

2005-02-23  Fred Kiefer <FredKiefer@gmx.de>

	* Header/AppKit/NSColor.h (-alternateSelectedControlColor,
	-alternateSelectedControlTextColor,
	-secondarySelectedControlColor,
	controlAlternatingRowBackgroundColors): New MacOSX system colour methods.
	* Source/NSColor.m (-alternateSelectedControlColor,
	-alternateSelectedControlTextColor,
	-secondarySelectedControlColor,
	controlAlternatingRowBackgroundColors): Implemented the new
	methods.
	(initSystemColors): Added default values for new system coloure methods

2005-02-21  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSCell.m (-initWithCoder):
	* Source/NSButtonCell.m (-initWithCoder):
	* Source/NSBrowser.m (-initWithCoder):
	Small improvements on keyed decoding of flags.

2005-02-19  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSSavePanel.m (-_setDefaultDirectory): New method to get
	default directory from user defaults (NSDefaultOpenDirectory).
	(-_resetDefaults): Use it for setting of default directory.
	(-_setupForDirectory:file:): Use the new method here as well if no
	path is provided. Cleaned up this method.
	(-cancel:) Don't clean up filename and set directory to current.
	(-ok:) Don't set _OKButtonPressed.
	* Source/NSOpenPanel.m (-ok:): Don't set _OKButtonPressed.
	(-_setupForDirectory:file:): Removed code duplicating super class
	implementation. 
	This fixes most of bug #7900.

2005-02-14  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSPopupButton.m (-mouseDown:): Moved code from here ...
	* Source/NSPopupButtonCell.m
	(-trackMouse:inRect:ofView:untilMouseUp:): ... to here. This fixes
	bug #9824.

2005-02-14  Richard Frith-Macdoanld <rfm@gnu.org>

	* Source/GSTitleView.m (-mouseDown:): Post an
	NSWindowDidMoveNotification at end of method if window was dragged.
	Fixes bug #11906

2005-02-12  Fred Kiefer <FredKiefer@gmx.de>

	* Headers/Additions/GNUstepGUI/GSDisplayServer.h (-setalpha::): Declare.
	* Source/GSDisplayServer.m (-setalpha::): New method for window
	alpha setting, with empty default implementation.
	* Source/NSWindow.m (-setAlphaValue:): Implemented alpha setting
	via display server.
	(-_initDefaults): Set _alphaValue to 1.0.

2005-02-12  Fred Kiefer <FredKiefer@gmx.de>

	* Model/GMAppKit.m (NSButtonCell-initWithModelUnarchiver:):
	Resorted code to work around AppKit change on button type
	handling. Patch by Georg Fleischmann <georg@vhf.de>	

2005-02-12  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSAffineTransform.m (-boundingRectFor:result:): Further
	corrections on last change.

2005-02-11  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSAffineTransform.m (-boundingRectFor:result:):
	Corrected algorithm to compute bounding box for transformed
	rectangle (Code based on Cairo). This fixes bug #11562.

2005-02-08  Matt Rice  <ratmice@yahoo.com>

	* Source/NSApplication.m (-changeWindowsItem:title:filename:): If the
	window can become key, use makeKeyAndOrderFront: as the action.
	(-updateWindowsItem:, -setWindowsMenu): Compare the title to what it
	would be if there was a represented filename, not the filename.
	* Source/NSApplication.m (-orderWindow:relativeTo:): Ditto.
	(-setExcludedFromWindowsMenu): Ditto.

2005-02-08  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSSecureTextField.m (-drawInteriorWithFrame:inView:):
	Draw the background colour of the cell.
	
2005-02-07  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSTableView.m (-expandItem:expandChildren:,
	collapseItem:collapseChildren:): Added a call to setNeedsDisplay:,
	so the new status will be shown correctly.
	(_openItem:): Removed setNeedsDisplay: call as all callers do it already.

2005-02-05 15:42 Gregory John Casamento <greg_casamento@yahoo.com>

	* Headers/AppKit/NSDataLinkManager.h: Moved NSDataLinkManager delegate
	methods to an informal protocol NSDataLinkManagerDelegate.
	* Source/Functions.m: Implemented NSFrameLinkRect() to draw the frames
	around source and destination links.
	* Source/NSBundleAdditions.m: Modified -description method in 
	NSNibConnector to display the source, destination and label for the
	connection.  This makes it easier to debug.
	* Source/NSDataLink.m: Implemented a few private methods.
	* Source/NSDataLinkManager.m: Implemented -breakAllLinks.

2005-02-03 10:54  Alexander Malmberg  <alexander@malmberg.org>

	* Source/NSImage.m (min, max): Rename to ...
	(gs_min, gs_max): ... this. Update callers.

2005-01-28 21:58 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/NSColorWell.m: [NSColorWell mouseDown:] prevent use
	of the colorwell when it's disabled.

2005-01-28 17:57  Alexander Malmberg  <alexander@malmberg.org>

	* Source/NSImageCell.m (-drawInteriorWithFrame:inView:): If our
	view is flipped, flip the image.

2005-01-26 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Source/NSApplication.m (-beginModalSessionforWindow:): Center
	panels only if they are not already up, matching OS X Panther;
	document.
	(-runModalForWindow:, -runModalSession:): Clarify documentation.

2005-01-25 01:05  Alexander Malmberg  <alexander@malmberg.org>

	* Source/NSImageCell.m (-drawInteriorWithFrame:inView:): Use
	-drawInRect:fromRect:operation:fraction: to draw the image.

2005-01-25 00:29  Alexander Malmberg  <alexander@malmberg.org>

	* Headers/AppKit/NSImage.h (-drawAtPoint:fromRect:fraction:)
	(-drawInRect:fromRect:operation:fraction:): Document.
	* Source/NSImage.m -drawAtPoint:fromRect:fraction:)
	(-drawInRect:fromRect:operation:fraction:): Implement.
	(min, max): New functions.
	(-drawRepresentation:inRect:): Save the gstate before drawing
	and restore it afterwards.

	Fixes bug #11712.

2005-01-24 16:57  Alexander Malmberg  <alexander@malmberg.org>

	* Source/NSPopUpButtonCell.m (-synchronizeTitleAndSelectedItem): For
	non-pulldowns, make sure the selected item and the highlighted item
	are the same.

2005-01-24  Quentin Mathe  <qmathe@club-internet.fr>

	* Source/GSToolbarView.m (initSystemExtensionsColors()): Removed 
	spurious 'else' (introduced with revision 1.11) which prevented toolbar 
	colors loading code to be executed (Fix the white toolbar background bug
	reported by Riccardo Mottola).

2005-01-24 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Source/NSSavePanel.m (-_shouldShowExtension:isDir:,
	-setRequiredFileType:, -requiredFileType, -filename): For filename
	display filtering, handle case where _requiredFileType is unset or
	set to nil or "" by allowing any extension (including none), as
	specified in Apple docs, instead of allowing no extensions, as it
	was.  Document.

2005-01-24 00:48  Alexander Malmberg  <alexander@malmberg.org>

	* Source/NSImageCell.m (-drawInteriorWithFrame:inView:): Draw
	the image using the right size, but don't scale it. Work around
	bug #11712.

2005-01-22 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Source/NSFontManager.m (-fontWithFamily:traits:weight:size:)
	Corrected logic in fallback approximate trait search for weight 5 or 6
	(regular) fonts. Font w/approximate traits but originally-requested
	weight will now be found.
	
2005-01-21 21:43  Alexander Malmberg  <alexander@malmberg.org>

	Various whitespace cleanups, comment type fixes, and changes
	to avoid warnings from recent versions of gcc.

	* Headers/Additions/GNUstepGUI/GSToolbar.h (-_toolbars): Declare.
	* Source/NSWindow+Toolbar.m: Remove conflicting declaration of
	[NSToolbar -_toolbars].

	* Headers/Additions/GNUstepGUI/GSServicesManager.h,
 	Source/GSServicesMananger.m (-item2title:, -validateMenuItem:):
	Adjust argument types.
	* Headers/AppKit/NSMenu.h (-validateMenuItem:): Adjust argument
	type.

	* Source/NSTextView.m (-sizeToFit): Don't use size uninitialized
	if neither resizable flags is set.
	(-insertText:): Adjust argument type.
	* Headers/AppKit/NSResponder.h, Source/NSResponder.m (-insertText:):
	Adjust argument type. Document.

	* Headers/AppKit/NSView.h: Change type of ivar _window to NSWindow *.

	* Source/GSTitleView.m (-mouseDown:): Always initialize
	startWindowOrigin.
	* Source/NSApplication.m (-setApplicationIconImage:): Add casts
	to avoid warnings.
	* Source/NSCell.m (-cellSize): Add default: case.
	* Source/NSPasteboard.m
	([GSFiltered -pasteboard:provideDataForType:]): Detect and warn if we
	can't find a filter that will get us the desired type.
	* Source/NSProgressIndicator.m: Comment out unused variable 'images'.
	* Source/NSBezierPath.m: Declare GSBezierPath fully before using it.
	(-bezierPathByFlatteningPath, -bezierPathByReversingPath): Make sure
	variables are always initialized.

	* Source/NSMenuView.m,
	* Source/NSPrintOperation.m,
	* Source/NSSplitView.m,
	* Source/NSTableHeaderView.m: Make sure variables are always
	initialized.

	* Source/NSBox.m,
	* Source/NSImageview.m,
	* Source/NSText.m,
	* Source/NSTextStorage.m: Add missing includes.

	* Source/GSKeyBindingTable.m,
	* Source/GSLayoutManager.m,
	* Source/NSBitmapImageRep+PNM.m,
	* Source/NSBundleAdditions.m,
	* Source/NSLayoutManager.m,
	* Source/nsimage-tiff.h,
	* Source/tiff.m,
	* Headers/Additions/GNUstepGUI/GSDisplayServer.h,
	* Source/GSDisplayServer.m: Change signedness of various variables.

	* Source/NSPanel.m (-sendEvent:): Remove.
	* Source/NSWindow.m (-becomesKeyOnlyIfNeeded): New method.
	(-_sendEvent:becomesKeyOnlyIfNeeded:): Remove. Move code ...
	(-sendEvent:): ... here. Use -becomesKeyOnlyIfNeeded instead
	of the argument.

2005-01-21  Quentin Mathe  <qmathe@club-internet.fr>

	* Source/GSToolbarView.m:
	* Headers/Additions/GNUstepGUI/GSToolbarView.h:
	Renamed the NSColor(Extensions) category with the more descriptive name 
	NSColor(GSToolbarViewAdditions). This modification permits GNUMail 
	compilation with recent Darwin linker versions which prevented it 
	because GNUMail has a NSColor category identically named "Extensions".

2005-01-20  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSTableView.m (-rowAtPoint:): If the heigh of the table
	is incorrect and because of this the row would be greater than the
	number of rows, return a usable number.

2005-01-18 17:06  Alexander Malmberg  <alexander@malmberg.org>

	* Source/NSWindow.m
	(-initWithContentRect:styleMask:backing:defer:screen:): Assert that
	the shared application instance has been created instead of just
	calling NSLog. Make the message clearer.

2005-01-18 16:53  Alexander Malmberg  <alexander@malmberg.org>

	* Source/NSCell.m (-setUpFieldEditorAttributes:): Clear the
	text object's string.
	* Source/NSControl.m (-setDoubleValue:, -setFloatValue:)
	(-setIntValue:, -setStringValue:, -setObjectValue:): If the receiver
	was being edited when the method was called, make it the first
	responder after changing the value.
	(-abortEditing): Don't clear the text object's string.
	* Source/NSMatrix.m (-abortEditing): Don't clear the text object's
	string.
	* Source/NSTableView.m (-abortEditing): Ditto.
	* Source/NSTextField.m (-abortEditing): Ditto.

2005-01-18 16:39  Alexander Malmberg  <alexander@malmberg.org>

	* Source/NSBitmapImageRep.m
	(-TIFFRepresentationUsingCompression:factor:): Don't use pointer
	comparisons to compare strings. Handle both device and calibrated
	colorspaces. Warn if the colorspace isn't recognized.

2005-01-18 15:50  Alexander Malmberg  <alexander@malmberg.org>

	* Source/NSApplication.m (-runModalSession:): Don't order the window
	to the front or make it the key/main window.

2005-01-18 15:46  Alexander Malmberg  <alexander@malmberg.org>

	* Source/NSApplication.m (-finishLaunching): Don't attempt to open
	an untitled file if we were autolaunched.

2005-01-18 14:16  Alexander Malmberg  <alexander@malmberg.org>

	* Source/NSAffineTransform.m (pi): Correct the rounding.

2005-01-18  Matt Rice <ratmice@yahoo.com>

        * Source/NSTextView.m (setSelectedRange:): Do not make the selected
	text visible.
        (-didChangeText,-checkSpelling:): Make the selected text visible.
        * Source/NSTextView_actions.m (_moveTo:select:): Ditto.
        * Source/NSCell.m (-setUpFieldEditorAttributes:): Ditto.
        (-selectWithFrame:inView:editor:delegate:start:length:): Ditto.
        * Source/NSComboBoxCell (-validateSelection:,-textDidChange:): Ditto.

2005-01-18 14:09  Alexander Malmberg  <alexander@malmberg.org>

	* Source/Functions.m (NSDottedFrameRect, NSFrameRectWithWidth): Draw
	the frame inside the given rectangle.
	(NSDrawTiledRects): Remove documentation.
	* Headers/AppKit/NSGraphics.h (NSDottedFrameRect, NSFrameRect)
	(NSFrameRectWithWidth, NSDrawTiledRects): Add new documentation.

2005-01-17 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Source/NSWindow.m (-sendEvent:becomesKeyOnlyIfNeeded:): Give
	mouseDragged events to _lastView rather than view (if exists)
	underneath mouse.

2005-01-17 Adrian Robert <arobert@cogsci.ucsd.edu>

	* Source/NSApplication.m
	(-nextEventMatchingMask:untilDate:inMode:dequeue:): Check that
	event is not 'null_event' before using it to unhide mouse.

2005-01-17  Fred Kiefer <FredKiefer@gmx.de>

	* Source/NSBrowserCell.m (-setType:): New method, does nothing to
	allow image and text at once (MacOSX 10.2 behaviour).
	(-drawInteriorWithFrame:inView:): Draw an image or alternate image,
	if provided and draw the text as well.
	
2005-01-16  Fred Kiefer <FredKiefer@gmx.de>

	* Images/common_ClosedHandCursor.tiff: Replaced by new image files by
	Fabien Vallon <fabien@sonappart.net>.

2005-01-16  Fred Kiefer <FredKiefer@gmx.de>

	* TextConverters/RTF/RTFProducer.m (-_stringWithRTFCharacters:):
	Output "\uc0" so that other applications know we don't write ANSI
	representations of Unicode characters.

2005-01-16  Fred Kiefer <FredKiefer@gmx.de>

	* Printing/GSCUPS/GSCUPSPrinter.m (+printerNames): Add dummy
	printer to list, if no printers are found.

2005-01-16 06:39 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/NSDocument.m: In validateMenuItem: added code to 
	properly set the undo/redo title and disable the menus when
	appropriate.

2005-01-15 05:59 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/NSDocument.m: Added undo:/redo: here.  Smarter use
	of the responder chain.
	* Source/NSWindow.m: Removed undo:/redo: here.

2005-01-14 16:11  Alexander Malmberg <alexander@malmberg.org>

	* Headers/AppKit/NSSavePanel.h (-panel:shouldShowFilename:):
	Document.
	* Source/NSSavePanel.m (-setDelegate:): Call -validateVisibleColumns.
	Whitespace cleanups.
	(-browser:isColumnValid:): Give the delegate the complete path to
	each file.

	Fixes bug #10553.

2005-01-14 09:25 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/NSDocument.m: Minor change.  The init method now sets the
	flag to YES so that when a undoManager is needed, it's instantiated.

2005-01-14 05:50 Gregory John Casamento <greg_casamento@yahoo.com>

	* Source/NSDocument.m: corrected undoManager call in NSDocument.

2005-01-13  Adam Fedor  <fedor@gnu.org>

	* Source/GNUmakefile.preamble: Extend FILTER_OUT flag to
	all sparc architectures.

2005-01-12 16:40  Alexander Malmberg <alexander@malmberg.org>

	* Headers/AppKit/NSBezierPath.h (-windingCountAtPoint:): Mark as
	a GNUstep extension.

2005-01-12 00:47  Alexander Malmberg <alexander@malmberg.org>

	* Source/GSStandardWindowDecorationView.m (-initWithFrame:window:):
	Create a paragraph style with line-breaking-by-clipping and use it
	for window titles.

2005-01-12 00:41  Alexander Malmberg <alexander@malmberg.org>

	* Printing/GSCUPS/GSCUPSPrinter.h (GSCUPSDummyPrinterName): New
	variable.
	* Printing/GSCUPS/GSCUPSPrinter.m (GSCUPSDummyPrinterName): New
	variable.
	(+printerWithName:): Warn and return a dummy printer when requested.
	* Printing/GSCUPS/GSCUPSPrintInfo.m (defaultPrinter): If there's
	no default CUPS printer set, return a dummy printer.

	Fixes bug #10916.

2005-01-11 23:50  Alexander Malmberg <alexander@malmberg.org>

	* Headers/AppKit/NSBezierPath.h (NSWindingRule)
 	(-containsPoint): Document.
	(-windingCountAtPoint:): New method.
	* Source/NSBezierPath.m: Remove some trailing whitespace.
	(PI): Correct rounding.
	(contribution, -contributionToContains:): Remove.
	(winding_line, winding_curve): New functions.
	(-windingCountAtPoint:): New method.
	(-containsPoint:): Use -windingCountAtPoint: instead of
	-contributionToContains:. Don't flatten the path.

2005-01-09  Matt Rice  <ratmice@yahoo.com>
	
	* Source/NSTableHeaderCell.m (-drawInteriorWithFrame:inView:): Use
	the correct background/highlight colors and NSCompositeSourceOver for
	image cells. 
	(-setHighlighted): Use controlHighlightColor instead of controlColor.