From da1d2f0df1233aa1b996c33108a4e1bef3f9d9d2 Mon Sep 17 00:00:00 2001 From: David Ayers Date: Sun, 16 Mar 2008 21:43:28 +0000 Subject: [PATCH] * EOInterface/EOAssociation.m ([+objectDeallocated:]): Use makeObjectsPerformSelector: instead of makeObjectsPerform:. * EOInterface/EORadioMatrixAssociation.m ([NSMatrix-_selectCellWithTitle:]): Do not access instance variables directly. Use accessor methods instead. * EOInterface/EOActionAssociation.m, * EOInterface/EOActionInsertionAssociation.m, * EOInterface/EOAspectConnector.m, * EOInterface/EOAssociation.m, * EOInterface/EOColumnAssociation.m, * EOInterface/EOComboBoxAssociation.m, * EOInterface/EODetailSelectionAssociation.m, * EOInterface/EODisplayGroup.m, * EOInterface/EOGenericControlAssociation.m, * EOInterface/EOMasterCopyAssociation.m, * EOInterface/EOMasterDetailAssociation.m, * EOInterface/EOMatrixAssociation.m, * EOInterface/EOPickTextAssociation.m, * EOInterface/EOPopUpAssociation.m, * EOInterface/EORadioMatrixAssociation.m, * EOInterface/EORecursiveBrowserAssociation.m, * EOInterface/EOTableViewAssociation.m, * EOInterface/EOTableViewAssociation.m, * EOInterface/EOTextAssociation.m, * EOInterface/NSImage+Additions.m: Add include for . git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gdl2/trunk@26321 72102866-910b-0410-8b05-ffd578937521 --- ChangeLog | 31 +++++++++++++++++++++ EOInterface/EOActionAssociation.m | 1 + EOInterface/EOActionInsertionAssociation.m | 1 + EOInterface/EOAspectConnector.m | 1 + EOInterface/EOAssociation.m | 3 +- EOInterface/EOColumnAssociation.m | 1 + EOInterface/EOComboBoxAssociation.m | 1 + EOInterface/EODetailSelectionAssociation.m | 1 + EOInterface/EODisplayGroup.m | 1 + EOInterface/EOGenericControlAssociation.m | 1 + EOInterface/EOMasterCopyAssociation.m | 1 + EOInterface/EOMasterDetailAssociation.m | 1 + EOInterface/EOMatrixAssociation.m | 1 + EOInterface/EOPickTextAssociation.m | 1 + EOInterface/EOPopUpAssociation.m | 1 + EOInterface/EORadioMatrixAssociation.m | 3 +- EOInterface/EORecursiveBrowserAssociation.m | 1 + EOInterface/EOTableViewAssociation.m | 5 ++++ EOInterface/EOTextAssociation.m | 1 + EOInterface/NSImage+Additions.m | 1 + 20 files changed, 56 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 075a3df..cb46095 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,34 @@ +2008-03-16 Blake Nicholson + + * EOInterface/EOAssociation.m ([+objectDeallocated:]): + Use makeObjectsPerformSelector: instead of makeObjectsPerform:. + + * EOInterface/EORadioMatrixAssociation.m + ([NSMatrix-_selectCellWithTitle:]): Do not access instance variables + directly. Use accessor methods instead. + + * EOInterface/EOActionAssociation.m, + * EOInterface/EOActionInsertionAssociation.m, + * EOInterface/EOAspectConnector.m, + * EOInterface/EOAssociation.m, + * EOInterface/EOColumnAssociation.m, + * EOInterface/EOComboBoxAssociation.m, + * EOInterface/EODetailSelectionAssociation.m, + * EOInterface/EODisplayGroup.m, + * EOInterface/EOGenericControlAssociation.m, + * EOInterface/EOMasterCopyAssociation.m, + * EOInterface/EOMasterDetailAssociation.m, + * EOInterface/EOMatrixAssociation.m, + * EOInterface/EOPickTextAssociation.m, + * EOInterface/EOPopUpAssociation.m, + * EOInterface/EORadioMatrixAssociation.m, + * EOInterface/EORecursiveBrowserAssociation.m, + * EOInterface/EOTableViewAssociation.m, + * EOInterface/EOTableViewAssociation.m, + * EOInterface/EOTextAssociation.m, + * EOInterface/NSImage+Additions.m: + Add include for . + 2008-03-16 Matt Rice * EOAdaptors/PostgreSQLAdaptor/PostgreSQLExpression.m diff --git a/EOInterface/EOActionAssociation.m b/EOInterface/EOActionAssociation.m index de47371..02b89a9 100644 --- a/EOInterface/EOActionAssociation.m +++ b/EOInterface/EOActionAssociation.m @@ -34,6 +34,7 @@ #include #endif +#include #include "EOActionAssociation.h" #include "SubclassFlags.h" #include "EODisplayGroup.h" diff --git a/EOInterface/EOActionInsertionAssociation.m b/EOInterface/EOActionInsertionAssociation.m index 4db76ff..16bb0aa 100644 --- a/EOInterface/EOActionInsertionAssociation.m +++ b/EOInterface/EOActionInsertionAssociation.m @@ -34,6 +34,7 @@ #include #endif +#include #include "EOActionInsertionAssociation.h" @implementation EOActionInsertionAssociation diff --git a/EOInterface/EOAspectConnector.m b/EOInterface/EOAspectConnector.m index 84d87dd..19a5e04 100644 --- a/EOInterface/EOAspectConnector.m +++ b/EOInterface/EOAspectConnector.m @@ -25,6 +25,7 @@ #include "EOAspectConnector.h" #include +#include #include @implementation EOAspectConnector : NSNibConnector diff --git a/EOInterface/EOAssociation.m b/EOInterface/EOAssociation.m index 52bcf34..ca4b395 100644 --- a/EOInterface/EOAssociation.m +++ b/EOInterface/EOAssociation.m @@ -35,6 +35,7 @@ #include #endif +#include #include #include "EODisplayGroup.h" @@ -56,7 +57,7 @@ static NSMapTable *_objectToAssociations; if (associations) { - [associations makeObjectsPerform: @selector(breakConnection)]; + [associations makeObjectsPerformSelector: @selector(breakConnection)]; NSMapRemove(_objectToAssociations, object); } } diff --git a/EOInterface/EOColumnAssociation.m b/EOInterface/EOColumnAssociation.m index 8955d6b..7fd895a 100644 --- a/EOInterface/EOColumnAssociation.m +++ b/EOInterface/EOColumnAssociation.m @@ -36,6 +36,7 @@ #include #endif +#include #include "EODisplayGroup.h" #include "EOColumnAssociation.h" #include "SubclassFlags.h" diff --git a/EOInterface/EOComboBoxAssociation.m b/EOInterface/EOComboBoxAssociation.m index 644aa5b..218887c 100644 --- a/EOInterface/EOComboBoxAssociation.m +++ b/EOInterface/EOComboBoxAssociation.m @@ -34,6 +34,7 @@ #include #endif +#include #include "EOControlAssociation.h" #include "EOComboBoxAssociation.h" diff --git a/EOInterface/EODetailSelectionAssociation.m b/EOInterface/EODetailSelectionAssociation.m index f627fcd..620eb59 100644 --- a/EOInterface/EODetailSelectionAssociation.m +++ b/EOInterface/EODetailSelectionAssociation.m @@ -30,6 +30,7 @@ #include #endif +#include #include "EODisplayGroup.h" #include "EODetailSelectionAssociation.h" diff --git a/EOInterface/EODisplayGroup.m b/EOInterface/EODisplayGroup.m index de8ee3c..2d92aa2 100644 --- a/EOInterface/EODisplayGroup.m +++ b/EOInterface/EODisplayGroup.m @@ -44,6 +44,7 @@ RCS_ID("$Id$") #include #endif +#include #include #include #include diff --git a/EOInterface/EOGenericControlAssociation.m b/EOInterface/EOGenericControlAssociation.m index 722de74..6777740 100644 --- a/EOInterface/EOGenericControlAssociation.m +++ b/EOInterface/EOGenericControlAssociation.m @@ -36,6 +36,7 @@ #include #endif +#include #include "EOControlAssociation.h" #include "EODisplayGroup.h" #include "SubclassFlags.h" diff --git a/EOInterface/EOMasterCopyAssociation.m b/EOInterface/EOMasterCopyAssociation.m index 3047b6c..a20a6d6 100644 --- a/EOInterface/EOMasterCopyAssociation.m +++ b/EOInterface/EOMasterCopyAssociation.m @@ -30,6 +30,7 @@ #include #endif +#include #include "EODisplayGroup.h" #include "EOMasterCopyAssociation.h" diff --git a/EOInterface/EOMasterDetailAssociation.m b/EOInterface/EOMasterDetailAssociation.m index a0bb0c7..c7da28d 100644 --- a/EOInterface/EOMasterDetailAssociation.m +++ b/EOInterface/EOMasterDetailAssociation.m @@ -32,6 +32,7 @@ #include +#include #include "EODisplayGroup.h" #include "EOMasterDetailAssociation.h" #include "SubclassFlags.h" diff --git a/EOInterface/EOMatrixAssociation.m b/EOInterface/EOMatrixAssociation.m index 39c6c0f..9918551 100644 --- a/EOInterface/EOMatrixAssociation.m +++ b/EOInterface/EOMatrixAssociation.m @@ -34,6 +34,7 @@ #include #endif +#include #include "EOControlAssociation.h" #include "EOMatrixAssociation.h" #include "EODisplayGroup.h" diff --git a/EOInterface/EOPickTextAssociation.m b/EOInterface/EOPickTextAssociation.m index 1a725d1..1cd6117 100644 --- a/EOInterface/EOPickTextAssociation.m +++ b/EOInterface/EOPickTextAssociation.m @@ -33,6 +33,7 @@ #include #endif +#include #include "EOPickTextAssociation.h" @implementation EOPickTextAssociation diff --git a/EOInterface/EOPopUpAssociation.m b/EOInterface/EOPopUpAssociation.m index 0e41182..e3dfa55 100644 --- a/EOInterface/EOPopUpAssociation.m +++ b/EOInterface/EOPopUpAssociation.m @@ -33,6 +33,7 @@ #include #endif +#include #include "EOControlAssociation.h" #include "EODisplayGroup.h" #include "EOPopUpAssociation.h" diff --git a/EOInterface/EORadioMatrixAssociation.m b/EOInterface/EORadioMatrixAssociation.m index 53ff3db..34cc634 100644 --- a/EOInterface/EORadioMatrixAssociation.m +++ b/EOInterface/EORadioMatrixAssociation.m @@ -34,6 +34,7 @@ #include #endif +#include #include "EOControlAssociation.h" #include "EORadioMatrixAssociation.h" #include "SubclassFlags.h" @@ -54,7 +55,7 @@ while (j-- > 0) { - if ([[_cells[i][j] title] isEqual: title]) + if ([[[self cellAtRow: i column: j] title] isEqual: title]) { [self selectCellAtRow:i column:j]; return YES; diff --git a/EOInterface/EORecursiveBrowserAssociation.m b/EOInterface/EORecursiveBrowserAssociation.m index d4dfcd0..e651277 100644 --- a/EOInterface/EORecursiveBrowserAssociation.m +++ b/EOInterface/EORecursiveBrowserAssociation.m @@ -33,6 +33,7 @@ #include #endif +#include #include #include "EOControlAssociation.h" diff --git a/EOInterface/EOTableViewAssociation.m b/EOInterface/EOTableViewAssociation.m index 5317418..8ad235d 100644 --- a/EOInterface/EOTableViewAssociation.m +++ b/EOInterface/EOTableViewAssociation.m @@ -39,7 +39,12 @@ #include #endif +#include #include "EOColumnAssociation.h" +#include "EOControlAssociation.h" +#include "EOPickTextAssociation.h" +#include "EOActionAssociation.h" +#include "EOActionInsertionAssociation.h" #include "EODisplayGroup.h" @implementation EOTableViewAssociation diff --git a/EOInterface/EOTextAssociation.m b/EOInterface/EOTextAssociation.m index 8d7c997..b6070a2 100644 --- a/EOInterface/EOTextAssociation.m +++ b/EOInterface/EOTextAssociation.m @@ -35,6 +35,7 @@ #include #endif +#include #include "EODisplayGroup.h" #include "EOTextAssociation.h" #include "SubclassFlags.h" diff --git a/EOInterface/NSImage+Additions.m b/EOInterface/NSImage+Additions.m index 05d138e..dd8c195 100644 --- a/EOInterface/NSImage+Additions.m +++ b/EOInterface/NSImage+Additions.m @@ -24,6 +24,7 @@ */ #include "EOControlAssociation.h" +#include @implementation NSImage (EOImageFactory)