gnustep/libs-gdl2
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gdl2.git synced 2025-04-22 12:55:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

* GDL2Palette/DisplayGroupInspector.m

Browse source 
some NS(U)Integer transitions to fix warnings about
          comparisons against NSNotFound



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gdl2/trunk@36232 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Sebastian Reitenbach 2013-03-02 14:14:21 +00:00
parent de5c0311d1
commit bc990481e7
4 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ChangeLog
View file

@ -14,6 +14,12 @@
* shutup all clang warnings of type:
equality comparison with extraneous parentheses
all harmless, but in EOEntity.m it actually was wrong
* EOAccess/EORelationship.m
* EOInterface/EODisplayGroup.m
* GDL2Palette/DisplayGroupInspector.m
some NS(U)Integer transitions to fix warnings about
comparisons against NSNotFound
2013-03-01: Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>
* EOControl/EODebug.m
do not use redundant stringWithString

8
EOAccess/EORelationship.m
View file

@ -2001,8 +2001,8 @@ becomes "name", and "FIRST_NAME" becomes "firstName".*/
{
NSArray *destAttributes = nil;
NSArray *primaryKeyAttributes = nil;
int destAttributesCount = 0;
int primaryKeyAttributesCount = 0;
NSUInteger destAttributesCount = 0;
NSUInteger primaryKeyAttributesCount = 0;
BOOL foreignKeyInDestination = NO;
@ -2020,14 +2020,14 @@ becomes "name", and "FIRST_NAME" becomes "firstName".*/
if (destAttributesCount > 0 && primaryKeyAttributesCount > 0)
{
int i;
NSUInteger i;
for (i = 0;
!foreignKeyInDestination && i < destAttributesCount;
i++)
{
EOAttribute *attribute = [destAttributes objectAtIndex: i];
int pkAttrIndex = [primaryKeyAttributes
NSUInteger pkAttrIndex = [primaryKeyAttributes
indexOfObjectIdenticalTo: attribute];
foreignKeyInDestination = (pkAttrIndex == NSNotFound);

4
EOInterface/EODisplayGroup.m
View file

@ -91,7 +91,7 @@ NSString *EODisplayGroupWillFetchNotification = @"EODisplayGroupWillFetch";
@implementation NSArray (private)
- (NSArray *)indexesForObjectsIdenticalTo: (NSArray *)array
{
unsigned idx, i, c = [array count];
NSUInteger idx, i, c = [array count];
NSMutableArray *indices = (id)[NSMutableArray arrayWithCapacity: c];
id object;
NSNumber *number;
@ -103,7 +103,7 @@ NSString *EODisplayGroupWillFetchNotification = @"EODisplayGroupWillFetch";
if (idx != NSNotFound)
{
/* We should cache all these numbers. */
number = [NSNumber numberWithUnsignedInt: idx];
number = [NSNumber numberWithUnsignedInteger: idx];
[indices addObject: number];
}
}

2
GDL2Palette/DisplayGroupInspector.m
View file

@ -84,7 +84,7 @@
- (void) removeKey:(id)sender
{
int selRow = [_localKeysTable selectedRow];
NSInteger selRow = [_localKeysTable selectedRow];
if (selRow != NSNotFound && selRow > 0 && selRow < [_localKeys count])
{
[_localKeys removeObjectAtIndex:[_localKeysTable selectedRow]];