From 61a0bb03252f9057999ee4a6ac56ee1cf3b8b2ff Mon Sep 17 00:00:00 2001 From: ratmice Date: Tue, 13 May 2008 07:15:20 +0000 Subject: [PATCH] * DBModeler/Resources/Menu-{Cocoa,GNUstep}.gsmarkup: Remove a TODO for an old unused hack. * EOModeler/EOModelerDocument.m: Add some comments about the new hack. git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gdl2/trunk@26518 72102866-910b-0410-8b05-ffd578937521 --- ChangeLog | 8 +++++++- DBModeler/Resources/Menu-Cocoa.gsmarkup | 1 - DBModeler/Resources/Menu-GNUstep.gsmarkup | 1 - EOModeler/EOModelerDocument.m | 13 +++++++++++++ 4 files changed, 20 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index f1903a9..fa48888 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,12 @@ +2008-05-13 Matt Rice + + * DBModeler/Resources/Menu-{Cocoa,GNUstep}.gsmarkup: Remove a TODO + for an old unused hack. + * EOModeler/EOModelerDocument.m: Add some comments about the new hack. + 2008-05-12 Matt Ride - * DBModeler/Resources/MainMenu-GNUstep.gsmarkup: Use openPrefs: action + * DBModeler/Resources/Menu-GNUstep.gsmarkup: Use openPrefs: action for preferences menu item. 2008-05-12 Blake Nicholson diff --git a/DBModeler/Resources/Menu-Cocoa.gsmarkup b/DBModeler/Resources/Menu-Cocoa.gsmarkup index 6b70737..410c1cc 100644 --- a/DBModeler/Resources/Menu-Cocoa.gsmarkup +++ b/DBModeler/Resources/Menu-Cocoa.gsmarkup @@ -44,7 +44,6 @@ action="switchAdaptor:" /> - diff --git a/DBModeler/Resources/Menu-GNUstep.gsmarkup b/DBModeler/Resources/Menu-GNUstep.gsmarkup index 0f728e2..d07ef71 100644 --- a/DBModeler/Resources/Menu-GNUstep.gsmarkup +++ b/DBModeler/Resources/Menu-GNUstep.gsmarkup @@ -33,7 +33,6 @@ action="switchAdaptor:" /> - diff --git a/EOModeler/EOModelerDocument.m b/EOModeler/EOModelerDocument.m index dfb3ced..b3fd4ad 100644 --- a/EOModeler/EOModelerDocument.m +++ b/EOModeler/EOModelerDocument.m @@ -71,6 +71,19 @@ showOnSuccess:(BOOL)flag; static Class _defaultEditorClass; static EOModelerEditor *_currentEditorForDocument; +/* FIXME we cross the library->application boundry whenever working + * with the ConsistencyResults class which is declared in DBModeler + * theres a few ways this is crossed: + * + * enabling/disabling the cancel button + * appending text + * avoiding running the panel if all checks pass. + * + * this could possibly be done with private methods in this class + * called from the receiver of an EOMCheckConsistencyEndNotification + * on the notification -object (or something). + */ + /** Notification sent when beginning consistency checks. * The notifications object is the EOModelerDocument. * The receiver should call -appendConsistencyCheckErrorText: