Commit graph

8145 commits

Author SHA1 Message Date
Richard Frith-Macdonald
7fcd11d6c9 Rewrite -replaceCharactersInRange:withString: to cope with the case where the string argument is the receiver (or some proxy to the receiver etc). 2020-11-22 08:08:34 -05:00
Richard Frith-Macdonald
3bb72398ee Report YES for GSImmutableString being a proxy 2020-11-22 08:08:00 -05:00
Richard Frith-Macdonald
5ec87d80b4 Fix for text storage objects setting their content to their own immutable proxy 2020-11-21 08:23:53 +00:00
Richard Frith-Macdonald
1170e0c0c1 add casts to avoid compiler warnings 2020-11-20 01:42:33 -05:00
Richard Frith-Macdonald
aa0beb0758 Minor tidyup for clearer indentation 2020-11-19 08:33:20 -05:00
Richard Frith-Macdonald
8178e52806 Correct checks for validity of the second UTF16 value in a surrogate pair 2020-11-19 08:27:06 -05:00
rfm
d27dcfbed6
Merge pull request #164 from triplef/add-nsfilehandle-url-methods
Add NSFileHandle URL initializers.
2020-11-18 09:21:13 +00:00
Richard Frith-Macdonald
e7035cadf3 Be defensive about checking for key beginning with @ 2020-11-18 09:09:48 +00:00
Frederik Seiffert
88a2e0809f Add NSFileHandle URL initializers.
Also use "instancetype" for all initializers.
2020-11-17 19:48:05 +01:00
Richard Frith-Macdonald
d4df4b6d87 Add methods to control size of in-memory queue os emails 2020-11-14 04:25:34 +00:00
Richard Frith-Macdonald
23d431234c Fix bug in offset 2020-11-13 05:41:42 +00:00
Richard Frith-Macdonald
a34beadb8e Merge branch 'gnustep_testplant_mergeback' of https://github.com/TestPlant/libs-base into TestPlant-gnustep_testplant_mergeback
Conflicts:
	ChangeLog
2020-11-13 05:39:15 +00:00
Frederik Seiffert
06fa7792a5 Fix compilation with ICU 68. 2020-11-12 17:18:09 +01:00
Richard Frith-Macdonald
ae90743153 Avoid building unused functions when new string API is used. 2020-11-11 22:23:13 +00:00
rfm
17af685b1a
Merge branch 'master' into nsurl-additions 2020-11-06 09:36:42 +00:00
rfm
8ccd6e2675
Merge pull request #102 from Artoria2e5/pluti
Add plutil utility
2020-11-06 09:12:33 +00:00
Richard Frith-Macdonald
efabfab3d0 Merge branch 'master' of ssh://github.com/gnustep/libs-base 2020-10-29 09:05:51 +00:00
Richard Frith-Macdonald
2b840550f0 Improve logging of an exception when posting a notification so that, if possible, we include the details of the notification being posted. 2020-10-29 09:04:51 +00:00
Gregory John Casamento
2ba26ce34a fix for compilation error 2020-10-27 09:44:21 -04:00
Gregory Casamento
e5a7733f04
Merge pull request #161 from gnustep/nsurlconnection_10_5_methods
Add methods from 10.5
2020-10-27 08:14:22 -04:00
Gregory John Casamento
85f590f88e Add methods for 10.5 2020-10-26 23:53:11 -04:00
Richard Frith-Macdonald
feac65a23f Fix use of potentially invalid value from heap 2020-10-24 17:54:55 +01:00
Adam Fox
0b69d88ee2 Implementation of [NSData rangeOfData:options:range], adapted from [NSString rangeOfString:options:range]. 2020-10-12 12:22:00 -06:00
Richard Frith-Macdonald
ba5b950fa5 fix retain/release error 2020-10-11 11:24:49 +01:00
Richard Frith-Macdonald
57efbdb09e improve comments 2020-10-03 15:18:21 +01:00
Richard Frith-Macdonald
21839365a9 Remove unnecessary retain/release 2020-09-30 10:08:36 +01:00
Richard Frith-Macdonald
98dfa140ec added autorelease pool around each operation to catch any autoreleased
objects produced by the operation being executed. This should prevent
objects living until the end of the thread.
2020-09-30 09:56:24 +01:00
Richard Frith-Macdonald
6ae48bd3d3 Tidied code 2020-09-30 09:55:43 +01:00
Richard Frith-Macdonald
7977bcb19d Tidied some whitespace/indentation and removed obsolete comment 2020-09-21 11:41:39 +01:00
Riccardo Mottola
18dfe7b8f6 Windows linker doesn't really support WEAK symbols, not even with gcc10. binutils 2.3.5 fails to link because not all symbols were exported 2020-09-17 23:46:37 +02:00
Richard Frith-Macdonald
938f280b87 Implement fast enumeration for insensitive dictionary 2020-09-08 15:14:19 +01:00
fredkiefer
7dc4a8f532 Add missing break 2020-09-05 22:34:48 +02:00
Richard Frith-Macdonald
1ddcb25b7e Avcoid coverity warning 2020-08-23 16:01:21 +01:00
Richard Frith-Macdonald
32f306b615 avoid coverity warning 2020-08-23 15:48:47 +01:00
fredkiefer
93d4576871 * Source/NSDateComponentsFormatter.m: Fix use of wrong operator. 2020-08-30 22:27:08 +02:00
Richard Frith-Macdonald
48c270b9ca Improve -contentFile to check the content-type header before content-disposition 2020-08-08 19:30:18 +01:00
Frederik Seiffert
01e7034262 Add NSURL methods:
- URLByAppendingPathComponent:isDirectory:
- isFileReferenceURL (always returns NO)
- fileReferenceURL
- filePathURL
2020-08-03 13:08:15 +02:00
Richard Frith-Macdonald
1f2b03e84d Fix calls to utimensat() which were passing the wrong value for the first argument, which needs to be the file descriptor of the directory containing the file, or AT_FDCWD to use the current directory. 2020-07-31 16:00:36 +01:00
Richard Frith-Macdonald
62c68d3cab Set dates on copy ... it turns our OSX does not behave like Posix 2020-07-31 15:29:02 +01:00
Riccardo Mottola
24261fdc45 explicitely allow disabling unwind, test for header and function too 2020-07-28 01:02:55 +02:00
Frederik Seiffert
b9a9481c56 Update NSURLRequest header to use "instancetype". 2020-07-14 09:21:53 +02:00
Richard Frith-Macdonald
291ad8384e move deallocation of zombie map outside lock protected section so that any exception while deallocating will not cause unbalanced lock/unlock 2020-07-09 09:11:47 +01:00
Richard Frith-Macdonald
684e952b04 When copying objects we should not be attempting to set the creation/modification date of the copy to that of the original. 2020-07-09 09:10:30 +01:00
Richard Frith-Macdonald
0c302348b0 Add casts to prevent compiler warnings, and comment to explain the new change for android where there is no thread ID available from the operating system. 2020-07-09 09:09:19 +01:00
Frederik Seiffert
94d14ca02a Don't log current thread if its identical to private thread ID. 2020-07-08 17:02:41 +02:00
Frederik Seiffert
3752016412 Improve NSLog output on Android. 2020-07-08 16:15:57 +02:00
rfm
69c9e77afb
Merge pull request #146 from gnustep/msys-fix
Fix MSYS2-32
2020-07-08 13:59:07 +01:00
Richard Frith-Macdonald
47b6defc26 We only need to set the ownership of a newly created file on unix-like systems where the effective user ID may be different from the real user ID. 2020-07-07 07:42:40 +01:00
Frederik Seiffert
a7e87824c0 Fix possible deadlock when becoming multi-threaded. 2020-07-06 22:01:01 +02:00
Richard Frith-Macdonald
8e97401783 Replace temporarty hack with a rewrite of whitespace checking to use our own
characterset data (derived from unicode data) on which characters are counted
as whitespace for the purpose of capitalising strings.
counted as white space
2020-06-27 08:33:13 +01:00
Richard Frith-Macdonald
31ea5db30b When overwriting a file with data, do not attempt to set creation date.
When creaqting a new file, try to use the real uid when effective uid is root
2020-06-25 09:19:44 +01:00
Richard Frith-Macdonald
b7882e3194 Simple fix to check for whitespace characters using strchr since the old
mechanism using characterset bitmap representations was broken by the
change to reduce waste in bintmaps (the code assumed the bitmap was
bigger than it really is).
2020-06-24 11:35:29 +01:00
Richard Frith-Macdonald
8acf2a5304 Merge branch 'master' of ssh://github.com/gnustep/libs-base 2020-06-23 07:05:34 +01:00
Richard Frith-Macdonald
e8a62e0e5e Check for nil arugment to -isEqualToString: 2020-06-23 07:03:55 +01:00
Riccardo Mottola
e1c32adb77 define WSAAPI to empty if it is undefined, just for safety 2020-06-19 09:03:06 +02:00
Riccardo Mottola
919f8c16d0 specify WSAAPI as return type too, needed for MSYS2-32bit 2020-06-15 23:52:35 +02:00
Gregory John Casamento
fff7573b88 Correct changelog 2020-06-14 20:21:12 -04:00
Richard Frith-Macdonald
057445b4e7 Merge branch 'master' of ssh://github.com/gnustep/libs-base 2020-06-11 16:30:49 +01:00
Gregory John Casamento
c8ab7a3bc2 Merge branch 'master' of github.com:gnustep/libs-base into NSSecureCoding_branch2 2020-06-11 09:38:20 -04:00
Frederik Seiffert
d6d2fa9a74 Fix recursive creation of value transformers. 2020-06-11 14:22:04 +02:00
Frederik Seiffert
c6f24e6634 Fix Android assets support for bundle directories 2020-06-10 20:31:03 +02:00
Riccardo Mottola
b879e0835b explicitely test for ws2tcpip.h header, fix library detection on windows for inet_ntop with corrent library, guard includes and definitions with configure results, cleanup header inclusion 2020-06-09 13:44:42 +02:00
Richard Frith-Macdonald
41ab84eaba So not attempt to alter creation date of newly created file. 2020-06-09 11:43:56 +01:00
Gregory John Casamento
3b315b9d21 Merge branch 'master' of github.com:gnustep/libs-base into NSSecureCoding_branch2 2020-06-08 04:12:45 -04:00
rfm
daadfe7a6d
Merge branch 'master' into android-assets-directory-improvements 2020-06-06 12:13:43 +01:00
rfm
e2d223b564
Merge pull request #142 from gnustep/msys-fix
Msys fix
2020-06-06 11:11:06 +01:00
Richard Frith-Macdonald
41badcb417 Fix leak of new operation in -blockOperationWithBlock: method. Make -addExecutionBlock: ensure it works with an on-heap copy of its argument. Tidy code to have NSBlockOperation methods with normal formatting and alphabetical order. Tidy code to use standard macros for memory management. 2020-06-05 17:43:46 +01:00
Riccardo Mottola
5bbe378a79 remove unneeded window headers include, since common.h will include GSConfig.h 2020-06-05 13:46:34 +02:00
Frederik Seiffert
71f6cde4bd Fix replacing an existing value in a weak objects map table. 2020-06-05 11:55:33 +02:00
Gregory John Casamento
ea162442ce Merge branch 'master' of github.com:gnustep/libs-base into NSSecureCoding_branch2 2020-06-04 18:40:14 -04:00
Richard Frith-Macdonald
a1d5d020b3 Change -objectForKey: method to get the contents into a buffer (on the stack) and iterate through them rather than creating an autoreleased enumerator. This avoids allocation/autorelease/deallocation of the enumerator (as well as etain/release of the search list by the enumerator) which should give better performance generally and avoid excess object creation when lots of defaults lookups are done in an autorelease pool. 2020-06-03 14:48:22 +01:00
Gregory John Casamento
597f0a917e Merge branch 'master' of github.com:gnustep/libs-base into NSSecureCoding_branch2 2020-05-31 17:41:23 -04:00
rfm
bf4c0719aa
Merge pull request #136 from gnustep/windows-ci
Set up CI for Windows using MinGW and GCC
Looks good, merging.
2020-05-29 16:33:42 +01:00
Richard Frith-Macdonald
6fd8dd7a20 Wrap code for posting of notifications (for becoming multithreaded and for a thread being about to exit) in an autorelease loop. This should avoid possible leakage of objects and warnings during the notification process. 2020-05-29 16:25:52 +01:00
Frederik Seiffert
a0fe037077 Include winsock2.h before windows.h, as required by MSYS2/MinGW-w64. 2020-05-29 10:40:03 +02:00
Gregory John Casamento
96f88dcc95 Merge branch 'master' of github.com:gnustep/libs-base into NSSecureCoding_branch2 2020-05-29 00:53:39 -04:00
Richard Frith-Macdonald
fab98ede73 On thread exit we must post the notification that it *will* exit before
setting the instance variable to say that it has finished.  This is tested
as the order OSX does it, and makes sense to ensure that, when -isFinished
returns YES we can be sure the thread will not do anything else.
2020-05-26 16:30:15 +01:00
rfm
a636994a33
Merge pull request #138 from triplef/fix-nsuserdefaults-setbool
Store NSNumber instead of NSString for NSUserDefaults -setBool:forKey:.
2020-05-26 12:38:41 +01:00
Richard Frith-Macdonald
861f8de610 Remove excess whitespace and copy trick to NSPortCoder 2020-05-26 09:18:49 +01:00
Gregory John Casamento
3a0420bddf Merge branch 'master' into NSSecureCoding_branch2 2020-05-26 01:52:58 -04:00
Riccardo Mottola
e7f89135d3 rewrite lower negative bounds to avoid integer constants underflow of literals 2020-05-25 23:50:36 +02:00
Frederik Seiffert
d2938c7729 Store NSNumber instead of NSString for NSUserDefaults -setBool:forKey:. 2020-05-25 17:34:34 +02:00
Frederik Seiffert
db19fc3308 Android assets improvements to support directories
- Extend NSBundle resources support to handle directories in Android assets.
- Fix NSFileManager -isReadableFileAtPath: to also support directories in Android assets.
2020-05-20 13:39:47 +02:00
Gregory John Casamento
2b38728f6e Merge branch 'master' into NSSecureCoding_branch2 2020-05-15 10:08:56 -04:00
Gregory John Casamento
4230180eab Add set/get for requiresSecureCoding 2020-05-15 10:06:39 -04:00
Frederik Seiffert
9f0d8d7720 Fix building Win32 classes with nonfragile ABI. 2020-05-13 18:08:35 +02:00
Gregory John Casamento
1a6a091fc4 Add set/get method for requiresSecureCoding 2020-05-13 02:29:53 -04:00
Gregory John Casamento
a0f50deb64 Fix fred's suggestions. Put guard and make more general method the one which is called. 2020-05-12 14:02:50 -04:00
Gregory John Casamento
be8980dfb4 Fix fred's suggestions. Put guard and make more general method the one which is called. 2020-05-12 14:01:44 -04:00
Gregory John Casamento
9d252bd5b6 Merge branch 'master' of github.com:gnustep/libs-base into NSSecureCoding_branch 2020-05-12 12:09:27 -04:00
Richard Frith-Macdonald
95b6f3a18e Casts to fix systems where the UCalendarDateFields enumeration is unsigned 2020-05-12 13:35:18 +01:00
rfm
57e4eba479
Merge branch 'master' into file_creation_date 2020-05-12 13:25:49 +01:00
rfm
50d1358028
Merge pull request #132 from niwatako/fix-exponent-validation-in-jsonserialization
Fix exponent validation in NSJSONSerialization
Buce fix ... thanks.
2020-05-12 13:23:29 +01:00
Gregory John Casamento
e294089032 Merge branch 'master' into NSSecureCoding_branch 2020-05-11 16:55:28 -04:00
Gregory John Casamento
4dc1c566c1 Send error back 2020-05-11 16:54:41 -04:00
rfm
6b008fc19e
Merge branch 'master' into android-nsinputstream-support 2020-05-11 15:02:05 +01:00
niwatako
dccd799256 Fix exponent validation 2020-05-11 21:46:25 +09:00
fredkiefer
e71c2f68fa * Source/NSISO8601DateFormatter.m,
* Source/NSOrthography.m: Clean up some compiler warnings.
2020-05-10 23:07:27 +02:00
fredkiefer
f4c5c519c2 * Source/NSXMLParser.m: Fix small bug in last commit that broke
all gui applications when there was a commented out section in the
user default XML file.
2020-05-08 21:59:28 +02:00
Richard Frith-Macdonald
5aab6f84cf Use RELEASE macro for memory management 2020-05-08 15:26:07 +01:00
Richard Frith-Macdonald
b26a2f49ea Convert to using indexes into a buffer 2020-05-08 15:05:17 +01:00
Gregory John Casamento
264811b3d0 Merge branch 'master' of github.com:gnustep/libs-base into NSSecureCoding_branch 2020-05-07 17:10:50 -04:00
Frederik Seiffert
b549dbbaec NSLocale improvements
Use "instancetype" for instance-returning methods. Fix method signature of -displayNameForKey:value:.
2020-05-07 15:30:36 +02:00
Richard Frith-Macdonald
6fc9449241 Reorganise to make the separation of the two parsers clearer. NSXMLParser is the sloppy parser and can be selected using the dummy subclass GSSloppyXMLParser while, if we have libxml2, we can specifically select the strict parser using the GSStrictXMLParser class. 2020-05-06 15:24:04 +01:00
rfm
ca2abf51f7
Merge pull request #130 from triplef/add-nsxmlparser-stream-support
Implement -[NSXMLParser initWithStream:].
2020-05-06 14:08:39 +01:00
Fred Kiefer
0b4f3b382a
Merge pull request #126 from alotorev/bugfix/NSURLComponents
Bugfix/nsurl components
2020-05-06 13:09:35 +02:00
Gregory John Casamento
e2ce929761 Merge branch 'master' of github.com:gnustep/libs-base into NSSecureCoding_branch 2020-05-06 05:04:45 -04:00
Frederik Seiffert
5dfda50d82 Implement -[NSXMLParser initWithStream:]. 2020-05-05 19:41:22 +02:00
Frederik Seiffert
547983738a Add NSInputStream support for reading Android assets from main bundle. 2020-05-05 15:42:10 +02:00
Richard Frith-Macdonald
dcfe2a2ce3 Fix -[NSCharacterSet invertedSet] to work by calling -invert on a mutable copy 2020-05-05 09:51:34 +01:00
Gregory John Casamento
76fac00cd2 Merge branch 'master' of github.com:gnustep/libs-base into NSSecureCoding_branch 2020-05-04 05:50:58 -04:00
Riccardo Mottola
bfcc2db53c In changeFileAttributes implement setting of creation date also for Unix, which needs to be done before setting the modification date. Also, implement reading the creation (birth time) date if a supported method was detected. 2020-05-04 10:17:25 +02:00
alotorev
4aa11f3e48 Improvements suggested by Fred Kiefer for the current pull request 2020-05-04 10:55:41 +03:00
alotorev
2a547271ad OSX like behaviour for NSURLQueryItem initialisers 2020-05-04 02:27:26 +03:00
alotorev
ce1c03f6da Fixed bugs leading to leaks, no autorelease in NSURLComponents factory methods. 2020-05-04 02:00:53 +03:00
alotorev
ec62905dd6 Fixed initialization NSURLComponents with NSURL, should treat a query from NSURL as a percent-encoded string. 2020-05-04 01:58:54 +03:00
niwatako
6869df9a50 Fix loss of buffer in NSJSONSerialization.
The first time bufferSize is extended, number loses the previously parsed characters.
After malloc the number, copy the numberBuffer to the number.
2020-05-01 23:51:55 +09:00
Riccardo Mottola
dfb4fc1976 fix log info 2020-05-01 02:06:00 +02:00
Riccardo Mottola
21c79c3500 Use utimensat() to set file modification date, if available. 2020-05-01 02:03:25 +02:00
Riccardo
e23ab3b394
Merge pull request #123 from gnustep/master
keep up with master
2020-04-30 11:14:10 +02:00
Richard Frith-Macdonald
0aeaee68da Fixup -stringByAddingPercentEncodingWithAllowedCharacters: to ignore membership
of the supplied set if the character is not in the ASCII range.
2020-04-27 20:25:24 +01:00
Richard Frith-Macdonald
9eb0fd4e1a Fix typo spotted by 'alotrev' 2020-04-27 09:14:36 +01:00
fredkiefer
a48694941c Add newer features for NSDateComponents and
started to clean up NSCalendar implementation.
2020-04-26 21:13:22 +02:00
fredkiefer
4fe6cb20a1 Started to rewrite NSCalendar to handle more components correctly. 2020-04-26 00:32:49 +02:00
fredkiefer
82e9ddc21f Add missing NSDateComponents methods. 2020-04-25 22:19:20 +02:00
Gregory John Casamento
082f87fbc3 Start implementing some secure coding methods. 2020-04-24 03:59:17 -04:00
Richard Frith-Macdonald
a9767cdff7 Override -hash and -isEqual: so that notifications with the name name, object, and userInfo are considered equal. This is the OSX behavior. 2020-04-21 09:16:53 +01:00
Richard Frith-Macdonald
05f442de8b Fix for NSURLResponse does not allow for multiple Set-Cookie headers in the same response #85 ... combine multiple header values as a comma separated list. 2020-04-16 23:04:37 +01:00
Richard Frith-Macdonald
6d714c8ee1 Fix for Deadlock in NSOperationQueue #49: If an exception occurs when trying to detach thread, catch it and log it so that locking is not broken by the exception breaking out of the lock protected region. 2020-04-16 22:48:25 +01:00
Richard Frith-Macdonald
6ee0cfff00 Add testcase for multiple clookies in a header. Fix error parsing a literal
string (writing nul terminator to read only memory)
2020-04-16 20:19:53 +01:00
Richard Frith-Macdonald
3d1e84f6fe rewrite code for separating individual cookies from a comma separated header so
it better matches what OSX does (and is hopefully a bit simpler)/
2020-04-16 19:39:32 +01:00
Richard Frith-Macdonald
132729e6e0 Add casts to avoid compiler warnings bout type of method 2020-04-15 10:40:41 +01:00
Richard Frith-Macdonald
09e9354f08 Fully type method implementatyion pointers. 2020-04-15 10:31:55 +01:00
Richard Frith-Macdonald
53f5957030 When building outside GNUstep (additions for apple), include the runtime
declarations and fix error in casting self.
2020-04-14 17:18:24 +01:00
Richard Frith-Macdonald
7829ab86b5 Fix line somehow missed from ast commit 2020-04-14 08:26:07 +01:00
Richard Frith-Macdonald
47ce8d3da7 Remove custom code for percent escaping and replace it with standard code using
custom charactersets.
2020-04-13 10:05:57 +01:00
Richard Frith-Macdonald
ccb8594bc0 Fix [NSURLProtocol -initWithRequest:cachedResponse:client:] to retain the client (up until the last message is sent to it) as OSX does. 2020-04-13 08:53:02 +01:00
Richard Frith-Macdonald
df1b6dd6d5 Characterset memory usage and code organisation consistency improvements. 2020-04-12 12:28:07 +01:00
Riccardo Mottola
ce313e1384 Implement read and set of File Creation Date attribute on Windows. 2020-04-09 23:43:41 +02:00
Frederik Seiffert
cc56c9cc97 Fixed NSOperation completion block memory mgmt. 2020-04-09 09:24:43 +02:00
Richard Frith-Macdonald
882b1419f5 remove redundant/repeated line 2020-04-05 10:27:02 +01:00
Richard Frith-Macdonald
ebaf23e295 Fix boundary error removing percent escapes 2020-04-05 10:26:28 +01:00
Fred Kiefer
adb67ee405
Merge pull request #118 from gnustep/fix-nsurlcomponents
fixups for setting/getting nil/empty query string values
2020-04-05 09:06:24 +02:00
Richard Frith-Macdonald
2a24e8d080 fixups for setting/getting nil/empty query string values 2020-04-04 22:37:40 +01:00
Gregory Casamento
a7867718b0
Merge pull request #115 from gnustep/fix-nsurlcomponents
Merging since all outstanding bugs appear to have been addressed.
2020-04-04 15:55:00 -04:00
fredkiefer
b0c763de36 Build the string instead of the URL.
Build the URL on the fly.
2020-04-04 20:33:55 +02:00
Richard Frith-Macdonald
ac45beb4c1 fix error in refactoring query (storing name twice rather than name/value) 2020-04-04 17:32:27 +01:00
Gregory John Casamento
cf13a7c21b Merge branch 'fix-nsurlcomponents' of github.com:gnustep/libs-base into fix-nsurlcomponents 2020-04-04 12:15:24 -04:00
Gregory John Casamento
213344d862 Add tests and modifications to pass them 2020-04-04 12:15:17 -04:00
Richard Frith-Macdonald
8eff23e780 Rewrite query handling code to try to mimic OSX documentation with regards to
the differences between setting nil/empty query strings/items and also in the
handling of query items with nothing before the '=', nothing after the '=',
and the case where there is no '=' character (also the totally empty case
where the query string contains a double ampersand (&&) sequence).
2020-04-04 15:13:14 +01:00
Gregory John Casamento
86276f0c7f Fix issue with scheme 2020-04-04 09:54:42 -04:00
Gregory John Casamento
564f61d572 Add tests for NSURLComponents 2020-04-04 09:44:22 -04:00
Richard Frith-Macdonald
4ffce48b04 I suggest when we regenerate we build the URL by appending to a mutable string
sas this would be hugely more efficient.
2020-04-04 14:22:25 +01:00
fredkiefer
d05b799740 Restore caching of URL.
Rewrite URL building to get the ranges correct.
Build URL with escaped components.
Build query from percentEncodedQueryItems.
2020-04-04 13:36:51 +02:00
Gregory John Casamento
ca6e48910a Minor fix to remove/add percent encoding to name portion of query item 2020-04-04 07:04:06 -04:00
Gregory John Casamento
5f1541d154 Always regenerate when we call [NSURLComponents URL] otherwise subsequent calls will return nil 2020-04-04 06:48:02 -04:00
Gregory John Casamento
b71f65f478 Fixes for FIXME's 2020-04-04 06:38:19 -04:00
Gregory John Casamento
d5c163397f Remove explicit reference to _url. Always regenerate when needed. 2020-04-03 17:39:35 -04:00
Gregory John Casamento
2d135069fb Remove query 2020-04-03 15:48:27 -04:00
fredkiefer
0bc1052bd6 Fix typo in last commit. 2020-04-03 18:37:55 +02:00
fredkiefer
c170c8c1e7 Correct more issues and flag the remaining ones with "FIXME". 2020-04-03 18:15:07 +02:00
fredkiefer
181346c568 Get too compile with gcc.
Address some pull request comments.
2020-04-03 17:53:34 +02:00
Gregory John Casamento
14274bffd2 Fix issues pointed out by fred k. 2020-04-02 06:08:17 -04:00
Gregory John Casamento
fd354f4167 Changes to fix issues pointed out by Fred and RFM 2020-04-01 10:08:44 -04:00
Gregory John Casamento
bc614d4bd8 Regenerate in one place. 2020-04-01 08:48:51 -04:00
Gregory John Casamento
b594d047c1 Fix issues with regeneration. 2020-04-01 08:46:45 -04:00
Gregory John Casamento
4dff7a76a9 Refactor regeneration of URL. 2020-04-01 08:00:26 -04:00
Gregory John Casamento
f6940daac9 Add code to allow percent coded set/get methods to reflect the values set by the non-encoded versions 2020-03-31 05:07:38 -04:00
Gregory John Casamento
2fb63480be Remove slash 2020-03-30 09:24:18 -04:00
Gregory John Casamento
7c52cd9f72 Added method to handle query encoding. Theoretically URLQueryAllowedCharacter set should cover this. I'm wondering why I had to do this to get the correct result. 2020-03-30 08:53:42 -04:00
Richard Frith-Macdonald
bf440e83fa fixup indentation etc to conform to coding stype 2020-03-30 13:35:35 +01:00
Gregory John Casamento
31e7bbb7e6 Get rid of trailing whitespace. 2020-03-30 06:58:10 -04:00
Gregory John Casamento
a92491268b URL percent escape query items. 2020-03-30 06:52:34 -04:00
Gregory John Casamento
7fc9033aa8 Fix for case where password is not specified. Conformation to RFC1738. 2020-03-30 04:58:51 -04:00
Gregory John Casamento
7e75310531 Build query items, fix rendering of URL when user/password are not specified together. 2020-03-30 04:37:36 -04:00
Gregory John Casamento
5db21d0a83 Merge branch 'master' into fix-nsurlcomponents 2020-03-29 11:35:59 -04:00
rfm
da6be9daac
Merge branch 'master' into fix-pthread-setname 2020-03-29 11:33:39 +01:00
rfm
73baca1056
Merge branch 'master' into fix-nsurlresponse 2020-03-29 11:30:18 +01:00
rfm
81d70b37c8
Merge branch 'master' into numerical_locale 2020-03-29 11:26:40 +01:00
Gregory John Casamento
a785456d5f Copy URL 2020-03-28 03:13:36 -04:00
Gregory John Casamento
bda473e9bd Remove set for percent escapes in setURL: 2020-03-27 07:06:20 -04:00
Gregory John Casamento
746d3ea8ae Remove infinite recursion 2020-03-27 06:18:11 -04:00
Gregory John Casamento
5bf97288d0 remove variable 2020-03-27 05:58:10 -04:00
Gregory John Casamento
6fb90273fe Update implementation 2020-03-27 05:51:07 -04:00
Gregory John Casamento
7019e849cc Add method to update url when any set method is called 2020-03-27 04:30:13 -04:00
Fred Kiefer
77468b0b9e
Merge branch 'master' into fix-nsurlresponse 2020-03-26 18:46:33 +01:00
Gregory John Casamento
56f0d5aa8b Merge branch 'fix-nsurlcomponents' of github.com:gnustep/libs-base into fix-nsurlcomponents 2020-03-26 09:28:53 -04:00
Frederik Seiffert
5f9982812e Added NSErrorDomain typedef. 2020-03-26 14:16:44 +01:00
Frederik Seiffert
8774e5f55d NSURLComponents fixes
- Moved NSURLComponents internal declaration to correct place.
- Added GS_DESTROY_INTERNAL() calls for NSURLComponents and NSURLQueryItem.
2020-03-23 14:46:45 +01:00
Frederik Seiffert
8e093a519e Added misssing GSInternal declaration for NSURLQueryItem. 2020-03-23 13:40:09 +01:00
Frederik Seiffert
a0779f4e62 Fixed internal ivar usage for NSURLQueryItem. 2020-03-23 11:56:20 +01:00
Frederik Seiffert
a3b8ea0937 Use pthread_setname_np result instead of errno.
Fixes setting thread name on platforms where errno is not set.
2020-03-17 14:49:02 +01:00
Gregory John Casamento
fdb8c95a17 Merge branch 'master' of github.com:gnustep/libs-base into fix-nsurlcomponents 2020-03-13 05:22:17 -04:00
fredkiefer
95abcbd694 * Source/NSURL.m: Fix compiler warnigns.
* Headers/Foundation/NSLocale.h,
* Source/NSLocale.m: Add a few convenience methods from MacOS 10.12.
2020-03-12 14:58:46 +01:00
Frederik Seiffert
5150ab1d5a Fixed parsing of NSURLResponse content type header. 2020-03-12 11:44:13 +01:00
Frederik Seiffert
3743e1d643 Added missing NSURLQueryItem implementation. 2020-03-11 10:55:10 +01:00
Richard Frith-Macdonald
4a7325b00e Merge branch 'master' of ssh://github.com/gnustep/libs-base
Conflicts:
	Source/GSAttributedString.m
2020-03-11 09:05:44 +00:00
Richard Frith-Macdonald
e4ea6672df Add comments to note that initial values are unused. 2020-03-11 09:01:39 +00:00
rfm
9ff3af1ead
Merge pull request #111 from triplef/fix-attributed-string-ranges
Fixed attributed string range initialization.
2020-03-11 08:58:37 +00:00
Frederik Seiffert
15610acb62 Fixed attributed string range initialization. 2020-03-10 18:09:44 +01:00