Commit graph

7872 commits

Author SHA1 Message Date
Richard Frith-Macdonald
dcfe2a2ce3 Fix -[NSCharacterSet invertedSet] to work by calling -invert on a mutable copy 2020-05-05 09:51:34 +01:00
niwatako
6869df9a50 Fix loss of buffer in NSJSONSerialization.
The first time bufferSize is extended, number loses the previously parsed characters.
After malloc the number, copy the numberBuffer to the number.
2020-05-01 23:51:55 +09:00
Richard Frith-Macdonald
0aeaee68da Fixup -stringByAddingPercentEncodingWithAllowedCharacters: to ignore membership
of the supplied set if the character is not in the ASCII range.
2020-04-27 20:25:24 +01:00
Richard Frith-Macdonald
9eb0fd4e1a Fix typo spotted by 'alotrev' 2020-04-27 09:14:36 +01:00
fredkiefer
a48694941c Add newer features for NSDateComponents and
started to clean up NSCalendar implementation.
2020-04-26 21:13:22 +02:00
fredkiefer
4fe6cb20a1 Started to rewrite NSCalendar to handle more components correctly. 2020-04-26 00:32:49 +02:00
fredkiefer
82e9ddc21f Add missing NSDateComponents methods. 2020-04-25 22:19:20 +02:00
Richard Frith-Macdonald
a9767cdff7 Override -hash and -isEqual: so that notifications with the name name, object, and userInfo are considered equal. This is the OSX behavior. 2020-04-21 09:16:53 +01:00
Richard Frith-Macdonald
05f442de8b Fix for NSURLResponse does not allow for multiple Set-Cookie headers in the same response #85 ... combine multiple header values as a comma separated list. 2020-04-16 23:04:37 +01:00
Richard Frith-Macdonald
6d714c8ee1 Fix for Deadlock in NSOperationQueue #49: If an exception occurs when trying to detach thread, catch it and log it so that locking is not broken by the exception breaking out of the lock protected region. 2020-04-16 22:48:25 +01:00
Richard Frith-Macdonald
6ee0cfff00 Add testcase for multiple clookies in a header. Fix error parsing a literal
string (writing nul terminator to read only memory)
2020-04-16 20:19:53 +01:00
Richard Frith-Macdonald
3d1e84f6fe rewrite code for separating individual cookies from a comma separated header so
it better matches what OSX does (and is hopefully a bit simpler)/
2020-04-16 19:39:32 +01:00
Richard Frith-Macdonald
132729e6e0 Add casts to avoid compiler warnings bout type of method 2020-04-15 10:40:41 +01:00
Richard Frith-Macdonald
09e9354f08 Fully type method implementatyion pointers. 2020-04-15 10:31:55 +01:00
Richard Frith-Macdonald
53f5957030 When building outside GNUstep (additions for apple), include the runtime
declarations and fix error in casting self.
2020-04-14 17:18:24 +01:00
Richard Frith-Macdonald
7829ab86b5 Fix line somehow missed from ast commit 2020-04-14 08:26:07 +01:00
Richard Frith-Macdonald
47ce8d3da7 Remove custom code for percent escaping and replace it with standard code using
custom charactersets.
2020-04-13 10:05:57 +01:00
Richard Frith-Macdonald
ccb8594bc0 Fix [NSURLProtocol -initWithRequest:cachedResponse:client:] to retain the client (up until the last message is sent to it) as OSX does. 2020-04-13 08:53:02 +01:00
Richard Frith-Macdonald
df1b6dd6d5 Characterset memory usage and code organisation consistency improvements. 2020-04-12 12:28:07 +01:00
Frederik Seiffert
cc56c9cc97 Fixed NSOperation completion block memory mgmt. 2020-04-09 09:24:43 +02:00
Richard Frith-Macdonald
882b1419f5 remove redundant/repeated line 2020-04-05 10:27:02 +01:00
Richard Frith-Macdonald
ebaf23e295 Fix boundary error removing percent escapes 2020-04-05 10:26:28 +01:00
Fred Kiefer
adb67ee405
Merge pull request #118 from gnustep/fix-nsurlcomponents
fixups for setting/getting nil/empty query string values
2020-04-05 09:06:24 +02:00
Richard Frith-Macdonald
2a24e8d080 fixups for setting/getting nil/empty query string values 2020-04-04 22:37:40 +01:00
Gregory Casamento
a7867718b0
Merge pull request #115 from gnustep/fix-nsurlcomponents
Merging since all outstanding bugs appear to have been addressed.
2020-04-04 15:55:00 -04:00
fredkiefer
b0c763de36 Build the string instead of the URL.
Build the URL on the fly.
2020-04-04 20:33:55 +02:00
Richard Frith-Macdonald
ac45beb4c1 fix error in refactoring query (storing name twice rather than name/value) 2020-04-04 17:32:27 +01:00
Gregory John Casamento
cf13a7c21b Merge branch 'fix-nsurlcomponents' of github.com:gnustep/libs-base into fix-nsurlcomponents 2020-04-04 12:15:24 -04:00
Gregory John Casamento
213344d862 Add tests and modifications to pass them 2020-04-04 12:15:17 -04:00
Richard Frith-Macdonald
8eff23e780 Rewrite query handling code to try to mimic OSX documentation with regards to
the differences between setting nil/empty query strings/items and also in the
handling of query items with nothing before the '=', nothing after the '=',
and the case where there is no '=' character (also the totally empty case
where the query string contains a double ampersand (&&) sequence).
2020-04-04 15:13:14 +01:00
Gregory John Casamento
86276f0c7f Fix issue with scheme 2020-04-04 09:54:42 -04:00
Gregory John Casamento
564f61d572 Add tests for NSURLComponents 2020-04-04 09:44:22 -04:00
Richard Frith-Macdonald
4ffce48b04 I suggest when we regenerate we build the URL by appending to a mutable string
sas this would be hugely more efficient.
2020-04-04 14:22:25 +01:00
fredkiefer
d05b799740 Restore caching of URL.
Rewrite URL building to get the ranges correct.
Build URL with escaped components.
Build query from percentEncodedQueryItems.
2020-04-04 13:36:51 +02:00
Gregory John Casamento
ca6e48910a Minor fix to remove/add percent encoding to name portion of query item 2020-04-04 07:04:06 -04:00
Gregory John Casamento
5f1541d154 Always regenerate when we call [NSURLComponents URL] otherwise subsequent calls will return nil 2020-04-04 06:48:02 -04:00
Gregory John Casamento
b71f65f478 Fixes for FIXME's 2020-04-04 06:38:19 -04:00
Gregory John Casamento
d5c163397f Remove explicit reference to _url. Always regenerate when needed. 2020-04-03 17:39:35 -04:00
Gregory John Casamento
2d135069fb Remove query 2020-04-03 15:48:27 -04:00
fredkiefer
0bc1052bd6 Fix typo in last commit. 2020-04-03 18:37:55 +02:00
fredkiefer
c170c8c1e7 Correct more issues and flag the remaining ones with "FIXME". 2020-04-03 18:15:07 +02:00
fredkiefer
181346c568 Get too compile with gcc.
Address some pull request comments.
2020-04-03 17:53:34 +02:00
Gregory John Casamento
14274bffd2 Fix issues pointed out by fred k. 2020-04-02 06:08:17 -04:00
Gregory John Casamento
fd354f4167 Changes to fix issues pointed out by Fred and RFM 2020-04-01 10:08:44 -04:00
Gregory John Casamento
bc614d4bd8 Regenerate in one place. 2020-04-01 08:48:51 -04:00
Gregory John Casamento
b594d047c1 Fix issues with regeneration. 2020-04-01 08:46:45 -04:00
Gregory John Casamento
4dff7a76a9 Refactor regeneration of URL. 2020-04-01 08:00:26 -04:00
Gregory John Casamento
f6940daac9 Add code to allow percent coded set/get methods to reflect the values set by the non-encoded versions 2020-03-31 05:07:38 -04:00
Gregory John Casamento
2fb63480be Remove slash 2020-03-30 09:24:18 -04:00
Gregory John Casamento
7c52cd9f72 Added method to handle query encoding. Theoretically URLQueryAllowedCharacter set should cover this. I'm wondering why I had to do this to get the correct result. 2020-03-30 08:53:42 -04:00