Commit graph

10795 commits

Author SHA1 Message Date
fredkiefer
b8f8d6a617 Speed up lookup for GSOrderedSet by using a map. 2019-06-28 17:20:21 +02:00
fredkiefer
2a810e5bd9 Further simplification of code.
More formatting.
Delegate description to NSArray.
Remove unneeded method once more.
Remove all objects from the end not from the beginning.
Remove strange range check.
Implement missing sort method by reusing existing code.
2019-06-28 16:53:48 +02:00
Gregory John Casamento
b4f0e75375 Simplify removeObjectsAtIndexes: 2019-06-28 02:54:57 -04:00
Gregory John Casamento
80843a9e4b Merged changes from other author 2019-06-28 01:55:33 -04:00
Gregory John Casamento
a5ba66b3ce Simplify _removeObjectAtIndexes:count: method to not sort and thus make it faster 2019-06-28 01:50:54 -04:00
fredkiefer
05233e64d6 Remove broken test. This code gave a bad access exception when run on a Mac. 2019-06-27 19:02:03 +02:00
fredkiefer
7feb7be03a Remove unused variables. 2019-06-27 16:21:34 +02:00
fredkiefer
8c10d1848e Remove log statement accidentialy left over. 2019-06-27 16:17:26 +02:00
fredkiefer
eff6575d9f Add test for isSubsetOfSet: and correct implementation to fit the test. 2019-06-27 15:26:01 +02:00
fredkiefer
ff675b2e78 Format the test code. 2019-06-27 15:10:14 +02:00
fredkiefer
3004e91330 Move some more methods from the concrete to the abstract class.
Move the _raiseRangeExceptionWithIndex:from: method the class
it is declared on.
Simplify the code.
2019-06-27 15:03:23 +02:00
fredkiefer
cbe54c4073 Remove commented out code. 2019-06-27 14:29:01 +02:00
fredkiefer
e67971346a Merge branch 'add_nsorderedset_classcluster' of github.com:gnustep/libs-base into add_nsorderedset_classcluster 2019-06-27 14:20:58 +02:00
fredkiefer
ce3c4ae882 Format according to GNUstep coding style. 2019-06-27 14:20:19 +02:00
fredkiefer
5b169f55b5 Correct retain/release handling for GSIArray 2019-06-27 14:19:37 +02:00
fredkiefer
5c6139af07 Correct retain/release handling for GSIArray 2019-06-27 13:56:27 +02:00
Gregory John Casamento
1c83220356 Made replaceObjectsAtIndexes:... more efficient 2019-06-27 04:57:25 -04:00
Gregory John Casamento
e2d3e67f16 Fixing comments by fred 2019-06-27 02:00:14 -04:00
Gregory John Casamento
ef438f7697 Minor cleanup of white space and header documentation. 2019-06-19 00:14:03 -04:00
Gregory John Casamento
39465cb904 Further simplify. Exception should also be thrown in only one place 2019-06-19 00:10:20 -04:00
Gregory John Casamento
d826bb5a25 Reduce repetitive implementation of the same algorithm in the code. Make sure that insertion happens in one method only 2019-06-18 22:07:11 -04:00
Gregory John Casamento
f2ba8a3093 Add macos archive test 2019-06-17 20:00:50 -04:00
Gregory John Casamento
353aa6c8e5 Remove white space 2019-06-17 12:15:26 -04:00
Gregory John Casamento
d20efecead Add check for nil. Force use of subclass init methods 2019-06-17 11:57:18 -04:00
Gregory John Casamento
4edcc3f697 Fix #define issues. 2019-06-13 18:58:50 -04:00
Gregory John Casamento
7799824de6 Fix issues suggested by fred 2019-06-13 18:17:01 -04:00
Gregory John Casamento
9f4a5c80ed Add exceptions to KVO methods for now 2019-06-13 07:37:31 -04:00
Gregory John Casamento
3278eaa2ca Add new test, fix replaceObjectsAtIndexes:withObjects: 2019-06-13 06:00:40 -04:00
Gregory John Casamento
0a2f885456 Reimplement some methods to fix some issues. 2019-06-12 11:23:33 -04:00
Gregory John Casamento
6ad1e47ab7 Fix issue with move method 2019-06-12 08:21:32 -04:00
Gregory John Casamento
abe0ee3d3d Move containsObject: to NSOrderedSet.m. Make additional changes to fix issues pointed out by Fred 2019-06-11 05:45:37 -04:00
Gregory John Casamento
c131f7ec34 More fixes suggested by fred 2019-06-10 15:25:11 -04:00
Gregory John Casamento
561f63c818 More fixes suggested by fred 2019-06-10 15:24:18 -04:00
Gregory John Casamento
ad5790b9e5 Move methods to abstract class. Implement setValue:... 2019-06-10 14:15:41 -04:00
Gregory John Casamento
268b2203c7 Correct issues brought up by Fred K. 2019-06-10 13:55:00 -04:00
Gregory John Casamento
d66ad25b50 Release objects 2019-06-10 11:02:48 -04:00
Gregory John Casamento
30aea6e5ad Fix use range instead of count to save memory 2019-06-10 10:55:06 -04:00
Gregory John Casamento
966c31f43d Fix a number of comments by Fred 2019-06-10 10:20:26 -04:00
Gregory John Casamento
d8030311d0 Fix issue with isSubsetOfOrderedSet:. Objects must be in the same order for the set to be considered a subset. 2019-06-09 15:31:07 -04:00
Gregory John Casamento
c53336b29e Add new tests 2019-06-09 14:53:06 -04:00
Gregory John Casamento
f8994e1049 New tests and corrected code for NSOrderedSet/NSMutableOrderedSet. Submitting for review. 2019-06-09 07:17:57 -04:00
Gregory John Casamento
d59a90206a Finish NSDIctionary changes 2019-06-08 09:53:39 -04:00
Gregory John Casamento
e44bdf6718 Fix memory issue with initWithObjects:... Rudimentary test now passing 2019-06-08 09:38:14 -04:00
Gregory John Casamento
48cf585c46 Rudimentary NSOrderedSet tests 2019-06-08 08:56:18 -04:00
Gregory John Casamento
372030f056 Code complete implementation. No tests yet 2019-06-08 08:41:45 -04:00
Gregory John Casamento
c4345dc19a Clean compilation with GSIArray backing concrete class 2019-06-08 08:07:17 -04:00
Gregory John Casamento
52e87bce81 Complete implementation of abstract class 2019-06-08 03:59:32 -04:00
Gregory John Casamento
f878243678 Sorting routines 2019-06-07 22:43:40 -04:00
Gregory John Casamento
2dccb2eee6 Add implementation of array and set methods. 2019-06-07 22:39:51 -04:00
Gregory John Casamento
bb6f7ceed8 Implement filteredOrderedSetUserPredicate 2019-06-07 12:57:08 -04:00