Commit graph

8337 commits

Author SHA1 Message Date
David Chisnall
730ecc942f Don't expand symlinks when standardizing paths (OS X doesn't).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32109 72102866-910b-0410-8b05-ffd578937521
2011-02-12 18:02:04 +00:00
Richard Frith-MacDonald
d11a6d8c27 remove redundant code
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32108 72102866-910b-0410-8b05-ffd578937521
2011-02-12 17:26:10 +00:00
Richard Frith-MacDonald
56fe3ad777 Try to make code more robust and comment copiously.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32107 72102866-910b-0410-8b05-ffd578937521
2011-02-12 16:33:40 +00:00
Richard Frith-MacDonald
f7e7ef50c3 Don't call [NSZombie+class] as the method doesn't exist.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32105 72102866-910b-0410-8b05-ffd578937521
2011-02-12 15:44:00 +00:00
Richard Frith-MacDonald
d060289f36 Annotate uniquing for static analyzer
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32095 72102866-910b-0410-8b05-ffd578937521
2011-02-12 10:29:11 +00:00
Richard Frith-MacDonald
78009cfe59 fix typo
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32094 72102866-910b-0410-8b05-ffd578937521
2011-02-12 09:02:37 +00:00
Richard Frith-MacDonald
7047f9e6d4 more changes to avoid leak warnings
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32093 72102866-910b-0410-8b05-ffd578937521
2011-02-12 09:00:18 +00:00
Richard Frith-MacDonald
8d5395f884 tweak
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32091 72102866-910b-0410-8b05-ffd578937521
2011-02-12 06:57:06 +00:00
Richard Frith-MacDonald
705e1a32ca Attempts to prevent leak warnings from static analyser
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32090 72102866-910b-0410-8b05-ffd578937521
2011-02-12 06:51:42 +00:00
Richard Frith-MacDonald
11e6f51bf4 remove unused code
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32089 72102866-910b-0410-8b05-ffd578937521
2011-02-12 06:12:39 +00:00
Richard Frith-MacDonald
0c1f27b2c2 add note on progress
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32088 72102866-910b-0410-8b05-ffd578937521
2011-02-12 05:57:22 +00:00
Richard Frith-MacDonald
5d6acf61f5 replace lost config for ICU
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32087 72102866-910b-0410-8b05-ffd578937521
2011-02-11 20:41:10 +00:00
Richard Frith-MacDonald
b36fbab52f Avoid some locking
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32086 72102866-910b-0410-8b05-ffd578937521
2011-02-11 19:08:32 +00:00
Richard Frith-MacDonald
992b57e83b Fix major mamory corruption problem.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32085 72102866-910b-0410-8b05-ffd578937521
2011-02-11 18:53:24 +00:00
Richard Frith-MacDonald
6f4f708a6f Reduce internal class interdependency for improved maintainability.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32083 72102866-910b-0410-8b05-ffd578937521
2011-02-11 16:04:05 +00:00
Richard Frith-MacDonald
7dcf69abbb Recommit
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32082 72102866-910b-0410-8b05-ffd578937521
2011-02-11 15:49:41 +00:00
Richard Frith-MacDonald
d3f23b5057 Recommit NSUnarchiver.m (now tested), revert recently broken NSPropertyList.m to working version again.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32081 72102866-910b-0410-8b05-ffd578937521
2011-02-11 15:43:43 +00:00
David Chisnall
cd09e6bf87 Remove redundant copy + leak in NSArray.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32080 72102866-910b-0410-8b05-ffd578937521
2011-02-11 15:13:48 +00:00
David Chisnall
511ac3219d Ensure that an IMP in NSPropertyList is always initialised before it's called.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32079 72102866-910b-0410-8b05-ffd578937521
2011-02-11 15:12:13 +00:00
David Chisnall
4d47a08f1d Another case of the bug fixed in r32066.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32078 72102866-910b-0410-8b05-ffd578937521
2011-02-11 15:09:14 +00:00
David Chisnall
104c14bbf1 Silence some warnings caused by returning the result of a method that doesn't return.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32077 72102866-910b-0410-8b05-ffd578937521
2011-02-11 14:51:47 +00:00
David Chisnall
9e6401bbdf Annotate the exception-throwing methods in NSObject Additions as not returning.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32076 72102866-910b-0410-8b05-ffd578937521
2011-02-11 14:38:09 +00:00
Richard Frith-MacDonald
60885954c6 Recommit tested changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32075 72102866-910b-0410-8b05-ffd578937521
2011-02-11 14:31:25 +00:00
Richard Frith-MacDonald
51cf9b9cf9 Reapply some changes with modifications
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32074 72102866-910b-0410-8b05-ffd578937521
2011-02-11 14:07:49 +00:00
Richard Frith-MacDonald
336c7bf021 Revert back to working code!
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32072 72102866-910b-0410-8b05-ffd578937521
2011-02-11 13:53:54 +00:00
Richard Frith-MacDonald
f3f69cccc2 get things to compile again
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32071 72102866-910b-0410-8b05-ffd578937521
2011-02-11 13:05:48 +00:00
David Chisnall
a67ed22c01 Remove a lock that is protecting thread-local storage. Stop leaking NSThread objects that are stored in thread-local storage.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32070 72102866-910b-0410-8b05-ffd578937521
2011-02-11 12:54:59 +00:00
Richard Frith-MacDonald
2a1389023f revert last
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32069 72102866-910b-0410-8b05-ffd578937521
2011-02-11 12:43:47 +00:00
David Chisnall
20d95085f5 Fix release of the wrong object in NSCache.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32068 72102866-910b-0410-8b05-ffd578937521
2011-02-11 12:42:59 +00:00
David Chisnall
8b241428d7 Fix memory leak in NSCache.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32067 72102866-910b-0410-8b05-ffd578937521
2011-02-11 12:40:46 +00:00
David Chisnall
dd88a65f4a Fix nonsense use of libicu, spotted by the analyser, with a not-so-helpful warning (he status pointer passed in to icu functions MUST be initialised to 0, because the ICU functions test it as well as setting it so you can call a load of ICU functions with the same status flag and not wrap them all in tests).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32066 72102866-910b-0410-8b05-ffd578937521
2011-02-11 12:39:01 +00:00
David Chisnall
940adacf2d Add some asserts to NSMethodSignature to make the analyser happy.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32065 72102866-910b-0410-8b05-ffd578937521
2011-02-11 12:36:40 +00:00
Richard Frith-MacDonald
7a7efb3484 temporarily revert to get code to compile again.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32064 72102866-910b-0410-8b05-ffd578937521
2011-02-11 12:29:50 +00:00
Richard Frith-MacDonald
0870dec426 leak fix
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32063 72102866-910b-0410-8b05-ffd578937521
2011-02-11 12:25:20 +00:00
David Chisnall
ef600d4917 Make NSPropertyList.m use the temporary buffer macros, instead of reimplementing them.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32062 72102866-910b-0410-8b05-ffd578937521
2011-02-11 12:21:09 +00:00
David Chisnall
45c20425df Added assert in NSKeyValueObserving to suppress analyser warning.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32061 72102866-910b-0410-8b05-ffd578937521
2011-02-11 12:16:39 +00:00
David Chisnall
fe79a1f2a5 Added ChangeLog entry from last commit
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32060 72102866-910b-0410-8b05-ffd578937521
2011-02-11 12:07:15 +00:00
David Chisnall
fa8afdc28a Added exception-safe version of the GS_BEGINITEMBUF() macro. As a side effect, this should silence the zero-sized VLA warnings in the static analyser.
Note: This macro is currently only used on GCC 4+ and clang.  It depends on __attribute__((cleanup)), which was introduced some time in the 3.x series, but I'm not sure exactly when (3.2 / 3.3 I think), so someone who cares about gcc 3.x can tweak this if they want (not sure if anyone does - I think most people use 2.95, 4.x, or clang).



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32059 72102866-910b-0410-8b05-ffd578937521
2011-02-11 12:06:25 +00:00
Richard Frith-MacDonald
d81ac8a945 further tweaks
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32058 72102866-910b-0410-8b05-ffd578937521
2011-02-11 11:45:07 +00:00
David Chisnall
d935a085f8 Initialise a variable with the value that's actually used first, not a placeholder value.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32057 72102866-910b-0410-8b05-ffd578937521
2011-02-11 11:35:04 +00:00
David Chisnall
c8c35018b6 Remove redundant dictionary lookup (result never used) in AGSParser.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32056 72102866-910b-0410-8b05-ffd578937521
2011-02-11 11:33:37 +00:00
David Chisnall
acf11e142d Fix NSEnumerationReverse in the other place where this bug was pasted. I must have been asleep or drunk when I wrote this method.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32055 72102866-910b-0410-8b05-ffd578937521
2011-02-11 11:31:41 +00:00
David Chisnall
8c06de29c6 Fix [NSArray -indexesOfObjectsWithOptions:passingTest:] with NSEnumerationReverse option. Was doing forward iteration in all cases.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32054 72102866-910b-0410-8b05-ffd578937521
2011-02-11 11:29:34 +00:00
David Chisnall
887f25cb5b Remove some redundant arithmetic (l - 0).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32053 72102866-910b-0410-8b05-ffd578937521
2011-02-11 11:09:55 +00:00
David Chisnall
1e886a2b5a Removed redundant code line spotted by analyser - looks like copy-and-paste bug from line 1192 (line 1200 was always replacing the value stored by 1199).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32052 72102866-910b-0410-8b05-ffd578937521
2011-02-11 11:06:25 +00:00
Richard Frith-MacDonald
594a654252 NSZombie fixups
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32051 72102866-910b-0410-8b05-ffd578937521
2011-02-11 10:00:00 +00:00
Richard Frith-MacDonald
37f65fb873 fix bad commit
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32050 72102866-910b-0410-8b05-ffd578937521
2011-02-11 09:36:38 +00:00
Richard Frith-MacDonald
9eb046056c tweaks for clang static analyser warningS
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32048 72102866-910b-0410-8b05-ffd578937521
2011-02-11 09:02:33 +00:00
Richard Frith-MacDonald
7deeb174a4 revert
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32047 72102866-910b-0410-8b05-ffd578937521
2011-02-11 07:22:23 +00:00
Stefan Bidigaray
360d24cda1 Avoid unnecessary memory copying.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32046 72102866-910b-0410-8b05-ffd578937521
2011-02-11 04:06:00 +00:00