Richard Frith-Macdonald
2a24e8d080
fixups for setting/getting nil/empty query string values
2020-04-04 22:37:40 +01:00
Gregory Casamento
a7867718b0
Merge pull request #115 from gnustep/fix-nsurlcomponents
...
Merging since all outstanding bugs appear to have been addressed.
2020-04-04 15:55:00 -04:00
fredkiefer
b0c763de36
Build the string instead of the URL.
...
Build the URL on the fly.
2020-04-04 20:33:55 +02:00
Gregory John Casamento
bc0be86d46
Merge branch 'fix-nsurlcomponents' of github.com:gnustep/libs-base into fix-nsurlcomponents
2020-04-04 12:34:21 -04:00
Gregory John Casamento
d691df9cbf
Fix error in test compilation
2020-04-04 12:34:15 -04:00
Richard Frith-Macdonald
ac45beb4c1
fix error in refactoring query (storing name twice rather than name/value)
2020-04-04 17:32:27 +01:00
Gregory John Casamento
cf13a7c21b
Merge branch 'fix-nsurlcomponents' of github.com:gnustep/libs-base into fix-nsurlcomponents
2020-04-04 12:15:24 -04:00
Gregory John Casamento
213344d862
Add tests and modifications to pass them
2020-04-04 12:15:17 -04:00
Richard Frith-Macdonald
8eff23e780
Rewrite query handling code to try to mimic OSX documentation with regards to
...
the differences between setting nil/empty query strings/items and also in the
handling of query items with nothing before the '=', nothing after the '=',
and the case where there is no '=' character (also the totally empty case
where the query string contains a double ampersand (&&) sequence).
2020-04-04 15:13:14 +01:00
Gregory John Casamento
86276f0c7f
Fix issue with scheme
2020-04-04 09:54:42 -04:00
Gregory John Casamento
564f61d572
Add tests for NSURLComponents
2020-04-04 09:44:22 -04:00
Richard Frith-Macdonald
4ffce48b04
I suggest when we regenerate we build the URL by appending to a mutable string
...
sas this would be hugely more efficient.
2020-04-04 14:22:25 +01:00
fredkiefer
d05b799740
Restore caching of URL.
...
Rewrite URL building to get the ranges correct.
Build URL with escaped components.
Build query from percentEncodedQueryItems.
2020-04-04 13:36:51 +02:00
Gregory John Casamento
ca6e48910a
Minor fix to remove/add percent encoding to name portion of query item
2020-04-04 07:04:06 -04:00
Gregory John Casamento
5f1541d154
Always regenerate when we call [NSURLComponents URL] otherwise subsequent calls will return nil
2020-04-04 06:48:02 -04:00
Gregory John Casamento
b71f65f478
Fixes for FIXME's
2020-04-04 06:38:19 -04:00
Gregory John Casamento
d5c163397f
Remove explicit reference to _url. Always regenerate when needed.
2020-04-03 17:39:35 -04:00
Gregory John Casamento
2d135069fb
Remove query
2020-04-03 15:48:27 -04:00
fredkiefer
0bc1052bd6
Fix typo in last commit.
2020-04-03 18:37:55 +02:00
fredkiefer
c170c8c1e7
Correct more issues and flag the remaining ones with "FIXME".
2020-04-03 18:15:07 +02:00
fredkiefer
181346c568
Get too compile with gcc.
...
Address some pull request comments.
2020-04-03 17:53:34 +02:00
Gregory John Casamento
20745f34bc
Move MISSING file to root of base.
2020-04-02 06:21:48 -04:00
Gregory John Casamento
14274bffd2
Fix issues pointed out by fred k.
2020-04-02 06:08:17 -04:00
Gregory John Casamento
fd354f4167
Changes to fix issues pointed out by Fred and RFM
2020-04-01 10:08:44 -04:00
Gregory John Casamento
bc614d4bd8
Regenerate in one place.
2020-04-01 08:48:51 -04:00
Gregory John Casamento
b594d047c1
Fix issues with regeneration.
2020-04-01 08:46:45 -04:00
Gregory John Casamento
4dff7a76a9
Refactor regeneration of URL.
2020-04-01 08:00:26 -04:00
Gregory John Casamento
f6940daac9
Add code to allow percent coded set/get methods to reflect the values set by the non-encoded versions
2020-03-31 05:07:38 -04:00
Mingye Wang
8b46d8d042
NSPropertyList+PLUtil: add missing headers, fix nil/id warning
...
My old GNUStep environment got wiped due to some improper Windows and UEFI monkeying. Please excuse the slow progress for a while.
2020-03-31 06:33:09 +08:00
Gregory John Casamento
2fb63480be
Remove slash
2020-03-30 09:24:18 -04:00
Gregory John Casamento
7c52cd9f72
Added method to handle query encoding. Theoretically URLQueryAllowedCharacter set should cover this. I'm wondering why I had to do this to get the correct result.
2020-03-30 08:53:42 -04:00
Richard Frith-Macdonald
bf440e83fa
fixup indentation etc to conform to coding stype
2020-03-30 13:35:35 +01:00
Gregory John Casamento
31e7bbb7e6
Get rid of trailing whitespace.
2020-03-30 06:58:10 -04:00
Gregory John Casamento
a92491268b
URL percent escape query items.
2020-03-30 06:52:34 -04:00
Gregory John Casamento
21036dd695
Add change from master for NSObjCRuntime.
2020-03-30 05:16:37 -04:00
Gregory John Casamento
7fc9033aa8
Fix for case where password is not specified. Conformation to RFC1738.
2020-03-30 04:58:51 -04:00
Gregory John Casamento
7e75310531
Build query items, fix rendering of URL when user/password are not specified together.
2020-03-30 04:37:36 -04:00
Gregory John Casamento
5db21d0a83
Merge branch 'master' into fix-nsurlcomponents
2020-03-29 11:35:59 -04:00
rfm
2dae7185f4
Merge pull request #113 from triplef/fix-pthread-setname
...
Use pthread_setname_np result instead of errno.
2020-03-29 11:33:49 +01:00
rfm
da6be9daac
Merge branch 'master' into fix-pthread-setname
2020-03-29 11:33:39 +01:00
rfm
600ce6da89
Merge pull request #112 from triplef/fix-nsurlresponse
...
Fixed parsing of NSURLResponse content type header.
2020-03-29 11:30:27 +01:00
rfm
73baca1056
Merge branch 'master' into fix-nsurlresponse
2020-03-29 11:30:18 +01:00
rfm
6af944b1d1
Merge pull request #109 from gnustep/numerical_locale
...
* Source/NSString.m: Attempt to make calls to GSICUCollatorOpen()
2020-03-29 11:27:39 +01:00
rfm
81d70b37c8
Merge branch 'master' into numerical_locale
2020-03-29 11:26:40 +01:00
rfm
2bdc61776e
Merge pull request #114 from triplef/add-nserror-domain
...
Added NSErrorDomain typedef.
2020-03-29 11:17:52 +01:00
Gregory John Casamento
a785456d5f
Copy URL
2020-03-28 03:13:36 -04:00
Gregory John Casamento
bda473e9bd
Remove set for percent escapes in setURL:
2020-03-27 07:06:20 -04:00
Gregory John Casamento
746d3ea8ae
Remove infinite recursion
2020-03-27 06:18:11 -04:00
Gregory John Casamento
5bf97288d0
remove variable
2020-03-27 05:58:10 -04:00
Gregory John Casamento
6fb90273fe
Update implementation
2020-03-27 05:51:07 -04:00
