gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-04-23 09:04:13 +00:00
Code Issues Projects Releases Packages Wiki Activity

improvements from Niels Grewe

Browse source 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@35279 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
rfm 2012-07-09 16:42:19 +00:00
parent 155870ef50
commit f03b67a59c
2 changed files with 36 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
ChangeLog
View file

@ -1,6 +1,7 @@
2012-07-09 Richard Frith-Macdonald <rfm@gnu.org>
* Source/GSFFIInvocation.m: Fix for bug #36706
* Source/NSObject.m: Also, apply patch by Niels Grewe with modsvn commit
2012-07-09 Sebastian Reitenbach <buzzdee>

44
Source/NSObject.m
View file

@ -1575,13 +1575,15 @@ static id gs_weak_load(id obj)
if (aSelector == 0)
[NSException raise: NSInvalidArgumentException
format: @"%@ null selector given", NSStringFromSelector(_cmd)];
/*
* If 'self' is an instance, object_getClass() will get the class,
* and class_getMethodImplementation() will get the instance method.
* If 'self' is a class, object_getClass() will get the meta-class,
* and class_getMethodImplementation() will get the class method.
/* The Apple runtime API would do:
* return class_getMethodImplementation(object_getClass(self), aSelector);
* but this cannot ask self for information about any method reached by
* forwarding, so the returned forwarding function would ge a generic one
* rather than one aware of hardware issues with returning structures
* and floating points. We therefore prefer the GNU API which is able to
* use forwarding callbacks to get better type information.
*/
return class_getMethodImplementation(object_getClass(self), aSelector);
return objc_msg_lookup(self, aSelector);
}
/**
@ -1964,7 +1966,15 @@ static id gs_weak_load(id obj)
[NSException raise: NSInvalidArgumentException
format: @"%@ null selector given", NSStringFromSelector(_cmd)];
msg = class_getMethodImplementation(object_getClass(self), aSelector);
/* The Apple runtime API would do:
* msg = class_getMethodImplementation(object_getClass(self), aSelector);
* but this cannot ask self for information about any method reached by
* forwarding, so the returned forwarding function would ge a generic one
* rather than one aware of hardware issues with returning structures
* and floating points. We therefore prefer the GNU API which is able to
* use forwarding callbacks to get better type information.
*/
msg = objc_msg_lookup(self, aSelector);
if (!msg)
{
[NSException raise: NSGenericException
@ -1989,7 +1999,15 @@ static id gs_weak_load(id obj)
[NSException raise: NSInvalidArgumentException
format: @"%@ null selector given", NSStringFromSelector(_cmd)];
msg = class_getMethodImplementation(object_getClass(self), aSelector);
/* The Apple runtime API would do:
* msg = class_getMethodImplementation(object_getClass(self), aSelector);
* but this cannot ask self for information about any method reached by
* forwarding, so the returned forwarding function would ge a generic one
* rather than one aware of hardware issues with returning structures
* and floating points. We therefore prefer the GNU API which is able to
* use forwarding callbacks to get better type information.
*/
msg = objc_msg_lookup(self, aSelector);
if (!msg)
{
[NSException raise: NSGenericException
@ -2017,7 +2035,15 @@ static id gs_weak_load(id obj)
[NSException raise: NSInvalidArgumentException
format: @"%@ null selector given", NSStringFromSelector(_cmd)];
msg = class_getMethodImplementation(object_getClass(self), aSelector);
/* The Apple runtime API would do:
* msg = class_getMethodImplementation(object_getClass(self), aSelector);
* but this cannot ask self for information about any method reached by
* forwarding, so the returned forwarding function would ge a generic one
* rather than one aware of hardware issues with returning structures
* and floating points. We therefore prefer the GNU API which is able to
* use forwarding callbacks to get better type information.
*/
msg = objc_msg_lookup(self, aSelector);
if (!msg)
{
[NSException raise: NSGenericException