gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-04-23 09:04:13 +00:00
Code Issues Projects Releases Packages Wiki Activity

GSFFIInvocation: Always use objc_msg_lookup

Browse source 
The current implementation skips hidden classes, which breaks KVO.
It turns out that GSGetMethod + method_getImplementation is about
50% slower than objc_msg_lookup (gnustep-2.2 ABI).
This commit is contained in:
Hugo Melder 2024-12-02 16:45:56 +01:00
parent f006598832
commit dec6723bb4
1 changed files with 12 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
Source/GSFFIInvocation.m
View file

@ -435,21 +435,19 @@ GSFFIInvokeWithTargetAndImp(NSInvocation *inv, id anObject, IMP imp)
}
else
{
GSMethod method;
method = GSGetMethod((GSObjCIsInstance(_target)
? (Class)object_getClass(_target)
: (Class)_target),
_selector,
GSObjCIsInstance(_target),
YES);
imp = method_getImplementation(method);
/*
* If fast lookup failed, we may be forwarding or something ...
/* The KVO implementation for libobjc2 (located in gnustep-base Source/NSKVO*)
* uses the non-portable `object_addMethod_np` API from libobjc2.
* `object_addMethod_np` creates or reuses a hidden subclass and adds the swizzled
* method to the hidden class.
*
* When retrieving the object's class with `object_getClass`, hidden classes are skipped
* and the original class is returned.
* This is also the case with `class_getInstanceMethod`, where the
* original class or (non-swizzled) method is returned instead.
*
* The proper way to retrieve an IMP is with `objc_msg_lookup`.
*/
if (imp == 0)
{
imp = objc_msg_lookup(_target, _selector);
}
imp = objc_msg_lookup(_target, _selector);
}
[self setTarget: old_target];