From d4dafeef760c2c076a184cb8f4f21eedcd538a51 Mon Sep 17 00:00:00 2001 From: Richard Frith-MacDonald Date: Tue, 8 Sep 2009 20:51:18 +0000 Subject: [PATCH] avoid duplicate calls to finalize git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@28639 72102866-910b-0410-8b05-ffd578937521 --- ChangeLog | 4 ++++ Source/Additions/GSLock.m | 12 ------------ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7f735efe3..215684ffd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -8,6 +8,10 @@ * Source/NSThread.m: Fix various bugs related to thread exit, Prevent crashes at program termination ...nastily obvious on mingw. + * Source/Additions/GSLock.m: + Remove -dealloc implementations which called -finalize, since the + superclass implementationd does that too, and finalizing twice is + a bad, bad thing. 2009-09-07 Richard Frith-Macdonald diff --git a/Source/Additions/GSLock.m b/Source/Additions/GSLock.m index c8952cb65..9fc4f37b2 100644 --- a/Source/Additions/GSLock.m +++ b/Source/Additions/GSLock.m @@ -73,12 +73,6 @@ locked = -1; } -- (void) dealloc -{ - [self finalize]; - [super dealloc]; -} - - (void) finalize { [[NSNotificationCenter defaultCenter] removeObserver: self]; @@ -224,12 +218,6 @@ counter = -1; } -- (void) dealloc -{ - [self finalize]; - [super dealloc]; -} - - (void) finalize { [[NSNotificationCenter defaultCenter] removeObserver: self];