improve debug/error logging a little.

git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@25780 72102866-910b-0410-8b05-ffd578937521

Headers/Foundation/NSThread.h

@@ -52,7 +52,7 @@ extern "C" {
   NSMutableDictionary	*_thread_dictionary;
   struct autorelease_thread_vars _autorelease_vars;
   id			_gcontext;
-  void                  *_reserved;     // For mfuture expansion
+  void                  *_reserved;     // For future expansion
 }
 
 + (NSThread*) currentThread;

Source/NSThread.m

@@ -853,13 +853,26 @@ gnustep_base_thread_callback(void)
 
 - (void) start
 {
-  if (_active == NO)
+  if (_active == YES)
     {
+      [NSException raise: NSInternalInconsistencyException
+                  format: @"[%@-$@] called on active thread",
+        NSStringFromClass([self class]),
+        NSStringFromSelector(_cmd)];
+    }
+  if (_cancelled == YES)
+    {
+      [NSException raise: NSInternalInconsistencyException
+                  format: @"[%@-$@] called on cancelled thread",
+        NSStringFromClass([self class]),
+        NSStringFromSelector(_cmd)];
+    }
+
   /* Make sure the notification is posted BEFORE the new thread starts.
    */
   gnustep_base_thread_callback();
 
-      /* The thread must persist until if finishes executing.
+  /* The thread must persist until it finishes executing.
    */
   RETAIN(self);
 
@@ -875,7 +888,6 @@ gnustep_base_thread_callback(void)
                   format: @"Unable to detach thread (unknown error)"];
     }
 }
-}
 
 /**
  * Return the thread dictionary.  This dictionary can be used to store

Source/NSTimer.m

@@ -196,6 +196,14 @@ static Class	NSDate_class;
     {
       [self invalidate];
     }
+  if (_target != nil)
+    {
+      DESTROY(_target);
+    }
+  if (_info != nil)
+    {
+      DESTROY(_info);
+    }
   RELEASE(_date);
   [super dealloc];
 }
@@ -253,14 +261,6 @@ static Class	NSDate_class;
  */
 - (void) invalidate
 {
-  if (_target != nil)
-    {
-      DESTROY(_target);
-    }
-  if (_info != nil)
-    {
-      DESTROY(_info);
-    }
   /* OPENSTEP allows this method to be called multiple times. */
   //NSAssert(_invalidated == NO, NSInternalInconsistencyException);
   _invalidated = YES;