mirror of
https://github.com/gnustep/libs-base.git
synced 2025-04-23 00:41:02 +00:00
memorymanagement fixes
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@31273 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Richard Frith-MacDonald
parent
30d632b4c6
commit
c342978801
2 changed files with 40 additions and 16 deletions
47
ChangeLog
47
ChangeLog
|
|
@ -1,3 +1,7 @@
|
|||
2010-09-10 Richard Frith-Macdonald <rfm@gnu.org>
|
||||
|
||||
* Source/NSString.m: Fix retain/release bugs spotted by clang.
|
||||
|
||||
2010-09-10 Adam Fedor <fedor@gnu.org>
|
||||
|
||||
* configure.ac: Check for dladdr without requiring -ldl
|
||||
|
|
@ -11,8 +15,8 @@
|
|||
2010-09-09 Eric Wasylishen <ewasylishen@gmail.com>
|
||||
|
||||
* Source/ObjectiveC2/runtime.c:
|
||||
Change sel_getUid to call sel_registerName, in line with OS X behaviour since
|
||||
10.0
|
||||
Change sel_getUid to call sel_registerName, in line with OS X
|
||||
behaviour since 10.0
|
||||
|
||||
2010-09-02 9avid Chisnall <theraven@gna.org>
|
||||
|
||||
|
|
@ -35,19 +39,44 @@
|
|||
* Headers/Foundation/NSInvocation.h
|
||||
* Headers/Additions/GNUstepBase/DistributedObjects.h
|
||||
|
||||
A huge blob of changes to make -base build with libobjc2, without using the old libobjc2 headers.
|
||||
A huge blob of changes to make -base build with libobjc2, without
|
||||
using the old libobjc2 headers.
|
||||
|
||||
Most of these changes involve simply removing direct manipulation of any runtime structures and replacing them with runtime function calls. For example class->name becomes class_getName(class) and so on.
|
||||
Most of these changes involve simply removing direct manipulation
|
||||
of any runtime structures and replacing them with runtime function
|
||||
calls. For example class->name becomes class_getName(class) and so on.
|
||||
|
||||
libobjc2, like the Apple runtime, the NeXT runtime, and every version of the Objective-C spec, calls the class pointer in id isa. A few files now have #define class_pointer isa at the top. This line replaces class_pointer in the old GNU libobjc headers with isa so either class_pointer or isa can be used for accessing the class of an object. Note: object_getClass() should be used in most cases because, in some future version of the runtime, this will skip things like lock classes and other hidden classes (e.g. KVO classes).
|
||||
libobjc2, like the Apple runtime, the NeXT runtime, and every
|
||||
version of the Objective-C spec, calls the class pointer in id isa.
|
||||
A few files now have #define class_pointer isa at the top.
|
||||
This line replaces class_pointer in the old GNU libobjc headers
|
||||
with isa so either class_pointer or isa can be used for accessing
|
||||
the class of an object. Note: object_getClass() should be used
|
||||
in most cases because, in some future version of the runtime,
|
||||
this will skip things like lock classes and other hidden classes
|
||||
(e.g. KVO classes).
|
||||
|
||||
All of the old forwarding stuff has been removed. Most of this stuff followed convoluted code paths that ended with an exception. A few simply broke in exciting ways. Hopefully no one has used them for the last ten years or so, but we can bring them back with some #ifndef stuff if they're really needed by anyone.
|
||||
All of the old forwarding stuff has been removed. Most of this
|
||||
stuff followed convoluted code paths that ended with an exception.
|
||||
A few simply broke in exciting ways. Hopefully no one has used
|
||||
them for the last ten years or so, but we can bring them back
|
||||
with some #ifndef stuff if they're really needed by anyone.
|
||||
|
||||
There is currently a bug in configure, which prevents dladdr() from being detected, so you need to manually tweak config.h to build - I have not fixed the fall-back code in objc-load.m to work with libobjc2, I just added a new version that uses the loader's functionality directly.
|
||||
There is currently a bug in configure, which prevents dladdr() from
|
||||
being detected, so you need to manually tweak config.h to build -
|
||||
I have not fixed the fall-back code in objc-load.m to work with
|
||||
libobjc2, I just added a new version that uses the loader's
|
||||
functionality directly.
|
||||
|
||||
Although -base now builds, it builds with a lot of warnings. <string.h> is missing from a lot of files, so memcpy() and strlen() generate implicit function declaration warnings.
|
||||
Although -base now builds, it builds with a lot of warnings.
|
||||
<string.h> is missing from a lot of files, so memcpy() and strlen()
|
||||
generate implicit function declaration warnings.
|
||||
|
||||
Additionally, libobjc2 does still provide the sel_{get,register}_*() functions, but they're wrappers around the newer API ones. These are deprecated and are not exposed in the headers. Although they work, we should be replacing them with the libobjc2 versions as soon as possible.
|
||||
Additionally, libobjc2 does still provide the sel_{get,register}_*()
|
||||
functions, but they're wrappers around the newer API ones. These are
|
||||
deprecated and are not exposed in the headers. Although they work,
|
||||
we should be replacing them with the libobjc2 versions as soon as
|
||||
possible.
|
||||
|
||||
This incorporates a patch by Eric.
|
||||
|
||||
|
|
|
|||
|
|
@ -1460,7 +1460,7 @@ handle_printf_atsign (FILE *stream,
|
|||
unsigned int len;
|
||||
const unsigned char *data_bytes;
|
||||
|
||||
d = [[NSDataClass alloc] dataWithContentsOfURL: url];
|
||||
d = [NSDataClass dataWithContentsOfURL: url];
|
||||
if (d == nil)
|
||||
{
|
||||
DESTROY(self);
|
||||
|
|
@ -1470,7 +1470,6 @@ handle_printf_atsign (FILE *stream,
|
|||
len = [d length];
|
||||
if (len == 0)
|
||||
{
|
||||
RELEASE(d);
|
||||
DESTROY(self);
|
||||
return @"";
|
||||
}
|
||||
|
|
@ -1493,7 +1492,6 @@ handle_printf_atsign (FILE *stream,
|
|||
}
|
||||
}
|
||||
self = [self initWithData: d encoding: *enc];
|
||||
RELEASE(d);
|
||||
if (self == nil)
|
||||
{
|
||||
if (error != 0)
|
||||
|
|
@ -1513,7 +1511,7 @@ handle_printf_atsign (FILE *stream,
|
|||
NSData *d;
|
||||
unsigned int len;
|
||||
|
||||
d = [[NSDataClass alloc] dataWithContentsOfURL: url];
|
||||
d = [NSDataClass dataWithContentsOfURL: url];
|
||||
if (d == nil)
|
||||
{
|
||||
DESTROY(self);
|
||||
|
|
@ -1522,12 +1520,10 @@ handle_printf_atsign (FILE *stream,
|
|||
len = [d length];
|
||||
if (len == 0)
|
||||
{
|
||||
RELEASE(d);
|
||||
DESTROY(self);
|
||||
return @"";
|
||||
}
|
||||
self = [self initWithData: d encoding: enc];
|
||||
RELEASE(d);
|
||||
if (self == nil)
|
||||
{
|
||||
if (error != 0)
|
||||
|
|
@ -2257,7 +2253,6 @@ handle_printf_atsign (FILE *stream,
|
|||
unichar a2[aLength+1];
|
||||
unichar *s2 = a2;
|
||||
|
||||
u = s1;
|
||||
[self getCharacters: s1 range: ((NSRange){0, length})];
|
||||
s1[length] = (unichar)0;
|
||||
[aString getCharacters: s2 range: ((NSRange){0, aLength})];
|
||||
|
|
|
|||
Loading…
Reference in a new issue