Tweak last change to avoid possible crashes.

git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@21169 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Richard Frith-Macdonald 2005-04-29 19:10:46 +00:00
parent f84eda1ef9
commit c2f73ff1cb
2 changed files with 25 additions and 9 deletions

View file

@ -1,3 +1,9 @@
2005-04-29 Richard Frith-Macdonald <rfm@gnu.org>
* Source/GSHTTPURLHandle.m: Remove self as an observer of our file
handle on deallocation ... prevent notfications being sent to
deallocated object.
2005-04-28 Richard Frith-Macdonald <rfm@gnu.org>
* Documentation/coding-standards.texi: Added what appear to be the

View file

@ -256,18 +256,28 @@ static void debugWrite(GSHTTPURLHandle *handle, NSData *data)
{
if (sock != nil)
{
NSNotificationCenter *nc = [NSNotificationCenter defaultCenter];
/*
* We might be in an idle state with an outstandng read on the
* socket, keeping the connection alive, but waiting for the
* remote end to drop it.
*/
[nc removeObserver: self
name: NSFileHandleReadCompletionNotification
object: sock];
[sock closeFile];
DESTROY(sock);
}
RELEASE(u);
RELEASE(url);
RELEASE(dat);
RELEASE(parser);
RELEASE(document);
RELEASE(pageInfo);
RELEASE(wData);
RELEASE(wProperties);
RELEASE(request);
DESTROY(u);
DESTROY(url);
DESTROY(dat);
DESTROY(parser);
DESTROY(document);
DESTROY(pageInfo);
DESTROY(wData);
DESTROY(wProperties);
DESTROY(request);
[super dealloc];
}