From b40f7131a730b2875d4a217671c9219eb592b0a0 Mon Sep 17 00:00:00 2001 From: rfm Date: Mon, 8 Feb 2010 20:24:12 +0000 Subject: [PATCH] remove redundant line and improve comments git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@29515 72102866-910b-0410-8b05-ffd578937521 --- Source/NSException.m | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/Source/NSException.m b/Source/NSException.m index d08cca96f..62c74eab1 100644 --- a/Source/NSException.m +++ b/Source/NSException.m @@ -774,6 +774,16 @@ callUncaughtHandler(id value) { (*_NSUncaughtExceptionHandler)(value); } + /* The uncaught exception handler which is set has not exited, + * so we MUST call the builtin handler, (normal behavior of MacOS-X). + * The standard handler is guaranteed to exit/abort, which is the + * required behavior for OSX compatibility. + * NB Cocoa's Exception Handling framework might bypass this behavior + * somehow (it's not clear if it does that or simply wraps various + * things with its own exception handlers thus preventing the + * uncaught handler from ever being needed) ... if anyone contributes + * an implementation, perhaps we could integrate it here. + */ _NSFoundationUncaughtExceptionHandler(value); } @@ -919,18 +929,9 @@ callUncaughtHandler(id value) /* * Call the uncaught exception handler (if there is one). + * The calls the built-in default handler to terminate the program! */ callUncaughtHandler(self); - - /* The uncaught exception handler which is set has not exited, - * so we MUST call the builtin handler, (normal behavior of MacOS-X). - * The standard handler is guaranteed to exit/abort, which is the - * required behavioru for OSX compatibility. - * NB Cocoa's Exception Handling framework bypasses this behavior - * somehow ... if anyone contributes an implementation we could - * integrate it here. - */ - _NSFoundationUncaughtExceptionHandler(self); } thread->_exception_handler = handler->next;