gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-04-23 00:41:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

NSKeyValueCoding+Caching: Add Versioning to IVar Slot

Browse source
This commit is contained in:
hmelder 2024-09-07 19:17:41 +02:00
parent 27cc25c248
commit 95825c0569
1 changed files with 16 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
Source/NSKeyValueCoding+Caching.m
View file

@ -215,7 +215,9 @@ _getBoxedBlockForIVar(NSString *key, Ivar ivar)
slot.offset = ivar_getOffset(ivar);
slot.types = encoding;
slot.version = UINT64_MAX;
// Get the current objc_method_cache_version as we do not explicitly
// request a new slot when looking up ivars.
slot.version = objc_method_cache_version;
switch (encoding[0])
{
@ -626,24 +628,21 @@ valueForKeyWithCaching(id obj, NSString *aKey)
}
cachedSlot = node->key.ptr;
if (cachedSlot->version != UINT64_MAX)
// Check if a new method was registered. If this is the case,
// the objc_method_cache_version was incremented and we need to update the
// cache.
if (objc_method_cache_version != cachedSlot->version)
{
// Check if a new method was registered. If this is the case,
// the objc_method_cache_version was incremented and we need to update the
// cache.
if (objc_method_cache_version != cachedSlot->version)
{
// Lookup the getter
// TODO: We can optimise this by supplying a hint (return type etc.)
// as it is unlikely, that the return type has changed.
slot = ValueForKeyLookup(cls, obj, aKey, [aKey UTF8String],
[aKey length]);
// Lookup the getter
// TODO: We can optimise this by supplying a hint (return type etc.)
// as it is unlikely, that the return type has changed.
slot
= ValueForKeyLookup(cls, obj, aKey, [aKey UTF8String], [aKey length]);
// Update entry
GS_MUTEX_LOCK(cacheTableLock);
memcpy(cachedSlot, &slot, sizeof(struct _KVCCacheSlot));
GS_MUTEX_UNLOCK(cacheTableLock);
}
// Update entry
GS_MUTEX_LOCK(cacheTableLock);
memcpy(cachedSlot, &slot, sizeof(struct _KVCCacheSlot));
GS_MUTEX_UNLOCK(cacheTableLock);
}
return cachedSlot->get(cachedSlot, obj);