From 824d5af6ffeb8a873f1154abb24193ce8b93c180 Mon Sep 17 00:00:00 2001 From: CaS Date: Wed, 22 Jan 2003 10:54:29 +0000 Subject: [PATCH] Minor tidyups git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@15674 72102866-910b-0410-8b05-ffd578937521 --- ChangeLog | 8 ++++++++ Source/Additions/GSMime.m | 7 +++++++ Source/GSFileHandle.m | 2 +- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 4f79633e4..304f84d1f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2003-01-22 Richard Frith-Macdonald + + * Source/Additions/GSMime.m: ifdefed out my last change ...not sure + it was good. + * Source/GSFileHandle.m: Removed bogus semicolon which was causing + code to be executed repeatedly rather than just once ... trivial + optimisation. + 2003-01-21 Adam Fedor * Source/Additions/(GCArray.m, GCDictionary.m, GCObject.m, diff --git a/Source/Additions/GSMime.m b/Source/Additions/GSMime.m index 4491f8f0b..e11e29803 100644 --- a/Source/Additions/GSMime.m +++ b/Source/Additions/GSMime.m @@ -3949,6 +3949,12 @@ static NSCharacterSet *tokenSet = nil; if (v == nil) { start = [content objectAtIndex: 0]; +#if 0 + /* + * The 'start' parameter is not compulsory ... should we + * force it to be set anyway in case some dumb software + * doesn't default to the first part of the message? + */ v = [start contentID]; if (v == nil) { @@ -3956,6 +3962,7 @@ static NSCharacterSet *tokenSet = nil; v = [hdr value]; } [type setParameter: v forKey: @"start"]; +#endif } else { diff --git a/Source/GSFileHandle.m b/Source/GSFileHandle.m index ce3f371c4..5f53490e7 100644 --- a/Source/GSFileHandle.m +++ b/Source/GSFileHandle.m @@ -684,7 +684,7 @@ NSString * const GSSOCKSRecvAddr = @"GSSOCKSRecvAddr"; NSString *shost = nil; NSString *sport = nil; - if (beenHere == NO); + if (beenHere == NO) { NSUserDefaults *defs;