diff --git a/ChangeLog b/ChangeLog index 964bc9b68..349947ef7 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2009-02-16 Richard Frith-Macdonald + + * Source/pathconfig/configure.ac: Warn if gnustep-config not found. + * Source/pathconfig/configure: regenerate + * Headers/Foundation/NSPointerArray.h: Add more comments. + 2009-02-15 Richard Frith-Macdonald * Source/NSPointerArray.m: Initial implementation. Untested. diff --git a/Headers/Foundation/NSPointerArray.h b/Headers/Foundation/NSPointerArray.h index 12c825f5a..3c96feb9f 100644 --- a/Headers/Foundation/NSPointerArray.h +++ b/Headers/Foundation/NSPointerArray.h @@ -76,7 +76,12 @@ extern "C" { - (void) addPointer: (void*)pointer; /** Inserts an item at the specified index causing all higher indexed - * items to be adjusted upwards. + * items to be adjusted upwards.
+ * WARNING ... the Apple documented (and implemented in MacOS-X 10.5) + * behavior is to raise an exception if index is the same as the count of + * items in the array. This is insane ... for arrays, data and strings you + * can insert at the end of an object to append to it, so the behavior of + * this class in MacOS is inconsistent and must be considered buggy. */ - (void) insertPointer: (void*)pointer atIndex: (NSUInteger)index; diff --git a/Source/pathconfig/configure b/Source/pathconfig/configure index dc3b1bcc0..897ccbf0a 100755 --- a/Source/pathconfig/configure +++ b/Source/pathconfig/configure @@ -1715,16 +1715,23 @@ if test "$result" == "no" then # Check if gnustep-config supports the option # --installation-domain-for, and use it if available. That option - # will automatically use the shell variable GNUSTEP_INSTALLATION_DOMAIN - # or the installation-domains.conf files (or the LOCAL default) as appropriate. - # Otherwise, if that option is not available just fall back to LOCAL. + # will automatically use the shell variable GNUSTEP_INSTALLATION_DOMAIN or + # the installation-domains.conf files (or the LOCAL default) as appropriate. + # Otherwise, if that option is not available just fall back to + # using GNUSTEP_INSTALLATION_DOMAIN or (if that was not defiend) LOCAL. if (gnustep-config --help | grep installation-domain) >&5 2>&5 then result=`gnustep-config --installation-domain-for=gnustep-base 2>&5` else - # This case was added on December 2008 and is only for backwards - # compatibility with older versions of gnustep-make. - result=LOCAL + { echo "$as_me:$LINENO: WARNING: The 'gnustep-config' script was not found or out of date." >&5 +echo "$as_me: WARNING: The 'gnustep-config' script was not found or out of date." >&2;} + result=$GNUSTEP_INSTALLATION_DOMAIN + if test "$result" == "" + then + # This case was added on December 2008 and is only for backwards + # compatibility with older versions of gnustep-make. + result=LOCAL + fi fi fi case "$result" in diff --git a/Source/pathconfig/configure.ac b/Source/pathconfig/configure.ac index 0a330f9c8..100602f29 100644 --- a/Source/pathconfig/configure.ac +++ b/Source/pathconfig/configure.ac @@ -358,16 +358,22 @@ if test "$result" == "no" then # Check if gnustep-config supports the option # --installation-domain-for, and use it if available. That option - # will automatically use the shell variable GNUSTEP_INSTALLATION_DOMAIN - # or the installation-domains.conf files (or the LOCAL default) as appropriate. - # Otherwise, if that option is not available just fall back to LOCAL. + # will automatically use the shell variable GNUSTEP_INSTALLATION_DOMAIN or + # the installation-domains.conf files (or the LOCAL default) as appropriate. + # Otherwise, if that option is not available just fall back to + # using GNUSTEP_INSTALLATION_DOMAIN or (if that was not defiend) LOCAL. if (gnustep-config --help | grep installation-domain) >&5 2>&5 then result=`gnustep-config --installation-domain-for=gnustep-base 2>&5` else - # This case was added on December 2008 and is only for backwards - # compatibility with older versions of gnustep-make. - result=LOCAL + AC_MSG_WARN([The 'gnustep-config' script was not found or out of date.]) + result=$GNUSTEP_INSTALLATION_DOMAIN + if test "$result" == "" + then + # This case was added on December 2008 and is only for backwards + # compatibility with older versions of gnustep-make. + result=LOCAL + fi fi fi case "$result" in