From 543b27def0c9c932ca30e703ce39b59c20652c62 Mon Sep 17 00:00:00 2001 From: Andrew McCallum Date: Thu, 29 Jun 1995 00:53:34 +0000 Subject: [PATCH] ([Connection +newForInPort:outPort:ancestorConnection:]): Add comment. I need to fix retain/release for Connection. git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@462 72102866-910b-0410-8b05-ffd578937521 --- Source/Connection.m | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Source/Connection.m b/Source/Connection.m index 519c29018..35932b480 100644 --- a/Source/Connection.m +++ b/Source/Connection.m @@ -563,7 +563,12 @@ static int messagesReceivedCount; [ip registerForInvalidationNotification:newConn]; [op registerForInvalidationNotification:newConn]; + /* xxx This is weird, though. When will newConn ever get dealloc'ed? + connectionArray will retain it, but connectionArray will never get + deallocated. This sort of retain/release cirularity must be common + enough. Think about this and fix it. */ [connectionArray addObject:newConn]; + [connectionArrayGate unlock]; return newConn;