gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-04-23 00:41:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

When overwriting a file with data, do not attempt to set creation date.

Browse source 
When creaqting a new file, try to use the real uid when effective uid is root
This commit is contained in:
Richard Frith-Macdonald 2020-06-25 09:19:44 +01:00
parent b7882e3194
commit 31ea5db30b
1 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
Source/NSData.m
View file

@ -1800,8 +1800,17 @@ failure:
[att removeObjectForKey: NSFileType];
if ([mgr changeFileAttributes: att atPath: path] == NO)
{
NSWarnMLog(@"Unable to correctly set all attributes for '%@'",
path);
NSWarnMLog(@"Unable to correctly set attributes for '%@' to %@",
path, att);
}
}
else if (geteuid() == 0 && [@"root" isEqualToString: NSUserName()] == NO)
{
att = [NSDictionary dictionaryWithObjectsAndKeys:
NSFileOwnerAccountName, NSUserName(), nil];
if ([mgr changeFileAttributes: att atPath: path] == NO)
{
NSWarnMLog(@"Unable to correctly set ownership for '%@'", path);
}
}
}
@ -1963,6 +1972,7 @@ failure:
* attributes match that of the original.
*/
[mAtt removeObjectForKey: NSFileSize];
[mAtt removeObjectForKey: NSFileCreationDate];
[mAtt removeObjectForKey: NSFileModificationDate];
[mAtt removeObjectForKey: NSFileReferenceCount];
[mAtt removeObjectForKey: NSFileSystemNumber];
@ -1971,14 +1981,14 @@ failure:
[mAtt removeObjectForKey: NSFileType];
if ([mgr changeFileAttributes: mAtt atPath: path] == NO)
{
NSWarnMLog(@"Unable to correctly set all attributes for '%@'",
path);
NSWarnMLog(@"Unable to correctly set attributes for '%@' to %@",
path, mAtt);
}
}
else if (geteuid() == 0 && [@"root" isEqualToString: NSUserName()] == NO)
{
att = [NSDictionary dictionaryWithObjectsAndKeys:
NSFileOwnerAccountName, NSUserName(), nil];
NSFileOwnerAccountName, NSUserName(), nil];
if ([mgr changeFileAttributes: att atPath: path] == NO)
{
NSWarnMLog(@"Unable to correctly set ownership for '%@'", path);