gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-05-06 14:40:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

NSTimeZone: Use GetDynamicTimeZoneInformation

Browse source 
tz.StandardName is not always available, does not represent the raw
timezone key from the registry. It appears that ucal_getTimeZoneIDForWindowsID
maps the registry key to a compatible IANA time zone.

The dotnet and flutter implementations also use
GetDynamicTimeZoneInformation and use TimeZoneKeyName.

Here is an example for Asia/Singapore:
StandardTime = Malay Peninsula Standard Time
TimeZoneKeyName = Singapore Standard Time

StandardTime is not registered in the IANA database.
This commit is contained in:
hmelder 2025-04-18 16:54:15 +08:00 committed by Hugo Melder
parent 283ecfe8b2
commit 0606cb9db4
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Source/NSTimeZone.m
View file

@ -1462,7 +1462,7 @@ static int uninitialisedOffset = 100000;
* Try to get timezone from windows system call. * Try to get timezone from windows system call.
*/ */
{ {
TIME_ZONE_INFORMATION tz; DYNAMIC_TIME_ZONE_INFORMATION tz;
DWORD dst; DWORD dst;
wchar_t *tzName; wchar_t *tzName;
@ -1470,15 +1470,14 @@ static int uninitialisedOffset = 100000;
// Get time zone name for US locale as expected by ICU method below // Get time zone name for US locale as expected by ICU method below
LANGID origLangID = GetThreadUILanguage(); LANGID origLangID = GetThreadUILanguage();
SetThreadUILanguage(MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US)); SetThreadUILanguage(MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US));
dst = GetTimeZoneInformation(&tz); dst = GetDynamicTimeZoneInformation(&tz);
SetThreadUILanguage(origLangID); SetThreadUILanguage(origLangID);
// Only tz.StandardName time zone conversions are supported, as // The Zone-Tzid table lacks all daylight time conversions:
// the Zone-Tzid table lacks all daylight time conversions:
// e.g. 'W. Europe Daylight Time' <-> 'Europe/Berlin' is not listed. // e.g. 'W. Europe Daylight Time' <-> 'Europe/Berlin' is not listed.
// //
// See: https://unicode-org.github.io/cldr-staging/charts/latest/supplemental/zone_tzid.html // See: https://unicode-org.github.io/cldr-staging/charts/latest/supplemental/zone_tzid.html
tzName = tz.StandardName; tzName = tz.TimeZoneKeyName;
#else #else
dst = GetTimeZoneInformation(&tz); dst = GetTimeZoneInformation(&tz);