gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-04-23 00:41:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix leak when allocating standard file handles

Browse source
This commit is contained in:
rfm 2025-01-09 10:37:07 +00:00
parent 5f904d0f79
commit 041edc145e
1 changed files with 26 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
Source/GSFileHandle.m
View file

@ -110,9 +110,23 @@ static NSString* NotificationKey = @"NSFileHandleNotificationKey";
@implementation GSFileHandle
+ (void) atExit
{
DESTROY(fh_stdin);
DESTROY(fh_stdout);
DESTROY(fh_stderr);
}
+ (void) initialize
{
[GSTcpTune class];
static BOOL beenHere = NO;
if (NO == beenHere)
{
beenHere = YES;
[GSTcpTune class];
[self registerAtExit];
}
}
/**
@ -189,6 +203,8 @@ static NSString* NotificationKey = @"NSFileHandleNotificationKey";
- (void) dealloc
{
NSString *err = nil;
[self ignoreReadDescriptor];
[self ignoreWriteDescriptor];
@ -213,23 +229,17 @@ static NSString* NotificationKey = @"NSFileHandleNotificationKey";
if (self == fh_stdin)
{
fh_stdin = nil;
DEALLOC
[NSException raise: NSGenericException
format: @"Attempt to deallocate standard input handle"];
err = @"standard input";
}
if (self == fh_stdout)
{
fh_stdout = nil;
DEALLOC
[NSException raise: NSGenericException
format: @"Attempt to deallocate standard output handle"];
err = @"standard output";
}
if (self == fh_stderr)
{
fh_stderr = nil;
DEALLOC
[NSException raise: NSGenericException
format: @"Attempt to deallocate standard error handle"];
err = @"standard error";
}
DESTROY(address);
DESTROY(service);
@ -240,7 +250,12 @@ static NSString* NotificationKey = @"NSFileHandleNotificationKey";
* containing the deallocated object. Thanks to David for this fix.
*/
[self finalize];
[super dealloc];
DEALLOC
if (err)
{
[NSException raise: NSGenericException
format: @"Deallocation of %@ handle", err];
}
}
- (void) finalize