gnustep/apps-projectcenter
0
0
Fork 0
mirror of https://github.com/gnustep/apps-projectcenter.git synced 2025-03-13 14:13:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

Reduce scope of _extScrollView _intScrollView from ivar to local variables, release after setting to content view and fix double-release of _intScrollView.

Browse source
This commit is contained in:
Riccardo Mottola 2023-01-12 23:33:25 +01:00
parent fc194db093
commit fdebc6367f
3 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ChangeLog
View file

@ -1,3 +1,11 @@
2022-01-12 Riccardo Mottola <rm@gnu.org>
* Modules/Editors/ProjectCenter/PCEditor.h
* Modules/Editors/ProjectCenter/PCEditor.m
Reduce scope of _extScrollView _intScrollView from ivar to local
variables, release after setting to content view and fix
double-release of _intScrollView.
2021-11-30 Riccardo Mottola <rm@gnu.org> 2021-11-30 Riccardo Mottola <rm@gnu.org>
* Modules/Editors/ProjectCenter/PCEditorView.h * Modules/Editors/ProjectCenter/PCEditorView.h

2
Modules/Editors/ProjectCenter/PCEditor.h
View file

@ -38,10 +38,8 @@
id _editorManager; id _editorManager;
NSTextField *_extStatusField; NSTextField *_extStatusField;
NSScrollView *_extScrollView;
PCEditorView *_extEditorView; PCEditorView *_extEditorView;
NSTextField *_intStatusField; NSTextField *_intStatusField;
NSScrollView *_intScrollView;
PCEditorView *_intEditorView; PCEditorView *_intEditorView;
NSTextStorage *_storage; NSTextStorage *_storage;
NSMutableString *_path; NSMutableString *_path;

5
Modules/Editors/ProjectCenter/PCEditor.m
View file

@ -41,6 +41,7 @@
- (void)_createWindow - (void)_createWindow
{ {
NSScrollView *_extScrollView;
unsigned int style; unsigned int style;
NSRect winContentRect; NSRect winContentRect;
NSRect rect; NSRect rect;
@ -110,6 +111,7 @@
- (void)_createInternalView - (void)_createInternalView
{ {
NSScrollView *_intScrollView;
NSRect contRect = NSMakeRect(0,0,512,320); NSRect contRect = NSMakeRect(0,0,512,320);
NSRect rect; NSRect rect;
@ -235,9 +237,7 @@
{ {
if ((self = [super init])) if ((self = [super init]))
{ {
_extScrollView = nil;
_extEditorView = nil; _extEditorView = nil;
_intScrollView = nil;
_intEditorView = nil; _intEditorView = nil;
_storage = nil; _storage = nil;
_categoryPath = nil; _categoryPath = nil;
@ -281,7 +281,6 @@
// _window is setReleasedWhenClosed:YES // _window is setReleasedWhenClosed:YES
RELEASE(_path); RELEASE(_path);
RELEASE(_categoryPath); RELEASE(_categoryPath);
RELEASE(_intScrollView);
RELEASE(_storage); RELEASE(_storage);
RELEASE(_window); RELEASE(_window);