Improvements in preferences.

git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/apps/projectcenter/trunk@37199 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Germán Arias 2013-10-07 01:05:13 +00:00
parent 74db97895a
commit cb04cf2bb5
3 changed files with 19 additions and 28 deletions

View file

@ -1,3 +1,10 @@
2013-10-06 German Arias <germanandre@gmx.es>
* Headers/PCPrefController.h:
* PCPrefController.m: Don't retain the user defaults. And don't call
synchronize every time, this are causing conflicts with defaults of the
PC windows, which stores its frames here.
2013-09-24 German Arias <germanandre@gmx.es>
* PCAppController.m (-applicationDidFinishLaunching: and

View file

@ -29,8 +29,6 @@
@interface PCPrefController : NSObject <PCPreferences>
{
NSUserDefaults *userDefaults;
NSMutableDictionary *sectionsDict;
IBOutlet NSPanel *panel;

View file

@ -53,17 +53,6 @@ static PCPrefController *_prefCtrllr = nil;
return nil;
}
// The prefs from the defaults
userDefaults = [NSUserDefaults standardUserDefaults];
RETAIN(userDefaults);
if ([userDefaults objectForKey:@"Version"] == nil)
{
// Clean preferences
[NSUserDefaults resetStandardUserDefaults];
[self setString:@"0.5" forKey:@"Version" notify:NO];
}
[self loadPrefsSections];
return self;
@ -76,9 +65,6 @@ static PCPrefController *_prefCtrllr = nil;
#endif
RELEASE(panel);
[[NSUserDefaults standardUserDefaults] synchronize];
[super dealloc];
}
@ -95,7 +81,8 @@ static PCPrefController *_prefCtrllr = nil;
- (NSString *)stringForKey:(NSString *)key
defaultValue:(NSString *)defaultValue
{
NSString *stringValue = [userDefaults objectForKey:key];
NSString *stringValue = [[NSUserDefaults standardUserDefaults]
objectForKey:key];
if (stringValue)
{
@ -118,7 +105,8 @@ static PCPrefController *_prefCtrllr = nil;
- (BOOL)boolForKey:(NSString *)key
defaultValue:(BOOL)defaultValue
{
NSString *stringValue = [userDefaults objectForKey:key];
NSString *stringValue = [[NSUserDefaults standardUserDefaults]
objectForKey:key];
if (stringValue)
{
@ -140,7 +128,8 @@ static PCPrefController *_prefCtrllr = nil;
- (float)floatForKey:(NSString *)key defaultValue:(float)defaultValue
{
NSString *stringValue = [userDefaults objectForKey:key];
NSString *stringValue = [[NSUserDefaults standardUserDefaults]
objectForKey:key];
if (stringValue)
{
@ -157,8 +146,8 @@ static PCPrefController *_prefCtrllr = nil;
forKey:(NSString *)aKey
notify:(BOOL)notify
{
[userDefaults setObject:stringValue forKey:aKey];
[userDefaults synchronize];
[[NSUserDefaults standardUserDefaults] setObject:stringValue
forKey:aKey];
if (notify)
{
@ -174,8 +163,8 @@ static PCPrefController *_prefCtrllr = nil;
{
NSString *stringValue = boolValue ? @"YES" : @"NO";
[userDefaults setObject:stringValue forKey:aKey];
[userDefaults synchronize];
[[NSUserDefaults standardUserDefaults] setObject:stringValue
forKey:aKey];
if (notify)
{
@ -191,8 +180,8 @@ static PCPrefController *_prefCtrllr = nil;
{
NSString *stringValue = [NSString stringWithFormat:@"%0.1f", floatValue];
[userDefaults setObject:stringValue forKey:aKey];
[userDefaults synchronize];
[[NSUserDefaults standardUserDefaults] setObject:stringValue
forKey:aKey];
if (notify)
{
@ -227,8 +216,6 @@ static PCPrefController *_prefCtrllr = nil;
[section readPreferences];
[sectionsDict setObject:section forKey:sectionName];
}
[userDefaults synchronize];
}
- (void)showPanel:(id)sender
@ -268,7 +255,6 @@ static PCPrefController *_prefCtrllr = nil;
view = [section view];
[sectionsView setContentView:view];
// [sectionsView display];
}
- (void)changeFont:(id)sender