From b97769af801c1d389ee8bb2cadcaaf1c235bb374 Mon Sep 17 00:00:00 2001 From: Sebastian Reitenbach Date: Sat, 9 Feb 2013 14:33:38 +0000 Subject: [PATCH] * Modules/Preferences/Build/PCBuildPrefs.m * Framework/PCButton.m * Modules/Parsers/ProjectCenter/ObjCMethodHandler.m shutup some clang warnings * Framework/PCProjectBrowser.m NSInteger conversions OK Fred git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/apps/projectcenter/trunk@36098 72102866-910b-0410-8b05-ffd578937521 --- ChangeLog | 6 ++++++ Framework/PCButton.m | 2 +- Framework/PCProjectBrowser.m | 6 +++--- Modules/Parsers/ProjectCenter/ObjCMethodHandler.m | 2 +- Modules/Preferences/Build/PCBuildPrefs.m | 8 ++++---- 5 files changed, 15 insertions(+), 9 deletions(-) diff --git a/ChangeLog b/ChangeLog index fddd4c5..e9f2a84 100644 --- a/ChangeLog +++ b/ChangeLog @@ -9,6 +9,12 @@ * Modules/Projects/Tool/PCToolProject.m shutup clang compiler warning about redunant literal string usage + * Modules/Preferences/Build/PCBuildPrefs.m + * Framework/PCButton.m + * Modules/Parsers/ProjectCenter/ObjCMethodHandler.m + shutup some clang warnings + * Framework/PCProjectBrowser.m + NSInteger conversions 2012-11-22 German Arias diff --git a/Framework/PCButton.m b/Framework/PCButton.m index 394f84e..868defa 100644 --- a/Framework/PCButton.m +++ b/Framework/PCButton.m @@ -82,7 +82,7 @@ [super dealloc]; } -- (void)release +- (oneway void)release { // If retain count is number of tracking rects + superview retain, // remove tracking rects. It seems that tracking rects retain this object. diff --git a/Framework/PCProjectBrowser.m b/Framework/PCProjectBrowser.m index 79bc693..5133713 100644 --- a/Framework/PCProjectBrowser.m +++ b/Framework/PCProjectBrowser.m @@ -308,11 +308,11 @@ NSString *PCBrowserDidSetPathNotification = @"PCBrowserDidSetPathNotification"; - (void)reloadLastColumnAndNotify:(BOOL)yn { - int column = [browser lastColumn]; + NSInteger column = [browser lastColumn]; NSString *category = [self nameOfSelectedCategory]; - int selectedColumn = [browser selectedColumn]; + NSInteger selectedColumn = [browser selectedColumn]; NSMatrix *colMatrix = [browser matrixInColumn:selectedColumn]; - int rowCount = 0, colCount = 0, spCount = 0; + NSInteger rowCount = 0, colCount = 0, spCount = 0; PCProject *activeProject = [[project projectManager] activeProject]; NSString *selCellTitle = [[browser selectedCell] stringValue]; diff --git a/Modules/Parsers/ProjectCenter/ObjCMethodHandler.m b/Modules/Parsers/ProjectCenter/ObjCMethodHandler.m index 0faa1d1..18f9718 100644 --- a/Modules/Parsers/ProjectCenter/ObjCMethodHandler.m +++ b/Modules/Parsers/ProjectCenter/ObjCMethodHandler.m @@ -149,7 +149,7 @@ { NotMethod; } - else if ((step == MethodName)) + else if (step == MethodName) { [method appendString:element]; } diff --git a/Modules/Preferences/Build/PCBuildPrefs.m b/Modules/Preferences/Build/PCBuildPrefs.m index 391b0f9..3359bd7 100644 --- a/Modules/Preferences/Build/PCBuildPrefs.m +++ b/Modules/Preferences/Build/PCBuildPrefs.m @@ -113,7 +113,7 @@ NSArray *files; NSString *path; - if ((sender == successField)) + if (sender == successField) { path = [successField stringValue]; } @@ -151,7 +151,7 @@ NSArray *files; NSString *path; - if ((sender == failureField)) + if (sender == failureField) { path = [failureField stringValue]; } @@ -180,7 +180,7 @@ NSArray *files; NSString *path; - if ((sender == rootBuildDirField)) + if (sender == rootBuildDirField) { path = [rootBuildDirField stringValue]; } @@ -209,7 +209,7 @@ NSArray *files; NSString *path; - if ((sender == buildToolField)) + if (sender == buildToolField) { path = [buildToolField stringValue]; }