* Framework/PCProjectBrowser.m

* Framework/PCSaveModified.m
        * Framework/PCProjectLoadedFiles.m
        * Framework/PCProjectBuilder.m
        * Headers/ProjectCenter/PCProjectBrowser.h
        * Headers/ProjectCenter/PCSaveModified.h
        * Headers/ProjectCenter/PCProjectLoadedFiles.h
        * Modules/Projects/Application/PCAppProject+Inspector.h
        * Modules/Projects/Application/PCAppProject+Inspector.m
          some more (unsigned) int -> NS(U)Integer transitions
          not catched from clang, but found by libobjc2 in debug mode

OK Fred



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/apps/projectcenter/trunk@36108 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Sebastian Reitenbach 2013-02-10 18:34:12 +00:00
parent 8562d733c5
commit 7c84efcd92
10 changed files with 44 additions and 33 deletions

View file

@ -6,6 +6,17 @@
* Modules/Preferences/EditorFSC/PCEditorFSCPrefs.m
some more (unsigned) int -> NS(U)Integer transitions
and some shutup of clang compiler warnings
* Framework/PCProjectBrowser.m
* Framework/PCSaveModified.m
* Framework/PCProjectLoadedFiles.m
* Framework/PCProjectBuilder.m
* Headers/ProjectCenter/PCProjectBrowser.h
* Headers/ProjectCenter/PCSaveModified.h
* Headers/ProjectCenter/PCProjectLoadedFiles.h
* Modules/Projects/Application/PCAppProject+Inspector.h
* Modules/Projects/Application/PCAppProject+Inspector.m
some more (unsigned) int -> NS(U)Integer transitions
not catched from clang, but found by libobjc2 in debug mode
2013-02-09 Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>
* Framework/PCFileCreator.m

View file

@ -527,13 +527,13 @@ NSString *PCBrowserDidSetPathNotification = @"PCBrowserDidSetPathNotification";
@implementation PCProjectBrowser (ProjectBrowserDelegate)
- (void) browser:(NSBrowser *)sender
createRowsForColumn:(int)column
createRowsForColumn:(NSInteger)column
inMatrix:(NSMatrix *)matrix
{
NSString *pathToCol;
NSArray *files;
int i = 0;
int count = 0;
NSString *pathToCol;
NSArray *files;
NSUInteger i = 0;
NSUInteger count = 0;
if (sender != browser || !matrix || ![matrix isKindOfClass:[NSMatrix class]])
{

View file

@ -1269,7 +1269,7 @@
}
// --- Error output table delegate methods
- (int)numberOfRowsInTableView:(NSTableView *)aTableView
- (NSInteger)numberOfRowsInTableView:(NSTableView *)aTableView
{
if (errorArray != nil && aTableView == errorOutput)
{
@ -1281,7 +1281,7 @@
- (id) tableView:(NSTableView *)aTableView
objectValueForTableColumn:(NSTableColumn *)aTableColumn
row:(int)rowIndex
row:(NSInteger)rowIndex
{
NSDictionary *errorItem;
@ -1297,7 +1297,7 @@
- (void)errorItemClick:(id)sender
{
int rowIndex = [errorOutput selectedRow];
NSInteger rowIndex = [errorOutput selectedRow];
NSDictionary *error = [errorArray objectAtIndex:rowIndex];
NSPoint position;
PCProjectEditor *projectEditor = [project projectEditor];

View file

@ -341,7 +341,7 @@
@implementation PCProjectLoadedFiles (LoadedFilesTableDelegate)
- (int)numberOfRowsInTableView: (NSTableView *)aTableView
- (NSInteger)numberOfRowsInTableView: (NSTableView *)aTableView
{
if (aTableView != filesList)
{
@ -353,7 +353,7 @@
- (id) tableView: (NSTableView *)aTableView
objectValueForTableColumn: (NSTableColumn *)aTableColumn
row: (int)rowIndex
row: (NSInteger)rowIndex
{
if (aTableView != filesList)
{
@ -376,7 +376,7 @@
- (void) tableView:(NSTableView *)aTableView
setObjectValue:anObject
forTableColumn:(NSTableColumn *)aTableColumn
row:(int)rowIndex
row:(NSInteger)rowIndex
{
/* NSString *path = nil;
NSParameterAssert (rowIndex >= 0 && rowIndex < [editedFiles count]);

View file

@ -137,7 +137,7 @@ BOOL PCRunSaveModifiedFilesPanel(PCEditorManager *manager,
// ============================================================================
// ==== TableView delegate
// ============================================================================
- (int)numberOfRowsInTableView:(NSTableView *)aTableView
- (NSInteger)numberOfRowsInTableView:(NSTableView *)aTableView
{
if (aTableView != filesList)
{
@ -149,7 +149,7 @@ BOOL PCRunSaveModifiedFilesPanel(PCEditorManager *manager,
- (id) tableView:(NSTableView *)aTableView
objectValueForTableColumn:(NSTableColumn *)aTableColumn
row:(int)rowIndex
row:(NSInteger)rowIndex
{
if (aTableView != filesList)
{

View file

@ -84,7 +84,7 @@ extern NSString *PCBrowserDidSetPathNotification;
@interface PCProjectBrowser (ProjectBrowserDelegate)
- (void)browser:(NSBrowser *)sender createRowsForColumn:(int)column
- (void)browser:(NSBrowser *)sender createRowsForColumn:(NSInteger)column
inMatrix:(NSMatrix *)matrix;
@end

View file

@ -65,16 +65,16 @@ typedef enum _PHSortType
@interface PCProjectLoadedFiles (HistoryTableDelegate)
- (int)numberOfRowsInTableView:(NSTableView *)aTableView;
- (NSInteger)numberOfRowsInTableView:(NSTableView *)aTableView;
- (id) tableView:(NSTableView *)aTableView
objectValueForTableColumn:(NSTableColumn *)aTableColumn
row:(int)rowIndex;
row:(NSInteger)rowIndex;
- (void)tableView:(NSTableView *)aTableView
setObjectValue:anObject
forTableColumn:(NSTableColumn *)aTableColumn
row:(int)rowIndex;
row:(NSInteger)rowIndex;
@end

View file

@ -55,11 +55,11 @@ BOOL PCRunSaveModifiedFilesPanel(PCEditorManager *manager,
- (BOOL)saveSelectedFiles;
// TableView delegate
- (int)numberOfRowsInTableView:(NSTableView *)aTableView;
- (NSInteger)numberOfRowsInTableView:(NSTableView *)aTableView;
- (id) tableView:(NSTableView *)aTableView
objectValueForTableColumn:(NSTableColumn *)aTableColumn
row:(int)rowIndex;
row:(NSInteger)rowIndex;
@end

View file

@ -50,16 +50,16 @@
- (void)setDocBasedApp:(id)sender;
- (int)numberOfRowsInTableView:(NSTableView *)aTableView;
- (NSInteger)numberOfRowsInTableView:(NSTableView *)aTableView;
- (id) tableView:(NSTableView *)aTableView
objectValueForTableColumn:(NSTableColumn *)aTableColumn
row:(int)rowIndex;
row:(NSInteger)rowIndex;
- (void) tableView:(NSTableView *)aTableView
setObjectValue:anObject
forTableColumn:(NSTableColumn *)aTableColumn
row:(int)rowIndex;
row:(NSInteger)rowIndex;
- (void)fillFieldsForRow:(int)rowIndex;
- (void)fillFieldsForRow:(NSInteger)rowIndex;
// ----------------------------------------------------------------------------
// --- Notifications

View file

@ -336,9 +336,9 @@ cleanup(NSMutableDictionary *m, NSString *k)
- (void)addDocType: (id)sender
{
int row;
NSInteger row;
NSMutableDictionary *entry = [NSMutableDictionary dictionaryWithCapacity: 6];
int selectedRow = [docTypesList selectedRow];
NSInteger selectedRow = [docTypesList selectedRow];
setOrRemove(entry, [docTypeField stringValue], @"NSName");
setOrRemove(entry, [docNameField stringValue], @"NSHumanReadableName");
@ -448,14 +448,14 @@ cleanup(NSMutableDictionary *m, NSString *k)
// --- Document Types browser
// ----------------------------------------------------------------------------
- (int)numberOfRowsInTableView: (NSTableView *)aTableView
- (NSInteger)numberOfRowsInTableView: (NSTableView *)aTableView
{
return [docTypesItems count];
}
- (id) tableView: (NSTableView *)aTableView
objectValueForTableColumn: (NSTableColumn *)aTableColumn
row: (int)rowIndex
row: (NSInteger)rowIndex
{
NSDictionary *object = nil;
@ -480,11 +480,11 @@ cleanup(NSMutableDictionary *m, NSString *k)
- (void)tableView: (NSTableView *)aTableView
setObjectValue: anObject
forTableColumn: (NSTableColumn *)aTableColumn
row: (int)rowIndex
row: (NSInteger)rowIndex
{
NSMutableDictionary *type = nil;
if (docTypesItems == nil || [docTypesItems count] <= 0)
if (docTypesItems == nil || [docTypesItems count] == 0)
{
return;
}
@ -504,18 +504,18 @@ cleanup(NSMutableDictionary *m, NSString *k)
notify: YES];
}
- (BOOL)tableView: (NSTableView *)aTableView shouldSelectRow: (int)rowIndex
- (BOOL)tableView: (NSTableView *)aTableView shouldSelectRow: (NSInteger)rowIndex
{
[self fillFieldsForRow: rowIndex];
return YES;
}
- (void)fillFieldsForRow: (int)rowIndex
- (void)fillFieldsForRow: (NSInteger)rowIndex
{
NSMutableDictionary *type = nil;
int itemCount = [docTypesItems count];
NSUInteger itemCount = [docTypesItems count];
if (itemCount <= 0 || rowIndex > itemCount || rowIndex < 0)
if (itemCount == 0 || rowIndex > itemCount || rowIndex < 0)
{
[docTypeField setStringValue: @""];
[docNameField setStringValue: @""];