gnustep/apps-gorm
0
0
Fork 0
mirror of https://github.com/gnustep/apps-gorm.git synced 2025-04-22 22:20:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Removed #warning messages.

Browse source 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/apps/gorm/trunk@21694 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Gregory John Casamento 2005-09-04 13:59:16 +00:00
parent eb7c76758e
commit 7057978020
17 changed files with 75 additions and 71 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
ChangeLog
View file

@ -1,3 +1,20 @@
2005-09-04 10:00 Gregory John Casamento <greg_casamento@yahoo.com>
* Palettes/1Windows/GormWindowAttributesInspector.m
* Palettes/1Windows/GormWindowSizeInspector.m
* Palettes/2Controls/GormBoxAttributesInspector.m
* Palettes/2Controls/GormColorWellAttributesInspector.m
* Palettes/2Controls/GormMatrixAttributesInspector.m
* Palettes/2Controls/GormNSTextFieldInspector.gorm
* Palettes/2Controls/GormTextFieldAttributesInspector.m
* Palettes/3Containers/GormTableColumnAttributesInspector.m
* Palettes/3Containers/GormTableViewAttributesInspector.m
* Palettes/4Data/GormNSComboBoxAttributesInspector.h
* Palettes/4Data/GormNSComboBoxAttributesInspector.m
* Palettes/4Data/GormNSComboBoxInspector.gorm
* Palettes/4Data/GormTextViewAttributesInspector.m: Removed all
extraneous and unecessary (and annoying) #warning messages.
2005-08-29 22:41 Gregory John Casamento <greg_casamento@yahoo.com>
* Palettes/2Controls/GormFormAttributesInspector.h: Added ivar

13
Palettes/1Windows/GormWindowAttributesInspector.m
View file

@ -91,11 +91,11 @@
newStyleMask &= ~NSResizableWindowMask;
[object _setStyleMask: newStyleMask];
#warning FIXME
// FIXME: This doesn't refresh the window decoration. How to do that?
// (currently needs manual hide/unhide to update decorations)
[object display];
// The window proxy hides the current button config since
// we need to be able to use them in Gorm. The state is shown
// on the inspector window. Redisplay the window anyway.
[object display];
}
/* backgroundColor */
@ -149,7 +149,8 @@
NSString *string = [[sender cellAtIndex: 0] stringValue];
NSImage *image;
/* the clearButton is disabled if the form is empty, enabled otherwise */
#warning probably not enough ( space ... )
// This allows the user to set the icon, if they wish, for the mini window.
// if it's clear it will default to the application icon.
if ([string length] > 0)
{
image = [NSImage imageNamed: string];

19
Palettes/1Windows/GormWindowSizeInspector.m
View file

@ -89,14 +89,18 @@
name: NSWindowDidResizeNotification
object: object];
#warning why not in setObject: ?
return self;
}
- (void) setObject: (id)obj
{
[super setObject: obj];
// set up tags...
[top setTag: GSWindowMaxYMargin];
[bottom setTag: GSWindowMinYMargin];
[left setTag: GSWindowMinXMargin];
[right setTag: GSWindowMaxXMargin];
return self;
}
@ -132,12 +136,10 @@
}
/* AutoPosition */
#warning Maybye set condition for each button ( more readeable ? )
else if ( [sender isKindOfClass:[NSButton class]] )
else if ( sender == top || sender == bottom ||
sender == left || sender == right )
{
unsigned mask = [sender tag];
if ([sender state] == NSOnState)
{
mask = [object autoPositionMask] | mask;
@ -201,7 +203,6 @@
[super revert:object];
}
#warning what about delegate ? or revert: ??
- (void) windowChangeNotification: (NSNotification*)aNotification
{
[self ok: [aNotification object]];
@ -211,7 +212,7 @@
/* Delegate for textFields / Forms */
- (void)controlTextDidChange:(NSNotification *)aNotification
{
[self ok:[aNotification object]];
[self ok: [aNotification object]];
}

6
Palettes/2Controls/GormBoxAttributesInspector.m
View file

@ -35,7 +35,6 @@
#include "GormBoxAttributesInspector.h"
#warning NSColorWell bug ?
#include <GormCore/NSColorWell+GormExtensions.h>
#include <Foundation/NSNotification.h>
@ -108,8 +107,7 @@
[object setContentViewMargins:
NSMakeSize([horizontalSlider floatValue], [sender floatValue])];
}
/* title cell : background color */
#warning seems to not work
/* title cell : background color, only useful for older NSBox instances */
else if(sender == colorWell)
{
NSTextFieldCell *titleCell = (NSTextFieldCell *)[object titleCell];
@ -119,7 +117,7 @@
[object display];
}
}
#warning NSBox is borken ?
/* only useful for older NSBox instances */
else if(sender == backgroundSwitch)
{
NSTextFieldCell *titleCell = (NSTextFieldCell *)[object titleCell];

1
Palettes/2Controls/GormColorWellAttributesInspector.m
View file

@ -36,7 +36,6 @@
#include "GormColorWellAttributesInspector.h"
#warning GNUstep bug ?
#include <GormCore/NSColorWell+GormExtensions.h>
#include <Foundation/NSNotification.h>

1
Palettes/2Controls/GormMatrixAttributesInspector.m
View file

@ -34,7 +34,6 @@
#include "GormMatrixAttributesInspector.h"
#warning GNUstep bug ?
#include <GormCore/NSColorWell+GormExtensions.h>
#include <Foundation/NSNotification.h>

BIN
Palettes/2Controls/GormNSTextFieldInspector.gorm/data.info
View file

Binary file not shown.

BIN
Palettes/2Controls/GormNSTextFieldInspector.gorm/objects.gorm
View file

Binary file not shown.

1
Palettes/2Controls/GormTextFieldAttributesInspector.m
View file

@ -34,7 +34,6 @@
#include "GormTextFieldAttributesInspector.h"
#warning GNUstep bug ?
#include <GormCore/NSColorWell+GormExtensions.h>
#include <Foundation/NSNotification.h>

8
Palettes/3Containers/GormTableColumnAttributesInspector.m
View file

@ -72,7 +72,6 @@
[cellTable setDoubleAction: @selector(ok:)];
}
#warning set private ?
- (NSString *)_getCellClassName
{
id cell = [[self object] dataCell];
@ -109,7 +108,7 @@
{
[[object headerCell] setAlignment: NSRightTextAlignment];
}
#warning TODO use tags
// [[object headerCell] setAlignment: [[titleAlignmentMatrix selectedRow] tag]];
if ([[object tableView] headerView] != nil)
@ -120,7 +119,6 @@
/* contents Alignment */
else if (sender == contentsAlignmentMatrix)
{
#warning TODO use tags
if ([[sender cellAtRow: 0 column: 0] state] == NSOnState)
{
[[object dataCell] setAlignment: NSLeftTextAlignment];
@ -228,7 +226,6 @@
[cellTable scrollRowToVisible: index];
}
/* title Alignment */
#warning TODO use tags
switch ([[object headerCell] alignment])
{
case NSLeftTextAlignment:
@ -245,7 +242,6 @@
break;
}
/* contents Alignment */
#warning TODO use tags
switch ([[object dataCell] alignment])
{
case NSLeftTextAlignment:
@ -279,7 +275,7 @@
}
// Data Source
#warning replace by an NSBrowser ?
// replace by an NSBrowser ?
- (int) numberOfRowsInTableView: (NSTableView *)tv
{
NSArray *list = [[(id<Gorm>)NSApp classManager] allSubclassesOf: @"NSCell"];

2
Palettes/3Containers/GormTableViewAttributesInspector.m
View file

@ -170,7 +170,7 @@
[object setBackgroundColor: [backgroundColor color]];
}
#warning always needed ?
// #warning always needed ?
[scrollView setNeedsDisplay: YES];
[super ok:sender];

9
Palettes/4Data/GormNSComboBoxAttributesInspector.h
View file

@ -36,11 +36,10 @@
#include <InterfaceBuilder/IBInspector.h>
@class NSMutableArray;
@class NSMatrix;
@class NSButton;
@class NSColorWell;
@class NSForm;
@class NSMatrix;
@class NSTableView;
@class NSTextField;
@ -49,14 +48,16 @@
NSMatrix *alignmentMatrix;
NSColorWell *backgroundColorWell;
NSForm *itemField;
NSMatrix *optionMatrix;
NSButton *editable;
NSButton *selectable;
NSButton *usesDataSource;
NSColorWell *textColorWell;
NSForm *visibleItemsForm;
NSTableView *itemTableView;
NSTextField *itemTxt;
NSButton *addButton;
NSButton *removeButton;
#warning should be private
@private
NSMutableArray *itemsArray;
}
@end

61
Palettes/4Data/GormNSComboBoxAttributesInspector.m
View file

@ -84,15 +84,19 @@
{
[object setAlignment: (NSTextAlignment)[[sender selectedCell] tag]];
}
else if (sender == optionMatrix)
if (sender == editable)
{
BOOL flag;
flag = ([[sender cellAtRow: 0 column: 0] state] == NSOnState) ? YES :NO;
[object setEditable: flag];
flag = ([[sender cellAtRow: 1 column: 0] state] == NSOnState) ? YES :NO;
[object setSelectable: flag];
flag = ([[sender cellAtRow: 2 column: 0] state] == NSOnState) ? YES :NO;
BOOL flag = ([sender state] == NSOnState) ? YES :NO;
[[object cell] setEditable: flag];
}
if (sender == selectable)
{
BOOL flag = ([sender state] == NSOnState) ? YES :NO;
[[object cell] setSelectable: flag];
}
if (sender == usesDataSource)
{
BOOL flag = ([sender state] == NSOnState) ? YES :NO;
[[object cell] setUsesDataSource: flag];
}
else if (sender == visibleItemsForm)
@ -101,7 +105,7 @@
}
else if (sender == itemField )
{
#warning To be done
// #warning To be done
}
else if (sender == addButton)
{
@ -137,21 +141,23 @@
[alignmentMatrix selectCellWithTag: [object alignment]];
#warning Fabien TODO remove the matrix ?
[optionMatrix deselectAllCells];
// clear buttons.
[editable setState: NSOffState];
[selectable setState: NSOffState];
[usesDataSource setState: NSOffState];
if ([object isEditable])
[optionMatrix selectCellAtRow: 0 column: 0];
if ([object isSelectable])
[optionMatrix selectCellAtRow: 1 column: 0];
if ([object usesDataSource])
[optionMatrix selectCellAtRow: 2 column: 0];
// set buttons.
if ([[object cell] isEditable])
[editable setState: NSOnState];
if ([[object cell] isSelectable])
[selectable setState: NSOnState];
if ([[object cell] usesDataSource])
[usesDataSource setState: NSOnState];
[itemTableView reloadData];
[itemTxt setStringValue:@""];
// [[visibleItemsForm cellAtIndex: 0]
// setIntValue: [object numberOfVisibleItems]];
[super revert:sender];
}
@ -185,19 +191,4 @@ objectValueForTableColumn:(NSTableColumn *)aTableColumn
}
return NO;
}
#warning TODO : clean up
// - (BOOL)control:(NSControl *)control textShouldEndEditing:(NSText *)fieldEditor
// {
// // if (fieldEditor != itemTxt )
// // return YES;
// // if ( [[itemTxt setStringValue] isEqualToString:@""] )
// // return YES;
// // else if ( [aTableView selectedRow] != -1 )
// // {
// // [object
// return YES;
// }
@end

5
Palettes/4Data/GormNSComboBoxInspector.gorm/data.classes
View file

@ -14,7 +14,10 @@
itemTxt,
addButton,
removeButton,
itemTableView
itemTableView,
editable,
selectable,
usesDataSource
);
Super = IBInspector;
};

BIN
Palettes/4Data/GormNSComboBoxInspector.gorm/data.info
View file

Binary file not shown.

BIN
Palettes/4Data/GormNSComboBoxInspector.gorm/objects.gorm
View file

Binary file not shown.

3
Palettes/4Data/GormTextViewAttributesInspector.m
View file

@ -32,7 +32,7 @@
#include "GormTextViewAttributesInspector.h"
#warning GNUstep bug ?
// #warning GNUstep bug ?
#include <GormCore/NSColorWell+GormExtensions.h>
#include <AppKit/NSButton.h>
@ -66,7 +66,6 @@
/* Commit changes that the user makes in the Attributes Inspector */
- (void) ok: (id) sender
{
BOOL flag;
BOOL isScrollView;
id scrollView;