Cleanup, ignore, or correct warnings

This commit is contained in:
Gregory Casamento 2023-10-22 14:39:24 -04:00
parent 88e923c48d
commit 01e46d5c6a
20 changed files with 31 additions and 23 deletions

View file

@ -190,10 +190,6 @@ GormCore_OBJC_FILES = \
GormXLIFFDocument.m \
GormCore_RESOURCE_FILES = \
Plugins/Gorm/Gorm.plugin \
Plugins/Nib/Nib.plugin \
Plugins/Xib/Xib.plugin \
Plugins/GModel/GModel.plugin \
Images/GormActionSelected.tiff \
Images/GormAction.tiff \
Images/GormClass.tiff \

View file

@ -73,7 +73,7 @@ NSImage *browserImage = nil;
{
NSBundle *bundle = [NSBundle bundleForClass: [self class]];
if([bundle loadNibNamed: @"GormClassEditor" owner: self topLevelObjects: nil])
if([bundle loadNibNamed: @"GormClassEditor" owner: self topLevelObjects: NULL])
{
NSNotificationCenter *nc = [NSNotificationCenter defaultCenter];
NSRect scrollRect = [classesView frame]; // = {{0, 0}, {340, 188}};

View file

@ -274,7 +274,7 @@ objectValueForTableColumn: (NSTableColumn *)tc
// load the gui...
if (![bundle loadNibNamed: @"GormClassInspector"
owner: self
topLevelObjects: nil])
topLevelObjects: NULL])
{
NSLog(@"Could not open gorm GormClassInspector");
return nil;

View file

@ -2264,6 +2264,8 @@
return result;
}
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpointer-to-int-cast"
- (NSString *) description
{
return [NSString stringWithFormat: @"<%s: %lx> = %@",
@ -2271,6 +2273,7 @@
(unsigned long)self,
_customClassMap];
}
#pragma GCC diagnostic pop
/** Helpful for debugging */
- (NSString *) dumpClassInformation

View file

@ -38,7 +38,7 @@
{
NSBundle *bundle = [NSBundle bundleForClass: [self class]];
if ( ![bundle loadNibNamed:@"GormClassPanel" owner:self topLevelObjects: nil] )
if ( ![bundle loadNibNamed:@"GormClassPanel" owner:self topLevelObjects: NULL] )
{
NSLog(@"Can not load bundle GormClassPanel");
return nil;

View file

@ -92,7 +92,7 @@
{
NSBundle *bundle = [NSBundle bundleForClass: [self class]];
if([bundle loadNibNamed: @"GormConnectionInspector" owner: self topLevelObjects: nil] == NO)
if([bundle loadNibNamed: @"GormConnectionInspector" owner: self topLevelObjects: NULL] == NO)
{
NSLog(@"Couldn't load GormConnectionInsector");
return nil;

View file

@ -58,7 +58,7 @@
// load the gui...
if (![bundle loadNibNamed: @"GormCustomClassInspector"
owner: self
topLevelObjects: nil])
topLevelObjects: NULL])
{
NSLog(@"Could not open gorm GormCustomClassInspector");
return nil;

View file

@ -1436,7 +1436,7 @@ static NSImage *fileImage = nil;
/**
* Detach every object in anArray from the document. Optionally closing editors.
*/
- (void) detachObjects: (NSArray*)anArray closeEditors: (BOOL)close_editors
- (void) detachObjects: (/* NSArray* */ id)anArray closeEditors: (BOOL)close_editors
{
NSEnumerator *enumerator = [anArray objectEnumerator];
NSObject *obj;
@ -2924,6 +2924,8 @@ static void _real_close(GormDocument *self,
/**
* Return a text description of the document.
*/
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpointer-to-int-cast"
- (NSString *) description
{
return [NSString stringWithFormat: @"<%s: %lx> = <<name table: %@, connections: %@>>",
@ -2931,6 +2933,7 @@ static void _real_close(GormDocument *self,
(unsigned long)self,
nameTable, connections];
}
#pragma GCC diagnostic pop
/**
* Returns YES, if obj is a top level object.
@ -3670,6 +3673,7 @@ static void _real_close(GormDocument *self,
}
}
/*
NSLog(@"Checking connections..."); // %@", connections);
en = [connections objectEnumerator];
o = nil;
@ -3677,7 +3681,7 @@ static void _real_close(GormDocument *self,
{
id src = [o source];
id dst = [o destination];
NSString *lable = [o label];
NSString *label = [o label];
if ([o isKindOfClass: [NSNibControlConnector class]])
{
@ -3686,7 +3690,7 @@ static void _real_close(GormDocument *self,
{
}
}
*/
return results;
}

View file

@ -27,7 +27,7 @@ static GormFontViewController *gorm_font_cont = nil;
// load the gui...
if (![bundle loadNibNamed: @"GormFontView"
owner: self
topLevelObjects: nil])
topLevelObjects: NULL])
{
NSLog(@"Could not open gorm GormFontView");
return nil;

View file

@ -16,7 +16,7 @@
return nil;
}
if ([bundle loadNibNamed: @"GormHelpInspector" owner: self topLevelObjects: nil] == NO)
if ([bundle loadNibNamed: @"GormHelpInspector" owner: self topLevelObjects: NULL] == NO)
{
NSLog(@"Could not gorm GormHelpInspector");
return nil;

View file

@ -24,7 +24,7 @@
// load the gui...
if (![bundle loadNibNamed: @"GormImageInspector"
owner: self
topLevelObjects: nil])
topLevelObjects: NULL])
{
NSLog(@"Could not open gorm GormImageInspector");
return nil;

View file

@ -50,7 +50,7 @@
{
NSBundle *bundle = [NSBundle bundleForClass: [self class]];
if([bundle loadNibNamed: @"GormDummyInspector" owner: self topLevelObjects: nil])
if([bundle loadNibNamed: @"GormDummyInspector" owner: self topLevelObjects: NULL])
{
[button setStringValue: [self title]];
}

View file

@ -27,7 +27,7 @@
if ([bundle loadNibNamed: @"GormNSSplitViewInspector"
owner: self
topLevelObjects: nil] == NO)
topLevelObjects: NULL] == NO)
{
NSLog(@"Could not open gorm GormNSSplitViewInspector");
NSLog(@"self %@", self);

View file

@ -27,6 +27,8 @@
#include "GormPrivate.h"
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wunused-variable"
static NSString *typeId = @"Object";
static NSString *typeChar = @"Character or Boolean";
static NSString *typeUChar = @"Unsigned character/bool";
@ -34,7 +36,7 @@ static NSString *typeInt = @"Integer";
static NSString *typeUInt = @"Unsigned integer";
static NSString *typeFloat = @"Float";
static NSString *typeDouble = @"Double";
#pragma GCC diagnostic pop
@interface GormObjectInspector : IBInspector
{

View file

@ -33,7 +33,7 @@
{
NSBundle *bundle = [NSBundle bundleForClass: [self class]];
if([bundle loadNibNamed: @"GormObjectInspector" owner: self topLevelObjects: nil] == NO)
if([bundle loadNibNamed: @"GormObjectInspector" owner: self topLevelObjects: NULL] == NO)
{
NSLog(@"Couldn't load GormObjectInsector");
return nil;

View file

@ -39,6 +39,8 @@
#include <GormCore/GormProtocol.h>
#include <GormCore/GormClassEditor.h>
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wattributes"
extern NSString *GormLinkPboardType;
extern NSString *GormToggleGuidelineNotification;
extern NSString *GormDidModifyClassNotification;
@ -47,6 +49,7 @@ extern NSString *GormDidDeleteClassNotification;
extern NSString *GormWillDetachObjectFromDocumentNotification;
extern NSString *GormDidDetachObjectFromDocumentNotification;
extern NSString *GormResizeCellNotification;
#pragma GCC diagnostic pop
@class GormDocument;
@class GormInspectorsManager;

View file

@ -40,7 +40,7 @@
if ([bundle loadNibNamed: @"GormScrollViewAttributesInspector"
owner: self
topLevelObjects: nil] == NO)
topLevelObjects: NULL] == NO)
{
NSLog(@"Could not open gorm GormScrollViewAttributesInspector");
NSLog(@"self %@", self);

View file

@ -14,7 +14,7 @@
{
NSBundle *bundle = [NSBundle bundleForClass: [self class]];
if (![bundle loadNibNamed: @"GormSetName" owner: self topLevelObjects: nil])
if (![bundle loadNibNamed: @"GormSetName" owner: self topLevelObjects: NULL])
{
return NSAlertAlternateReturn;
}

View file

@ -55,7 +55,7 @@
// load the gui...
if (![bundle loadNibNamed: @"GormSoundInspector"
owner: self
topLevelObjects: nil])
topLevelObjects: NULL])
{
NSLog(@"Could not open gorm GormSoundInspector");
return nil;

View file

@ -81,7 +81,7 @@ NSImage *mVLine = nil;
NSBundle *bundle = [NSBundle bundleForClass: [self class]];
if ([bundle loadNibNamed: @"GormViewSizeInspector"
owner: self
topLevelObjects: nil] == NO)
topLevelObjects: NULL] == NO)
{
NSLog(@"Could not open gorm GormViewSizeInspector");
NSLog(@"self %@", self);