From bda99120026ef49484453c4d52ea7e693fc1c419 Mon Sep 17 00:00:00 2001 From: Eric Wasylishen Date: Sat, 28 Mar 2020 05:09:06 +0000 Subject: [PATCH] gl_sky.c (skybox_name): lazily increase array size from 32 to 1024. See: https://sourceforge.net/p/quakespasm/bugs/38/ Also move its initializer to Sky_Init() and use q_strlcpy() instead of strcpy() for copying to it in Sky_LoadSkyBox(). git-svn-id: svn://svn.code.sf.net/p/quakespasm/code/trunk/quakespasm@1669 af15c1b1-3010-417e-b628-4374ebc0bcbd --- Quake/gl_sky.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Quake/gl_sky.c b/Quake/gl_sky.c index 89868cc0..18edec0c 100644 --- a/Quake/gl_sky.c +++ b/Quake/gl_sky.c @@ -35,7 +35,7 @@ extern int rs_skypasses; //for r_speeds readout float skyflatcolor[3]; float skymins[2][6], skymaxs[2][6]; -char skybox_name[32] = ""; //name of current skybox, or "" if no skybox +char skybox_name[1024]; //name of current skybox, or "" if no skybox gltexture_t *skybox_textures[6]; gltexture_t *solidskytexture, *alphaskytexture; @@ -205,7 +205,7 @@ void Sky_LoadSkyBox (const char *name) return; } - strcpy(skybox_name, name); + q_strlcpy(skybox_name, name, sizeof(skybox_name)); } /* @@ -321,6 +321,7 @@ void Sky_Init (void) Cmd_AddCommand ("sky",Sky_SkyCommand_f); + skybox_name[0] = 0; for (i=0; i<6; i++) skybox_textures[i] = NULL; }