fte/quakespasm
2
0
Fork 0
mirror of https://github.com/Shpoike/Quakespasm.git synced 2025-03-09 19:50:57 +00:00
Code Issues Projects Releases Packages Wiki Activity

r_brush.c (AllocBlock): use calloc() to not leave uninitialized memory.

Browse source 
keeps valgrind happy.
This commit is contained in:
Ozkan Sezer 2021-08-27 17:03:00 +03:00
parent 9f8b569f9b
commit 8797c8c384
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Quake/r_brush.c
View file

@ -726,9 +726,7 @@ int AllocBlock (int w, int h, int *x, int *y)
lightmap_count++;
lightmaps = (struct lightmap_s *) realloc(lightmaps, sizeof(*lightmaps)*lightmap_count);
memset(&lightmaps[texnum], 0, sizeof(lightmaps[texnum]));
/* FIXME: we leave 'gaps' in malloc()ed data, CRC_Block() later accesses
* that uninitialized data and valgrind complains for it. use calloc() ? */
lightmaps[texnum].data = (byte *) malloc(4*LMBLOCK_WIDTH*LMBLOCK_HEIGHT);
lightmaps[texnum].data = (byte *) calloc(1, 4*LMBLOCK_WIDTH*LMBLOCK_HEIGHT);
//as we're only tracking one texture, we don't need multiple copies of allocated any more.
memset(allocated, 0, sizeof(allocated));
}