etlegacy/Update-Installer
0
0
Fork 0
mirror of https://github.com/etlegacy/Update-Installer.git synced 2025-02-16 16:40:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix update failing to install if the system temporary directory path starts with a lower-case letter.

Browse source 
Fix FileUtils::isRelative() to check if the upper-case version of the first character
in the path is a letter.
This commit is contained in:
Robert Knight 2011-12-01 11:49:27 +00:00
parent df89da7ebd
commit 66bafb317f
3 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/FileUtils.cpp
View file

@ -461,7 +461,7 @@ std::string FileUtils::tempPath()
bool startsWithDriveLetter(const char* path)
{
return strlen(path) >= 2 &&
(path[0] >= 'A' && path[0] <= 'Z') &&
(isalpha(path[0])) &&
path[1] == ':';
}

14
src/tests/TestFileUtils.cpp
View file

@ -11,9 +11,21 @@ void TestFileUtils::testDirName()
#endif
}
void TestFileUtils::testIsRelative()
{
#ifdef PLATFORM_WINDOWS
TEST_COMPARE(FileUtils::isRelative("temp"),true);
TEST_COMPARE(FileUtils::isRelative("D:/temp"),false);
TEST_COMPARE(FileUtils::isRelative("d:/temp"),false);
#else
TEST_COMPARE(FileUtils::isRelative("/tmp"),false);
TEST_COMPARE(FileUtils::isRelative("tmp"),true);
#endif
}
int main(int,char**)
{
TestList<TestFileUtils> tests;
tests.addTest(&TestFileUtils::testDirName);
return TestUtils::runTest(tests);
}
}

3
src/tests/TestFileUtils.h
View file

@ -4,4 +4,5 @@ class TestFileUtils
{
public:
void testDirName();
};
void testIsRelative();
};