Merge pull request #39 from cblanc/remove_ips

Remove IP data from plugin endpoint

app/controllers/plugin_controller.rb

@@ -1,58 +1,57 @@
 class PluginController < ApplicationController
-	def user
-	  buffer = []
-	  out = []
+  def user
+    buffer = []
+    out = []
+    if ban = Ban.first(:conditions => ["expiry > UTC_TIMESTAMP() AND steamid = ? AND ban_type = ?", params[:id], Ban::TYPE_SERVER])
+      out << "#USER#"
+      out << "BANNED"
+      out << ban.expiry.utc.to_i
+      out << ban.reason
+      out << "\r\r\r\r\r\r\r"
+    elsif user = User.first(:conditions => {:steamid => params[:id]})
+      teamer = (user.team ? user.teamers.active.of_team(user.team).first : nil)
+      icon = 0
+      rank = "User"
+      if Group.find(Group::DONORS).users.exists?(user)
+        rank = "Donor"
+        icon = icon | 1
+      end
+      if Group.find(Group::CHAMPIONS).users.exists?(user)
+        icon = icon | 2
+      end
+      if user.ref?
+        rank = "Referee"
+        icon = icon | 4
+      end
+      if user.admin?
+        rank = "Admin"
+        icon = icon | 8
+      end
 
-	  if ban = Ban.first(:conditions => ["expiry > UTC_TIMESTAMP() AND steamid = ? AND ban_type = ?", params[:id], Ban::TYPE_SERVER])
-	    out << "#USER#"
-	    out << "BANNED"
-	    out << ban.expiry.utc.to_i
-	    out << ban.reason
-	    out << "\r\r\r\r\r\r\r"
-	  elsif user = User.first(:conditions => {:steamid => params[:id]})
-	    teamer = (user.team ? user.teamers.active.of_team(user.team).first : nil)
-	    icon = 0
-	    rank = "User"
-	    if Group.find(Group::DONORS).users.exists?(user)
-	      rank = "Donor"
-	      icon = icon | 1
-	    end
-	    if Group.find(Group::CHAMPIONS).users.exists?(user)
-	      icon = icon | 2
-	    end
-	    if user.ref?
-	      rank = "Referee"
-	      icon = icon | 4
-	    end
-	    if user.admin?
-	      rank = "Admin"
-	      icon = icon | 8
-	    end
+      buffer << user.steamid
+      buffer << user.username
+      buffer << '0.0.0.0'
+      buffer << (user.team ? Verification.uncrap(user.team.to_s) : "No Team")
+      buffer << user.id
+      buffer << user.team_id
+      buffer << rank
+      buffer << (teamer ? teamer.ranks[teamer.rank] : "")
+      buffer << icon
+      buffer << params[:ch] ? params[:ch] : ""
+      buffer << (user.can_play? ? "1" : "0")
 
-	    buffer << user.steamid
-	    buffer << user.username
-	    buffer << user.lastip
-	    buffer << (user.team ? Verification.uncrap(user.team.to_s) : "No Team")
-	    buffer << user.id
-	    buffer << user.team_id
-	    buffer << rank
-	    buffer << (teamer ? teamer.ranks[teamer.rank] : "")
-	    buffer << icon
-	    buffer << params[:ch] ? params[:ch] : ""
-	    buffer << (user.can_play? ? "1" : "0")
+      out << "#USER#"
+      out << Verification.verify(buffer.join)
+      out << buffer.join("\r")
+    else
+      out << "#FAIL#"
+    end
 
-	    out << "#USER#"
-	    out << Verification.verify(buffer.join)
-	    out << buffer.join("\r")
-	  else
-	    out << "#FAIL#"
-	  end
+    render_out out
+  end
 
-	  render_out out
-	end
-
-	def render_out out
-		@text = out.join("\r")
-		render :layout => false
-	end
+  def render_out out
+    @text = out.join("\r")
+    render :layout => false
+  end
 end

spec/controllers/plugin/plugin_controller_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+describe PluginController do
+  render_views
+
+  describe '#user' do
+    before do
+      create :group, :donors
+      create :group, :champions
+    end
+
+    let!(:user) { create :user_with_team }
+
+    it 'returns user data' do
+      get :user, id: user.steamid
+      expect(response).to be_success
+      expect(response.body).to include(user.username)
+    end
+
+    it 'definitely does not return IP address' do
+      last_ip = '127.0.0.1'
+      user.lastip = last_ip
+      user.save!
+      get :user, id: user.steamid
+      expect(response).to be_success
+      expect(response).to_not include(last_ip) 
+    end
+  end
+end

spec/factories/group.rb

@@ -9,4 +9,14 @@ FactoryGirl.define do
   	name "Admins"
   	id Group::ADMINS
   end
+
+  trait :champions do
+  	name "Champions"
+  	id Group::CHAMPIONS
+  end
+
+  trait :donors do
+  	name "Donors"
+  	id Group::DONORS
+  end
 end