ensl/ensl.org
0
0
Fork 0
mirror of https://github.com/ENSL/ensl.org.git synced 2024-12-26 04:21:36 +00:00
Code Issues Projects Releases Packages Wiki Activity

refined issue to have more clear permission logic

Browse source
This commit is contained in:
Absurdon 2017-07-02 21:16:16 +02:00
parent 0bf5e74c38
commit 9312a90585
1 changed files with 18 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
app/models/issue.rb
View file

@ -24,6 +24,11 @@ class Issue < ActiveRecord::Base
STATUS_SOLVED = 1
STATUS_REJECTED = 2
CATEGORY_WEBSITE = 17
CATEGORY_NSLPLUGIN = 20
CATEGORY_LEAGUE = 22
CATEGORY_GATHER = 52
attr_accessor :assigned_name
attr_protected :id, :created_at, :updated_at
@ -96,7 +101,11 @@ class Issue < ActiveRecord::Base
end
def can_show? cuser
cuser and ((author == cuser) or (Issue::allowed_categories(cuser).include?(self.category_id)))
return false unless cuser
return true if cuser.admin?
((author == cuser) or (Issue::allowed_categories(cuser).include?(self.category_id)))
end
def can_create? cuser
@ -104,12 +113,10 @@ class Issue < ActiveRecord::Base
end
def can_update?(cuser, params = {})
ret = cuser && Issue::allowed_categories(cuser).include?(self.category_id)
if ret && !cuser.admin? && params.member?(:category_id)
ret = (self.category_id.to_s == params[:category_id])
end
ret
return false unless cuser
return true if cuser.admin?
return false unless Issue::allowed_categories(cuser).include?(self.category_id)
!(params.member?(:category_id) && (self.category_id.to_s != params[:category_id]))
end
def can_destroy? cuser
@ -120,10 +127,10 @@ class Issue < ActiveRecord::Base
def self.allowed_categories cuser
allowed = []
allowed << 54 if cuser.admin? || cuser.gather_moderator? # gather
allowed << 17 if cuser.admin? # website
allowed << 22 if cuser.admin? # league
allowed << 20 if cuser.admin? # ensl plugin
allowed << CATEGORY_GATHER if cuser.admin? || cuser.gather_moderator? # gather
allowed << CATEGORY_WEBSITE if cuser.admin? # website
allowed << CATEGORY_LEAGUE if cuser.admin? # league
allowed << CATEGORY_NSLPLUGIN if cuser.admin? # ensl plugin
allowed
end