From 83b358ddbe59bc163f6059428f5b153dde901b9d Mon Sep 17 00:00:00 2001 From: Andre Heider Date: Fri, 23 Feb 2018 13:33:48 +0100 Subject: [PATCH] Fix color glitches on cinematics for selected archs These two casts assumed char is signed, which is not a valid assumption. Be explicit. Fixes idlogo.roq on e.g. aarch64. --- neo/renderer/Cinematic.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/neo/renderer/Cinematic.cpp b/neo/renderer/Cinematic.cpp index 2e259c38..1b207942 100644 --- a/neo/renderer/Cinematic.cpp +++ b/neo/renderer/Cinematic.cpp @@ -1499,8 +1499,8 @@ redump: roq_id = framedata[0] + framedata[1]*256; RoQFrameSize = framedata[2] + framedata[3]*256 + framedata[4]*65536; roq_flags = framedata[6] + framedata[7]*256; - roqF0 = (char)framedata[7]; - roqF1 = (char)framedata[6]; + roqF0 = (signed char)framedata[7]; + roqF1 = (signed char)framedata[6]; if (RoQFrameSize>65536||roq_id==0x1084) { common->DPrintf("roq_size>65536||roq_id==0x1084\n");