dhewm/dhewm3
0
0
Fork 0
mirror of https://github.com/dhewm/dhewm3.git synced 2025-03-21 02:01:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix idStr self-assignment

Browse source 
Was calling memcpy with overlapping parameters which is inefficient,
undefined behavior and Valgrind complained about it.
This commit is contained in:
Turo Lamminen 2017-03-04 11:30:07 +02:00 committed by Daniel Gibson
parent f26f70c717
commit 5da6374663
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
neo/idlib/Str.h
View file

@ -519,6 +519,10 @@ ID_INLINE char &idStr::operator[]( int index ) {
#pragma GCC diagnostic pop
ID_INLINE void idStr::operator=( const idStr &text ) {
if (&text == this) {
return;
}
int l;
l = text.Length();