Fix "unreachable code" warnings

d3xp/BrittleFracture.cpp

@@ -1374,9 +1374,9 @@ bool idBrittleFracture::ClientReceiveEvent( int event, int time, const idBitMsg
 			Shatter( point, dir, time );
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}

d3xp/Entity.cpp

@@ -932,7 +932,8 @@ bool idEntity::DoDormantTests( void ) {
 			return false;
 		}
 		return true;
-	} else {
+	}
+
 	// the monster area is topologically connected to a player, but if
 	// the monster hasn't been woken up before, do the more precise PVS check
 	if ( !fl.hasAwakened ) {
@@ -944,8 +945,6 @@ bool idEntity::DoDormantTests( void ) {
 	// wake up
 	dormantStart = 0;
 	fl.hasAwakened = true;		// only go dormant when area closed off now, not just out of PVS
-		return false;
-	}
 
 	return false;
 }
@@ -5028,10 +5027,10 @@ bool idEntity::ClientReceiveEvent( int event, int time, const idBitMsg &msg ) {
 			StopSound( channel, false );
 			return true;
 		}
-		default: {
+		default:
-			return false;
+			break;
-		}
 	}
+
 	return false;
 }
 
@@ -5509,12 +5508,12 @@ bool idAnimatedEntity::ClientReceiveEvent( int event, int time, const idBitMsg &
 			AddLocalDamageEffect( jointNum, localOrigin, localNormal, localDir, damageDef, collisionMaterial );
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}
 
 /*
 ================

d3xp/Game_network.cpp

@@ -1615,7 +1615,8 @@ bool idGameLocal::DownloadRequest( const char *IP, const char *guid, const char
 		}
 		idStr::snPrintf( urls, MAX_STRING_CHARS, "1;%s", cvarSystem->GetCVarString( "si_serverURL" ) );
 		return true;
-	} else {
+	}
+
 	// 2: table of pak URLs
 	// first token is the game pak if request, empty if not requested by the client
 	// there may be empty tokens for paks the server couldn't pinpoint - the order matters
@@ -1657,8 +1658,6 @@ bool idGameLocal::DownloadRequest( const char *IP, const char *guid, const char
 	idStr::Copynz( urls, reply, MAX_STRING_CHARS );
 	return true;
 }
-	return false;
-}
 
 /*
 ===============

d3xp/Item.cpp

@@ -486,12 +486,12 @@ bool idItem::ClientReceiveEvent( int event, int time, const idBitMsg &msg ) {
 			Event_RespawnFx();
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}
 
 /*
 ================

d3xp/Light.cpp

@@ -1157,9 +1157,9 @@ bool idLight::ClientReceiveEvent( int event, int time, const idBitMsg &msg ) {
 			BecomeBroken( NULL );
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}

d3xp/Misc.cpp

@@ -137,12 +137,12 @@ bool idPlayerStart::ClientReceiveEvent( int event, int time, const idBitMsg &msg
 			}
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}
 
 /*
 ===============

d3xp/Moveable.cpp

@@ -1345,15 +1345,14 @@ idExplodingBarrel::ClientReceiveEvent
 bool idExplodingBarrel::ClientReceiveEvent( int event, int time, const idBitMsg &msg ) {
 
 	switch( event ) {
-		case EVENT_EXPLODE: {
+		case EVENT_EXPLODE:
 			if ( gameLocal.realClientTime - msg.ReadLong() < spawnArgs.GetInt( "explode_lapse", "1000" ) ) {
 				ExplodingEffects( );
 			}
 			return true;
+		default:
+			break;
 	}
-		default: {
+
 	return idBarrel::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}

d3xp/Player.cpp

@@ -7633,11 +7633,9 @@ bool idPlayer::CanGive( const char *statname, const char *value ) {
 			return false;
 		}
 		return true;
-	} else {
-		return inventory.CanGive( this, spawnArgs, statname, value, &idealWeapon );
 	}
 
-	return false;
+	return inventory.CanGive( this, spawnArgs, statname, value, &idealWeapon );
 }
 
 /*
@@ -9817,14 +9815,14 @@ bool idPlayer::ClientReceiveEvent( int event, int time, const idBitMsg &msg ) {
 				// happens if the event and the spectate change are written on the server during the same frame (fraglimit)
 				return true;
 			}
+			break;
+		}
+		default:
+			break;
+	}
+
 	return idActor::ClientReceiveEvent( event, time, msg );
 }
-		default: {
-			return idActor::ClientReceiveEvent( event, time, msg );
-		}
-	}
-	return false;
-}
 
 /*
 ================

d3xp/Projectile.cpp

@@ -1383,12 +1383,12 @@ bool idProjectile::ClientReceiveEvent( int event, int time, const idBitMsg &msg
 			DefaultDamageEffect( this, spawnArgs, collision, velocity );
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}
 
 /*
 ===============================================================================

d3xp/Weapon.cpp

@@ -2757,12 +2757,12 @@ bool idWeapon::ClientReceiveEvent( int event, int time, const idBitMsg &msg ) {
 			}
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}
 
 /***********************************************************************
 

game/BrittleFracture.cpp

@@ -1280,9 +1280,9 @@ bool idBrittleFracture::ClientReceiveEvent( int event, int time, const idBitMsg
 			Shatter( point, dir, time );
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}

game/Entity.cpp

@@ -863,7 +863,8 @@ bool idEntity::DoDormantTests( void ) {
 			return false;
 		}
 		return true;
-	} else {
+	}
+
 	// the monster area is topologically connected to a player, but if
 	// the monster hasn't been woken up before, do the more precise PVS check
 	if ( !fl.hasAwakened ) {
@@ -875,8 +876,6 @@ bool idEntity::DoDormantTests( void ) {
 	// wake up
 	dormantStart = 0;
 	fl.hasAwakened = true;		// only go dormant when area closed off now, not just out of PVS
-		return false;
-	}
 
 	return false;
 }
@@ -4854,10 +4853,10 @@ bool idEntity::ClientReceiveEvent( int event, int time, const idBitMsg &msg ) {
 			StopSound( channel, false );
 			return true;
 		}
-		default: {
+		default:
-			return false;
+			break;
-		}
 	}
+
 	return false;
 }
 
@@ -5297,12 +5296,12 @@ bool idAnimatedEntity::ClientReceiveEvent( int event, int time, const idBitMsg &
 			AddLocalDamageEffect( jointNum, localOrigin, localNormal, localDir, damageDef, collisionMaterial );
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}
 
 /*
 ================

game/Game_network.cpp

@@ -1570,7 +1570,8 @@ bool idGameLocal::DownloadRequest( const char *IP, const char *guid, const char
 		}
 		idStr::snPrintf( urls, MAX_STRING_CHARS, "1;%s", cvarSystem->GetCVarString( "si_serverURL" ) );
 		return true;
-	} else {
+	}
+
 	// 2: table of pak URLs
 	// first token is the game pak if request, empty if not requested by the client
 	// there may be empty tokens for paks the server couldn't pinpoint - the order matters
@@ -1612,8 +1613,6 @@ bool idGameLocal::DownloadRequest( const char *IP, const char *guid, const char
 	idStr::Copynz( urls, reply, MAX_STRING_CHARS );
 	return true;
 }
-	return false;
-}
 
 /*
 ===============

game/Item.cpp

@@ -478,12 +478,12 @@ bool idItem::ClientReceiveEvent( int event, int time, const idBitMsg &msg ) {
 			Event_RespawnFx();
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}
 
 /*
 ================

game/Light.cpp

@@ -1150,9 +1150,9 @@ bool idLight::ClientReceiveEvent( int event, int time, const idBitMsg &msg ) {
 			BecomeBroken( NULL );
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}

game/Misc.cpp

@@ -137,12 +137,12 @@ bool idPlayerStart::ClientReceiveEvent( int event, int time, const idBitMsg &msg
 			}
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}
 
 /*
 ===============

game/Moveable.cpp

@@ -1181,15 +1181,14 @@ idExplodingBarrel::ClientReceiveEvent
 bool idExplodingBarrel::ClientReceiveEvent( int event, int time, const idBitMsg &msg ) {
 
 	switch( event ) {
-		case EVENT_EXPLODE: {
+		case EVENT_EXPLODE:
 			if ( gameLocal.realClientTime - msg.ReadLong() < spawnArgs.GetInt( "explode_lapse", "1000" ) ) {
 				ExplodingEffects( );
 			}
 			return true;
+		default:
+			break;
 	}
-		default: {
+
 	return idBarrel::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}

game/Player.cpp

@@ -8263,14 +8263,14 @@ bool idPlayer::ClientReceiveEvent( int event, int time, const idBitMsg &msg ) {
 				// happens if the event and the spectate change are written on the server during the same frame (fraglimit)
 				return true;
 			}
+			break;
+		}
+		default:
+			break;
+	}
+
 	return idActor::ClientReceiveEvent( event, time, msg );
 }
-		default: {
-			return idActor::ClientReceiveEvent( event, time, msg );
-		}
-	}
-	return false;
-}
 
 /*
 ================

game/Projectile.cpp

@@ -1210,12 +1210,12 @@ bool idProjectile::ClientReceiveEvent( int event, int time, const idBitMsg &msg
 			DefaultDamageEffect( this, spawnArgs, collision, velocity );
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}
 
 /*
 ===============================================================================

game/Weapon.cpp

@@ -2329,12 +2329,12 @@ bool idWeapon::ClientReceiveEvent( int event, int time, const idBitMsg &msg ) {
 			}
 			return true;
 		}
-		default: {
+		default:
+			break;
+	}
+
 	return idEntity::ClientReceiveEvent( event, time, msg );
 }
-	}
-	return false;
-}
 
 /***********************************************************************
 

idlib/math/Matrix.h

@@ -2649,9 +2649,10 @@ ID_INLINE bool idMatX::InverseFastSelf( void ) {
 		case 6:
 			return reinterpret_cast<idMat6 *>(mat)->InverseFastSelf();
 		default:
-			return InverseSelfGeneric();
+			break;
 	}
-	return false;
+
+	return InverseSelfGeneric();
 }
 
 ID_INLINE idVecX idMatX::Multiply( const idVecX &vec ) const {