dhewm/dhewm3-sdk
0
0
Fork 0
mirror of https://github.com/dhewm/dhewm3-sdk.git synced 2025-02-16 17:11:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix argument type of idFuncShootProjectile::*Snapshot()

Browse source 
it should really be idBitMsgDelta&, not idBitMsg& - it's what's used
in the base classes methods that are overridden here.
This commit is contained in:
Daniel Gibson 2020-01-05 03:20:21 +01:00
parent 6cd666e1a3
commit 1b431fac6d
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
d3xp/Misc.cpp
View file

@ -1882,7 +1882,9 @@ void idFuncShootProjectile::Event_Activate( idEntity *activator ) {
idFuncShootProjectile::WriteToSnapshot idFuncShootProjectile::WriteToSnapshot
================ ================
*/ */
void idFuncShootProjectile::WriteToSnapshot( idBitMsg &msg ) const { void idFuncShootProjectile::WriteToSnapshot( idBitMsgDelta &msg ) const {
// DG: at least in vanilla Doom3 the argument should really be idBitMsgDelta, not idBitMsg!
// FIXME: now that the argument type is fixed, maybe the commented out code below can be uncommented again?
// msg.WriteBits( hidden ? 1 : 0, 1 ); // msg.WriteBits( hidden ? 1 : 0, 1 );
// msg.WriteFloat( renderEntity.shaderParms[ SHADERPARM_PARTICLE_STOPTIME ] ); // msg.WriteFloat( renderEntity.shaderParms[ SHADERPARM_PARTICLE_STOPTIME ] );
// msg.WriteFloat( renderEntity.shaderParms[ SHADERPARM_TIMEOFFSET ] ); // msg.WriteFloat( renderEntity.shaderParms[ SHADERPARM_TIMEOFFSET ] );
@ -1893,7 +1895,9 @@ void idFuncShootProjectile::WriteToSnapshot( idBitMsg &msg ) const {
idFuncShootProjectile::ReadFromSnapshot idFuncShootProjectile::ReadFromSnapshot
================ ================
*/ */
void idFuncShootProjectile::ReadFromSnapshot( const idBitMsg &msg ) { void idFuncShootProjectile::ReadFromSnapshot( const idBitMsgDelta &msg ) {
// DG: at least in vanilla Doom3 the argument should really be idBitMsgDelta, not idBitMsg!
// FIXME: now that the argument type is fixed, maybe the commented out code below can be uncommented again?
// hidden = msg.ReadBits( 1 ) != 0; // hidden = msg.ReadBits( 1 ) != 0;
// renderEntity.shaderParms[ SHADERPARM_PARTICLE_STOPTIME ] = msg.ReadFloat(); // renderEntity.shaderParms[ SHADERPARM_PARTICLE_STOPTIME ] = msg.ReadFloat();
// renderEntity.shaderParms[ SHADERPARM_TIMEOFFSET ] = msg.ReadFloat(); // renderEntity.shaderParms[ SHADERPARM_TIMEOFFSET ] = msg.ReadFloat();

5
d3xp/Misc.h
View file

@ -368,8 +368,9 @@ public:
virtual void Think(); virtual void Think();
virtual void WriteToSnapshot( idBitMsg &msg ) const; // DG: at least in vanilla Doom3 the arguments should really be idBitMsgDelta, not idBitMsg!
virtual void ReadFromSnapshot( const idBitMsg &msg ); virtual void WriteToSnapshot( idBitMsgDelta &msg ) const;
virtual void ReadFromSnapshot( const idBitMsgDelta &msg );
private: private:
int mRespawnDelay; int mRespawnDelay;