darkplaces/gmqcc
0
0
Fork 0
mirror of https://github.com/DarkPlacesEngine/gmqcc.git synced 2024-11-27 14:12:36 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add a comment about why we don't delete the owner

Browse source
This commit is contained in:
Wolfgang (Blub) Bumiller 2012-08-18 16:32:07 +02:00
parent 6acf131369
commit ff1506983b
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ast.c
View file

@ -405,7 +405,14 @@ ast_member* ast_member_new(lex_ctx ctx, ast_expression *owner, unsigned int fiel
void ast_member_delete(ast_member *self)
{
/* ast_unref(self->owner); */
/* The owner is always an ast_value, which has .keep=true,
* also: ast_members are usually deleted after the owner, thus
* this will cause invalid access
ast_unref(self->owner);
* once we allow (expression).x to access a vector-member, we need
* to change this: preferably by creating an alternate ast node for this
* purpose that is not garbage-collected.
*/
ast_expression_delete((ast_expression*)self);
mem_d(self);
}