darkplaces/gmqcc
0
0
Fork 0
mirror of https://github.com/DarkPlacesEngine/gmqcc.git synced 2024-11-23 12:22:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

more intelligent handling of unused vector fields

Browse source
This commit is contained in:
Dale Weiler 2016-11-24 14:44:28 +00:00
parent 69fa4f8dbd
commit eab20602b1
1 changed files with 26 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
ir.cpp
View file

@ -633,9 +633,32 @@ bool ir_function_finalize(ir_function *self)
for (auto& lp : self->m_locals) {
ir_value *v = lp.get();
if (v->m_reads.empty() && v->m_writes.size()
&& irwarning(v->m_context, WARN_UNUSED_VARIABLE,
"unused variable: `%s`", v->m_name.c_str())) return false;
if (v->m_reads.empty() && v->m_writes.size()) {
// if it's a vector check to ensure all it's members are unused before
// claiming it's unused, otherwise skip the vector entierly
if (v->m_vtype == TYPE_VECTOR)
{
size_t mask = (1 << 0) | (1 << 1) | (1 << 2), bits = 0;
for (size_t i = 0; i < 3; i++)
if (!v->m_members[i] || (v->m_members[i]->m_reads.empty()
&& v->m_members[i]->m_writes.size()))
bits |= (1 << i);
// all components are unused so just report the vector
if (bits == mask && irwarning(v->m_context, WARN_UNUSED_VARIABLE,
"unused variable: `%s`", v->m_name.c_str()))
return false;
else if (bits != mask)
// individual components are unused so mention them
for (size_t i = 0; i < 3; i++)
if ((bits & (1 << i))
&& irwarning(v->m_context, WARN_UNUSED_VARIABLE,
"unused variable: `%s.%c`", v->m_name.c_str(), "xyz"[i]))
return false;
}
// just a standard variable
else if (irwarning(v->m_context, WARN_UNUSED_VARIABLE,
"unused variable: `%s`", v->m_name.c_str())) return false;
}
}
if (OPTS_OPTIMIZATION(OPTIM_PEEPHOLE)) {